0e1844d65a2504f02679253ae9a536887cddc720: Bug 1595995 - Set MOZ_CONFIGURE_OPTIONS to an empty unicode string when it's empty. r=dmajor
Mike Hommey <mh+mozilla@glandium.org> - Wed, 13 Nov 2019 14:28:49 +0000 - rev 501824
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1595995 - Set MOZ_CONFIGURE_OPTIONS to an empty unicode string when it's empty. r=dmajor Because quote([]) returns an empty byte string, configure currently fails. While ideally, quote would return an unicode string, it is not guaranteed that all uses of quote would actually handle this properly. Differential Revision: https://phabricator.services.mozilla.com/D52795
7272d77d4e808dcbbd1f4f50210786dd326b218a: Backed out 15 changesets (bug 1500049, bug 1172394, bug 1546756, bug 1302379) for failures on browser_disabledForMediaStreamVideos.js. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Thu, 14 Nov 2019 00:32:51 +0200 - rev 501823
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Backed out 15 changesets (bug 1500049, bug 1172394, bug 1546756, bug 1302379) for failures on browser_disabledForMediaStreamVideos.js. CLOSED TREE Backed out changeset 355f090421a6 (bug 1500049) Backed out changeset 306341d0b586 (bug 1302379) Backed out changeset 3ff0d72d23a2 (bug 1546756) Backed out changeset a4f256e68cef (bug 1172394) Backed out changeset d0aa43657e8c (bug 1172394) Backed out changeset edff95b6f724 (bug 1172394) Backed out changeset 94bd21d9b396 (bug 1172394) Backed out changeset 7e7baa73e1ef (bug 1172394) Backed out changeset c3bd415507e8 (bug 1172394) Backed out changeset 1c45b135318d (bug 1172394) Backed out changeset c57c41e8c39e (bug 1172394) Backed out changeset a796541fe5ef (bug 1172394) Backed out changeset 89ad0b553b0f (bug 1172394) Backed out changeset 744fb77a5833 (bug 1172394) Backed out changeset afb4b226ff04 (bug 1172394)
b42b424565738fdf7dd1edaddf73bda03df040f5: Backed out 4 changesets (bug 1588142) for failures on browser_canvasframe_helper_02.js. CLOSED TREE
Csoregi Natalia <ncsoregi@mozilla.com> - Thu, 14 Nov 2019 00:18:21 +0200 - rev 501822
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Backed out 4 changesets (bug 1588142) for failures on browser_canvasframe_helper_02.js. CLOSED TREE Backed out changeset 2284a535c8bc (bug 1588142) Backed out changeset 939b6b3922c2 (bug 1588142) Backed out changeset 1a5f2b044f82 (bug 1588142) Backed out changeset 87336cc7f8a1 (bug 1588142)
e17aebea669678319835e399324df56eb14c78cf: Bug 1596176 - Add missing linux and windows rule for badge positioning. r=bgrins
Tim Nguyen <ntim.bugs@gmail.com> - Wed, 13 Nov 2019 20:11:07 +0000 - rev 501821
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1596176 - Add missing linux and windows rule for badge positioning. r=bgrins Differential Revision: https://phabricator.services.mozilla.com/D52890
cbd4aa02eba91ea5645c4d92fa5fe1d6adf63a1e: Bug 1592007 - land NSS 87f35ba4c82f UPGRADE_NSS_RELEASE, r=keeler
J.C. Jones <jc@mozilla.com> - Wed, 13 Nov 2019 19:44:56 +0000 - rev 501820
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1592007 - land NSS 87f35ba4c82f UPGRADE_NSS_RELEASE, r=keeler 2019-11-13 J.C. Jones <jjones@mozilla.com> * lib/softoken/pkcs11c.c: Bug 1591363 - Fixup double-free of params in nsc_SetupPBEKeyGen r=keeler Caused in commit 7ef8d2604494. [87f35ba4c82f] [tip] 2019-11-07 Makoto Kato <m_kato@ga2.so-net.ne.jp> * lib/freebl/ctr.c: Bug 1592869 - Use NEON for ctr_xor. r=kjacobs Using NEON for ctr_xor, aes_ctr can improve 30%-40%i decode/encode time on Cortex-A72. [d244c7287908] 2019-11-12 Marcus Burghardt <mburghardt@mozilla.com> * gtests/pk11_gtest/pk11_pbkdf2_unittest.cc, lib/pk11wrap/pk11pbe.c, lib/pk11wrap/pk11skey.c, lib/softoken/pkcs11c.c: Bug 1591363 - PBKDF2 memory leaks in NSC_GenerateKey. r=jcj A memory leak was reported and confirmed in this bug. However, during the "manual" analysis of the flow, another possible leak was found. I created a patch for both leaks, added gtests for unexpected keySizes and adjusted the general syntax of the gtest file. [7ef8d2604494] 2019-11-11 Tom Prince <mozilla@hocat.ca> * automation/taskcluster/graph/src/extend.js, automation/taskcluster/windows/setup.sh: Bug 1594891 - Use tc-proxy for nss tooltool; r=dustin,jcj [c33b214b2ec8] 2019-11-08 Daiki Ueno <dueno@redhat.com> * gtests/ssl_gtest/ssl_dhe_unittest.cc, gtests/ssl_gtest/ssl_ecdh_unittest.cc, gtests/ssl_gtest/tls_connect.h, lib/ssl/ssl3con.c: Bug 1566131, check policy against hash algorithms used for ServerKeyExchange, r=mt Summary: This adds necessary policy checks in `ssl3_ComputeCommonKeyHash()`, right before calculating hashes. Note that it currently doesn't check MD5 as it still needs to be allowed in TLS 1.1 or earlier and many tests fail if we change that. Reviewers: mt Reviewed By: mt Bug #: 1566131 [c08947c6af57] 2019-11-08 Kai Engert <kaie@kuix.de> * coreconf/coreconf.dep: Dummy change, trigger a build to test latest NSPR commits. [e766899c72a5] * automation/taskcluster/graph/src/extend.js: Bug 1579836 - Execute NSPR tests as part of NSS continuous integration. r=jcj [46bfbabf7e75] 2019-11-08 Dustin J. Mitchell <dustin@mozilla.com> * automation/taskcluster/graph/npm-shrinkwrap.json, automation/taskcluster/graph/package.json, automation/taskcluster/graph/src/image_builder.js, automation/taskcluster/graph/src/queue.js, automation/taskcluster/scripts/tools.sh, automation/taskcluster/windows/gen_certs.sh, automation/taskcluster/windows/run_tests.sh: Bug 1594891 - Updates to run correctly on the new TC deployment r=jcj * Update the Taskcluster client used in the decision task to one that understands Taskcluster rootUrls. * Update scripts that fetch content to use the TASKCLUSTER_ROOT_URL * the absence of this variale signals an "old" worker so we use an "old" URL [67d630e7cb7c] 2019-11-07 Tom Prince <mozilla@hocat.ca> * .taskcluster.yml, automation/taskcluster/graph/src/extend.js, automation/taskcluster/graph/src/queue.js: Bug 1591275: Switch workers to use AWS Provder; r=kjacobs [a2bebaad41dd] 2019-11-06 Daiki Ueno <dueno@redhat.com> * gtests/pk11_gtest/pk11_module_unittest.cc: Bug 1577803, clang-format, a=bustage [c9014b2892d5] * gtests/pk11_gtest/pk11_module_unittest.cc, gtests/pkcs11testmodule/pkcs11testmodule.cpp, lib/pk11wrap/debug_module.c, lib/pk11wrap/pk11obj.c, lib/pk11wrap/pk11slot.c, lib/pk11wrap/secmodti.h, lib/util/pkcs11t.h: Bug 1577803, pk11wrap: set friendly flag if token implements CKP_PUBLIC_CERTIFICATES_TOKEN, r=rrelyea Summary: This makes NSS look for CKO_PROFILE object at token initialization time to check if it implements the [[ https://docs .oasis-open.org/pkcs11/pkcs11-profiles/v3.0/pkcs11-profiles-v3.0.pdf | Public Certificates Token profile ]] as defined in PKCS #11 v3.0. If it is found, the token is automatically marked as friendly so no authentication attempts will be made when accessing certificates. Reviewers: rrelyea Reviewed By: rrelyea Subscribers: reviewbot Bug #: 1577803 [b39c8eeabe6a] 2019-11-06 Martin Thomson <mt@lowentropy.net> * lib/freebl/blinit.c, lib/freebl/gcm-ppc.c: Bug 1566126 - clang-format, a=bustage [6125200fbc88] 2019-11-06 Lauri Kasanen <cand@gmx.com> * lib/freebl/Makefile, lib/freebl/altivec-types.h, lib/freebl/blapii.h, lib/freebl/blinit.c, lib/freebl/freebl.gyp, lib/freebl/gcm-ppc.c, lib/freebl/gcm.c, lib/freebl/gcm.h: Bug 1566126 - freebl: POWER GHASH Vector Acceleration, r=mt Implementation for POWER8 adapted from the ARM paper: https://conradoplg.cryptoland.net/files/2010/12/gcm14.pdf Benchmark of `bltest -E -m aes_gcm -i tests/aes_gcm/plaintext10 \ -v tests/aes_gcm/iv10 -k tests/aes_gcm/key10 -5 10` on POWER8 3.3GHz. NSS_DISABLE_HW_CRYPTO=1 mode in symmkey opreps cxreps context op time(sec) thrgput aes_gcm_e 309Mb 192 5M 0 0.000 10000.000 10.001 30Mb mode in symmkey opreps cxreps context op time(sec) thrgput aes_gcm_e 829Mb 192 14M 0 0.000 10000.000 10.001 82Mb Notable operf results, sw: samples % image name symbol name 226033 59.3991 libfreeblpriv3.so bmul 80606 21.1824 libfreeblpriv3.so rijndael_encryptBlock128 28851 7.5817 libfreeblpriv3.so gcm_HashMult_sftw hw: 213899 56.2037 libfreeblpriv3.so rijndael_encryptBlock128 45233 11.8853 libfreeblpriv3.so gcm_HashMult_hw So the ghash part is ~5.6x faster. Signed-off-by: Lauri Kasanen <cand@gmx.com> [3d7e509d6d20] 2019-11-05 Marcus Burghardt <mburghardt@mozilla.com> * lib/certdb/certdb.c, lib/util/secport.h: Bug 1589073 - Use of new PR_ASSERT_ARG in certdb.c. r=mt Bug 1588015 introduced in NSPR a new way to ASSERT values where the arguments are always used avoiding "unused variable" errors. This was implemented in NSS, at certdb.c. [73c28cad3dbb] 2019-11-05 Daiki Ueno <dueno@redhat.com> * cpputil/nss_scoped_ptrs.h, gtests/manifest.mn, gtests/pk11_gtest/manifest.mn, gtests/pk11_gtest/pk11_gtest.gyp, gtests/pk11_gtest/pk11_module_unittest.cc, gtests/pkcs11testmodule/Makefile, gtests/pkcs11testmodule/config.mk, gtests/pkcs11testmodule/manifest.mn, gtests/pkcs11testmodule/pkcs11testmodule.cpp, gtests/pkcs11testmodule/pkcs11testmodule.def, gtests/pkcs11testmodule/pkcs11testmodule.gyp, gtests/pkcs11testmodule/pkcs11testmodule.rc, nss.gyp: Bug 1577803, gtests: import pkcs11testmodule from Firefox, r=rrelyea Summary: This adds a mock PKCS #11 module from Firefox and add basic tests around it. This is needed for proper testing of PKCS #11 v3.0 profile objects (D45669). Reviewers: rrelyea Reviewed By: rrelyea Subscribers: reviewbot Bug #: 1577803 [0a86945adf74] Differential Revision: https://phabricator.services.mozilla.com/D52779
3d5e40454c304b5614cb5725c3f5d8cab82c7be3: Bug 1595220 - streamline and sanitize output of distro/platform linux_distribution call in mozinfo r=jmaher
Edwin Takahashi <egao@mozilla.com> - Wed, 13 Nov 2019 19:42:41 +0000 - rev 501819
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1595220 - streamline and sanitize output of distro/platform linux_distribution call in mozinfo r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D52440
73c69599b3f12fa0f2dc45ee29fb202c93a9a695: Bug 1595985 - Add browser.urlbar.closeView webextension API. r=mak,mixedpuppy
Drew Willcoxon <adw@mozilla.com> - Wed, 13 Nov 2019 17:59:08 +0000 - rev 501818
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1595985 - Add browser.urlbar.closeView webextension API. r=mak,mixedpuppy This is based on D52612 Differential Revision: https://phabricator.services.mozilla.com/D52792
a65a260a14fe1950e0b061b12c62e55cea49df4a: Bug 1594735 - Upgrade android emulator used for x86_64 xpcshell tests; r=aerickson
Geoff Brown <gbrown@mozilla.com> - Wed, 13 Nov 2019 17:46:02 +0000 - rev 501817
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1594735 - Upgrade android emulator used for x86_64 xpcshell tests; r=aerickson Upgrade the emulator used by xpcshell tests to 29.2.1, the same version used by all other android tests. We have delayed this upgrade because of intermittent failures seen on the new emulator not seen previously - bug 1568063. After the packet.net upgrade to Ubuntu 18.04, try runs with the new emulator show that bug 1568063 persists but has less impact than the intermittent failures it resolves: More tests pass consistently with the new emulator than with the old. Differential Revision: https://phabricator.services.mozilla.com/D52851
25c597f8703fb05ceb531889a0a478bdebfd78fb: Bug 1594950 - Remove unused SurfaceRegistry API. r=jrmuizel
Markus Stange <mstange@themasta.com> - Wed, 13 Nov 2019 18:33:24 +0000 - rev 501816
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1594950 - Remove unused SurfaceRegistry API. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D51758
4391cb16bb0b291b02a1fc42a7295c564d76d9ec: Bug 1594950 - Change NextSurface APIs to accept a dirty region, and remove the public method InvalidateRegionThroughoutSwapchain. r=jrmuizel
Markus Stange <mstange@themasta.com> - Wed, 13 Nov 2019 18:55:18 +0000 - rev 501815
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1594950 - Change NextSurface APIs to accept a dirty region, and remove the public method InvalidateRegionThroughoutSwapchain. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D50878
2a2c01a5ce9a25fd52d55b56a1b238eebfc7d752: Bug 1594950 - Track the nsChildView invalid region inside nsChildView, rather than on the layer. r=jrmuizel
Markus Stange <mstange@themasta.com> - Wed, 13 Nov 2019 18:33:20 +0000 - rev 501814
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1594950 - Track the nsChildView invalid region inside nsChildView, rather than on the layer. r=jrmuizel This allows us to move the call to InvalidateRegionThroughoutSwapchain to just before the call to NextSurface, which makes it easier to merge the two calls. Differential Revision: https://phabricator.services.mozilla.com/D50877
aa9475c27a6d5c4359f3a6d1c058ef9b1b440f5b: Bug 1594950 - Bake the layer size and its opaqueness into the layer, don't allow mutating it. r=jrmuizel
Markus Stange <mstange@themasta.com> - Wed, 13 Nov 2019 18:46:02 +0000 - rev 501813
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1594950 - Bake the layer size and its opaqueness into the layer, don't allow mutating it. r=jrmuizel These settings are now supplied during layer creation and never change. Consumers must now create new NativeLayer objects if they want to change size or toggle opaqueness. This aligns the NativeLayer API with DirectComposition's capabilities. It also simplifies swap chain management. Differential Revision: https://phabricator.services.mozilla.com/D51757
d791bfa31f08ec478b2ef6ca4f89b3a8849d723b: bug 1412438 - add preference to disable HPKP by default r=jcj
Dana Keeler <dkeeler@mozilla.com> - Wed, 13 Nov 2019 18:35:35 +0000 - rev 501812
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
bug 1412438 - add preference to disable HPKP by default r=jcj As Chrome has removed support for the HPKP (HTTP Public Key Pinning) header, continuing to support it in Firefox is a compatibility risk. This patch adds the preference "security.cert_pinning.hpkp.enabled" and sets it to false by default. As such, the platform will no longer process the HPKP header nor consult any cached HPKP information for certificate pins. Preloaded (statically-compiled) pins are still enabled in Firefox by default. This patch also disables dynamically setting pins via our remote security settings infrastructure, as it uses the same backend and represents similar compatibility risk. Differential Revision: https://phabricator.services.mozilla.com/D52773
c17276cc50c4d18a28a8653028f9489ba998d9bc: Bug 1595212 - Use MaybeUninit in nsString tests. r=SimonSapin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 Nov 2019 12:39:23 +0000 - rev 501811
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1595212 - Use MaybeUninit in nsString tests. r=SimonSapin Differential Revision: https://phabricator.services.mozilla.com/D52824
da8d5a96f3c8f93be0a4ca787eedd410dcf3b0c8: Bug 1595285 - Fix TestUtils.waitForCondition to not use setInterval. r=mak
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 Nov 2019 18:24:02 +0000 - rev 501810
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1595285 - Fix TestUtils.waitForCondition to not use setInterval. r=mak The test that is timing out with these patches does something relatively simple: await TestUtils.waitForCondition(async function() { let color = await ContentTask.spawn(browserWindow, async function() { /* Do stuff... */ }); return color == something; }); await closeWindow(browserWindow); Turns out that this can intermittently leak the window due to waitForCondition using setInterval. setInterval can schedule multiple tasks while awaiting for the inner ContentTask. What this means, is that we may still have a ContentTask awaiting us when we get to close the window. Closing the window makes the ContentTask not finish, and thus we leak a promise keeping alive the window in gPromises: https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/testing/mochitest/BrowserTestUtils/ContentTask.jsm#24 Which means that we keep alive the window all the way until shutdown. Fix it by ensuring that we only run one task at a time. Differential Revision: https://phabricator.services.mozilla.com/D52833
2284a535c8bc5a34c448665c99bdf0d7ea2d73f2: Bug 1588142 - Prevent internal pages from flashing the URL on reload r=Gijs
Kirk Steuber <ksteuber@mozilla.com> - Tue, 12 Nov 2019 18:01:01 +0000 - rev 501809
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1588142 - Prevent internal pages from flashing the URL on reload r=Gijs Converting about:preferences's root from a xul:window to an html:html involves moving the Fluent-translated title attribute to a title tag, which starts empty and is populated by Fluent. The initially-empty title tag causes the title bar to flash "about:preferences" on reload. This patch ignores empty title updates via DOMTitleChanged events to prevent this. This is only done for internal pages (i.e. pages with a system principal). Differential Revision: https://phabricator.services.mozilla.com/D52289
939b6b3922c2802abedb336712b08e605687e716: Bug 1588142 - Test fixes r=Gijs
Kirk Steuber <ksteuber@mozilla.com> - Tue, 12 Nov 2019 18:00:28 +0000 - rev 501808
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1588142 - Test fixes r=Gijs Differential Revision: https://phabricator.services.mozilla.com/D51714
1a5f2b044f827e6063218f6f6ff6a6b7e6066106: Bug 1588142 - Move Fluent about:preferences title attribute to a title tag r=fluent-reviewers,Gijs
Kirk Steuber <ksteuber@mozilla.com> - Tue, 12 Nov 2019 18:00:05 +0000 - rev 501807
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1588142 - Move Fluent about:preferences title attribute to a title tag r=fluent-reviewers,Gijs Differential Revision: https://phabricator.services.mozilla.com/D51713
87336cc7f8a1afe7dbd042fd23de5ae3010b0845: Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins
Kirk Steuber <ksteuber@mozilla.com> - Wed, 13 Nov 2019 17:46:30 +0000 - rev 501806
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1588142 - about:preferences - migrate the root xul:window element to an html:html element r=Gijs,bgrins Differential Revision: https://phabricator.services.mozilla.com/D51712
da9476881d622b2d519f589f39d586f974ddb1e1: Bug 1595762: Make type object loads subject to CSP frame ancestors. r=jkt,annevk
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Wed, 13 Nov 2019 14:52:55 +0000 - rev 501805
Push 36801 by dvarga@mozilla.com at Thu, 14 Nov 2019 17:12:31 +0000
Bug 1595762: Make type object loads subject to CSP frame ancestors. r=jkt,annevk Differential Revision: https://phabricator.services.mozilla.com/D52806
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip