0c72849843c8658d93487ffd981df30ebbadd823: Bug 1528608 - Fix Inspector tooltip typo. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 18 Feb 2019 15:58:59 +0000 - rev 459791
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1528608 - Fix Inspector tooltip typo. r=gl Ensures the keyboard shortcut on **non-macOS platforms** is completely wrapped inside the parentheses of the tooltip label. Differential Revision: https://phabricator.services.mozilla.com/D20140
1653389a43da7384d8c703a491872341de441d8e: Bug 1528760 - Fix issues in the setDesktopBackground dialog following the ChromeUtils.import global changes. r=johannh
Mark Banner <standard8@mozilla.com> - Mon, 18 Feb 2019 15:53:45 +0000 - rev 459790
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1528760 - Fix issues in the setDesktopBackground dialog following the ChromeUtils.import global changes. r=johannh Differential Revision: https://phabricator.services.mozilla.com/D20180
41ae89b35b129a4f7b72c11888201da0c27b5f55: Bug 1522516 - Port browser_privatebrowsing_about.js to QuantumBar. r=dao
Mark Banner <standard8@mozilla.com> - Mon, 18 Feb 2019 14:45:50 +0000 - rev 459789
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1522516 - Port browser_privatebrowsing_about.js to QuantumBar. r=dao Differential Revision: https://phabricator.services.mozilla.com/D20128
5bf878fbdd804ef2b13bf825d20d179ba74c2388: Bug 1522514 - Port browser/base/content/test/popups/browser_popupUI.js to work with QuantumBar. r=dao
Mark Banner <standard8@mozilla.com> - Mon, 18 Feb 2019 14:44:08 +0000 - rev 459788
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1522514 - Port browser/base/content/test/popups/browser_popupUI.js to work with QuantumBar. r=dao Differential Revision: https://phabricator.services.mozilla.com/D20127
804ed8ea1cba9a987df0224915f63cd30749c08b: Merge mozilla-central to autoland.
Cosmin Sabou <csabou@mozilla.com> - Mon, 18 Feb 2019 17:58:54 +0200 - rev 459787
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Merge mozilla-central to autoland.
86f113763508bd09ec0b5b62e9607ed998f1f728: Bug 1509752 - Improved visibility of non-standard HTTP codes (600-999). r=Honza
Hemakshi Sachdev <sachdev.hemakshi@gmail.com> - Mon, 18 Feb 2019 15:38:53 +0000 - rev 459786
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1509752 - Improved visibility of non-standard HTTP codes (600-999). r=Honza Differential Revision: https://phabricator.services.mozilla.com/D20070
22194fd99032f5b3bdfe4fcb1a8fc1472c908451: Bug 1528486 - Fix the indentation to match the nesting level r=mak
Sylvestre Ledru <sledru@mozilla.com> - Mon, 18 Feb 2019 14:55:34 +0000 - rev 459785
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1528486 - Fix the indentation to match the nesting level r=mak Differential Revision: https://phabricator.services.mozilla.com/D20064
e9d51144a284dd5be358e7e62d362592399e607c: Bug 1521928 - Changing addObserver to removeObserver. r=Standard8
championshuttler <shivams2799@gmail.com> - Mon, 18 Feb 2019 13:55:06 +0000 - rev 459784
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1521928 - Changing addObserver to removeObserver. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D20097
711d305d6bd95eba2a69c679a5bb332f6fe52ad8: Bug 1526987 - Remove Immutable usage in NotificationBox.js ;r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 Feb 2019 13:30:01 +0000 - rev 459783
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1526987 - Remove Immutable usage in NotificationBox.js ;r=Honza. Immutable takes noticable amount of time to be loaded, and we have very little use of it. Removing it will help with the load time (especially for the console). Differential Revision: https://phabricator.services.mozilla.com/D19376
113c037637b6e8ad8a51a09e988bcbdb98f5b691: Bug 1517469 - Enable Events Telemetry for Uptake monitory r=janerik
Mathieu Leplatre <mathieu@mozilla.com> - Fri, 15 Feb 2019 09:38:18 +0000 - rev 459782
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1517469 - Enable Events Telemetry for Uptake monitory r=janerik Enable Events Telemetry for Uptake monitoring Differential Revision: https://phabricator.services.mozilla.com/D19496
6d5a1544d885281cf3c90524bb10ac97c7a9558c: Bug 1528735 - Only stop if all tests are skipped on the first iteration, r=Ms2ger
James Graham <james@hoppipolla.co.uk> - Mon, 18 Feb 2019 13:33:44 +0000 - rev 459781
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1528735 - Only stop if all tests are skipped on the first iteration, r=Ms2ger If we got past the first iteration we shouldn't stop for the skipped count matching the total tests since we increment this with the total tests on each iteration. Differential Revision: https://phabricator.services.mozilla.com/D20153
3b8ea81b8c44724ef995ffed086745ff61842a93: Bug 1528717 - Check whether `extension` is set before using it r=rpl
Rob Wu <rob@robwu.nl> - Mon, 18 Feb 2019 13:00:17 +0000 - rev 459780
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1528717 - Check whether `extension` is set before using it r=rpl Differential Revision: https://phabricator.services.mozilla.com/D20143
16a5ff10a90f51290d53a8828c838d994cf646c2: Bug 1519217 - Add keyboard shortcut to element picker tooltip. r=gl,flod
Razvan Caliman <rcaliman@mozilla.com> - Mon, 18 Feb 2019 12:28:14 +0000 - rev 459779
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
Bug 1519217 - Add keyboard shortcut to element picker tooltip. r=gl,flod Augments tooltip with keyboard shortcut. Reflects the multiple shortcuts possible on macOS as seen in the Inspector tab tooltip. See: https://developer.mozilla.org/en-US/docs/Tools/Keyboard_shortcuts#Opening_and_closing_tools Differential Revision: https://phabricator.services.mozilla.com/D19407
9469362459f91fece70a390dc221129486e82143: bug 1526938: geckodriver: lint main.rs; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:57 +0000 - rev 459778
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
bug 1526938: geckodriver: lint main.rs; r=whimboo Minor post-patch linting to silence some clippy warnings. Depends on D19434 Differential Revision: https://phabricator.services.mozilla.com/D19435
a02142b7aefff4ff6a57c7f11618d98369b5f8eb: bug 1526938: geckodriver: provide better error messages for flags; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:55 +0000 - rev 459777
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
bug 1526938: geckodriver: provide better error messages for flags; r=whimboo This will print something along the line of: geckodriver: error: invalid --port: invalid digit found in string: asd Or: geckodriver: error: invalid --port: number too large to fit in target type: 123123123123 We also Include the error message from IpAddr::from_str() to the user. This will make the error seen by the user look something like this: geckodriver: error: invalid IP address syntax: 123123:4444 Depends on D19433 Differential Revision: https://phabricator.services.mozilla.com/D19434
561a8cb2db9b422f4af806b1bb0c7c8448b4d298: bug 1526938: geckodriver: ensure --help is listed in help message; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:53 +0000 - rev 459776
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
bug 1526938: geckodriver: ensure --help is listed in help message; r=whimboo For completeness, this makes sure the --help flag is included in its own help message. Depends on D19432 Differential Revision: https://phabricator.services.mozilla.com/D19433
b2768473a2805ecf5b58aa0c341d1085d65bad96: bug 1526938: geckodriver: separate flag parsing and application logic; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:51 +0000 - rev 459775
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
bug 1526938: geckodriver: separate flag parsing and application logic; r=whimboo Flag parsing and application logic belong to one, very long, spaghetti-like function. This patch introduces a distinction between checking the sanity of the CLI input and what action to take depending on that input. Depends on D19431 Differential Revision: https://phabricator.services.mozilla.com/D19432
16aac9625fdee7452d9cfdcf06115512db3d9410: bug 1526938: geckodriver: display help message on non-clap errors; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:49 +0000 - rev 459774
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
bug 1526938: geckodriver: display help message on non-clap errors; r=whimboo The help message is implicitly included in clap error descriptions, but they are not for errors originating from this file. By introducing a FatalError::help_included() function we make sure we print the help message in all cases. An alternative implementation, which perhaps would be more idiomatic, would be to prepare the help message within the fmt::Display trait implementation for FatalError, but I could find no way of passing in a reference to clap::App without storing it in an atomic global const. Depends on D19430 Differential Revision: https://phabricator.services.mozilla.com/D19431
e37346a0237371a6d707c27d0c7c3e4bf3dbdff1: bug 1526938: geckodriver: fix missing flag parsing errors; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:47 +0000 - rev 459773
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
bug 1526938: geckodriver: fix missing flag parsing errors; r=whimboo Because we emit the flag parsing errors to the log, through error!(), they are subject to whether the logging subsystem is enabled. Because logging is disabled by default, no error information is currently displayed to the user. Since we cannot initialise logging implicitly due to the risk of emitting log messages the user did not request, this patch changes geckodriver to print the flag parsing errors to stderr Depends on D19429 Differential Revision: https://phabricator.services.mozilla.com/D19430
6ad3a665abdfbaf3ebc96213b4bd4febfa4b062f: bug 1526938: geckodriver: organise args a bit more consistently; r=whimboo
Andreas Tolfsen <ato@sny.no> - Mon, 18 Feb 2019 12:48:45 +0000 - rev 459772
Push 35572 by cbrindusan@mozilla.com at Mon, 18 Feb 2019 21:43:34 +0000
bug 1526938: geckodriver: organise args a bit more consistently; r=whimboo Depends on D19428 Differential Revision: https://phabricator.services.mozilla.com/D19429
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip