0b088b6f83128a841076379faceb11416b4006ce: Bug 1277979 - Add even more fuzz to the downscale-during-decode GTests to fix failures on OS 10.10. r=me DONTBUILD
Seth Fowler <mark.seth.fowler@gmail.com> - Tue, 21 Jun 2016 21:33:30 -0700 - rev 302303
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1277979 - Add even more fuzz to the downscale-during-decode GTests to fix failures on OS 10.10. r=me DONTBUILD
08e186081db2275a88437b51e925b92f13f572dc: Bug 1280053 TextInputHandler should initialize WidgetKeyboardEvent without already handled characters r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Sun, 19 Jun 2016 01:13:16 +0900 - rev 302302
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1280053 TextInputHandler should initialize WidgetKeyboardEvent without already handled characters r=m_kato TextInputHandler may dispatch keypress events after InsertText() is called if there was composition and it's committed by "current" keydown event. In that case, [NSEvent characters] may have the committing string. For example, when Opt+e of US keyboard layout started composition, Cmd+v causes committing the "`" character and pasting the clipboard text. Then, the "v" key's keydown event's |characters| is "`v". So, after InsertText() is called with "`", TextInputHandler shouldn't dispatch keypress event for "`" again. I.e., the KeyboardEvent.key value should be "v" rather than "`v". For solving this issue, TextInputHandlerBase::AutoInsertStringClearer which is created at every InsertText() call should store the inserted string to TextInputHandlerBase::KeyEventState. However, for making the implemntation simpler, it should recode only when the inserting string is actually a part of [mKeyEvent characters]. Then, TextInputHandlerBase::KeyEventState can compute unhandled insert string at initializing WidgetKeyboardEvent. So, finally, TextInputHandlerBase::InitKeyEvent() should be called via TextInputHandlerBase::KeyEventState::InitKeyEvent(). This ensures that all key events which may cause InsertText() calls are always initialized with unhandled string. MozReview-Commit-ID: A9o8o9pV2XV
da005aa1d83c4a32c2ff1d211d359581013352ed: Bug 1271483 - p16. gtest for list-string functions - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 26 May 2016 19:24:35 +1000 - rev 302301
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p16. gtest for list-string functions - r=cpearce Moved templated code to VideoUtils.h, so it can more easily be reused, and tested. MozReview-Commit-ID: 3vOvaj5VVhm
575198d83ce778cd2dad9e7ce6978b6f58937738: Bug 1271483 - p15. Check if issues have been solved - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Wed, 25 May 2016 00:41:53 +1000 - rev 302300
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p15. Check if issues have been solved - r=cpearce To determine if an issue has been solved, go through the possible prefs that would have been saved by the front-end, to see if any previously-unplayable formats/key systems are now playable, in which case we notify the frontend, to record the issue-solved telemetry. MozReview-Commit-ID: DmU50i6FtG8
d780f0ca52436491f471b24bb99a22222aa9c870: Bug 1271483 - p14. Demagicify ReportStringId strings - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Wed, 25 May 2016 01:03:21 +1000 - rev 302299
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p14. Demagicify ReportStringId strings - r=cpearce Combine notification type and web-console string id into structs, simpler to pass around, and will be useful to go through them when checking for solved issues. MozReview-Commit-ID: Hy3bMG3m12V
2bc76d3f7827576cd8d24e0dee225fc0d61dd2f4: Bug 1271483 - p13. Rework formats list - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Wed, 25 May 2016 03:24:14 +1000 - rev 302298
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p13. Rework formats list - r=cpearce Renamed AppendToStringList to AppendToFormatsList, to distinguish from other string-based lists. Ensure that list items don't contain commas, as commas are used as separators, and we don't want&need to introduce escaping. Added FormatsListContains. MozReview-Commit-ID: 8KpuhSjCW3d
bbfd03f4dd55e48e79da005863abc9d1ded85dc5: Bug 1271483 - p12. Use StringListContains to filter notifications - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 26 May 2016 17:01:52 +1000 - rev 302297
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p12. Use StringListContains to filter notifications - r=cpearce Using string-list iterator instead of bespoke code, to go through the decoder doctor notifications-allowed pref. MozReview-Commit-ID: 8sxopvlRrz7
93bc3bb0c1be31bfa9057782b7af069ac71bedf2: Bug 1271483 - p11. Implement comma-sep-string for-range iterator - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 26 May 2016 16:43:16 +1000 - rev 302296
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p11. Implement comma-sep-string for-range iterator - r=cpearce Utility class&function that creates an iteratable range from a comma-separated string, where each iteration will give a dependent substring (i.e., no string copy happening). This will help with going through lists of unplayable formats, to see if issues have been solved. If useful enough, this could later be published to a more public location (e.g. mfbt or xpcom). MozReview-Commit-ID: 3XP5PwQZFA1
60ea602c56cd331055f3b1dbe37d6f47a68a22c7: Bug 1271483 - p10. Front-end handling of prefs&telemetry - r=gijs
Gerald Squelart <gsquelart@mozilla.com> - Thu, 26 May 2016 23:46:52 +1000 - rev 302295
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p10. Front-end handling of prefs&telemetry - r=gijs When an issue is reported, save the unplayable formats/key-systesm in a pref, keyed by the detailed issue string id, and report the infobar-shown telemetry. More telemetry when the "Show me how" button is clicked. And final telemetry (and clearing the prefs) when the issue is solved. MozReview-Commit-ID: 4PgaPMVfjsQ
e7a336a48fa292c95f24d36984b55d2e28dab1b8: Bug 1271483 - p9. Report more details from DecDecDiagnostics - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 26 May 2016 23:26:10 +1000 - rev 302294
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p9. Report more details from DecDecDiagnostics - r=cpearce Fill up extra details in notification: Web-console notification string id (will be used as telemetry key), and whether the issue is present or has been solved. MozReview-Commit-ID: AzhuIvGqb2p
95bef5e7a918842f4f257ce2ff9f0033b0930bed: Bug 1271483 - p8. More details in DecoderDoctorNotification - r=smaug
Gerald Squelart <gsquelart@mozilla.com> - Thu, 26 May 2016 23:24:40 +1000 - rev 302293
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p8. More details in DecoderDoctorNotification - r=smaug Added some fields required by telemetry. Now with some documentation! (Notifying code in p9, handling code in p10.) MozReview-Commit-ID: 4mTHlkpjCxx
55ea04d784cce0c5d8d19b50a1c1b9acb559d314: Bug 1271483 - p7. Telemetry histogram for DecDoc infobar stats - r=cpearce, f=bsmedberg
Gerald Squelart <gsquelart@mozilla.com> - Wed, 22 Jun 2016 09:57:43 +1000 - rev 302292
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p7. Telemetry histogram for DecDoc infobar stats - r=cpearce, f=bsmedberg MozReview-Commit-ID: KB2r22Z3rss
cb46c7802ff480513f2fa711f73982aa4f81c924: Bug 1271483 - p6. Separate unplayable formats by missing decoder - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 12 May 2016 16:28:11 +1000 - rev 302291
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p6. Separate unplayable formats by missing decoder - r=cpearce This helps determine how each format is affected by some issues. It will be needed in later patches, to see when the issue get fixed (by noticing that these formats become playable again). MozReview-Commit-ID: 2wFzmnX5rBY
32ec54498aee8a604ec4b0ec46556abd30de9daa: Bug 1271483 - p5. Remove 'canPlay', can be inferred otherwise - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 12 May 2016 12:49:36 +1000 - rev 302290
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p5. Remove 'canPlay', can be inferred otherwise - r=cpearce Instead of having yet-another variable, just infer playability from the lists of playable&unplayable formats, which we need to look at anyway. MozReview-Commit-ID: ABc2WtWADzN
ed7dc9a4cbe6e0abcb45a101c34c1d89d45c0c07: Bug 1271483 - p4. Fixed console reporting for Widevine case - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Mon, 16 May 2016 15:43:19 +1000 - rev 302289
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p4. Fixed console reporting for Widevine case - r=cpearce Message was not including the actual Key System at issue. MozReview-Commit-ID: CavgSGmYCa3
f156a01bcf57ed7f66c0a0b65dadda0db3f4bcec: Bug 1271483 - p3. constify loop variable - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Thu, 12 May 2016 15:52:24 +1000 - rev 302288
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p3. constify loop variable - r=cpearce MozReview-Commit-ID: zp0VicPXxk
9f59435519a308283a47d93755df61cf7ba17a5f: Bug 1271483 - p2. Fixed whitespace style - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Mon, 16 May 2016 21:35:14 +1000 - rev 302287
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p2. Fixed whitespace style - r=cpearce MozReview-Commit-ID: IypVNdXjoSr
59ecc73662cc147798b9d905a01c6601cda5dced: Bug 1271483 - p1. Optionally treat media.wmf.disabled as WMF failure for Decoder Doctor - r=cpearce
Gerald Squelart <gsquelart@mozilla.com> - Tue, 24 May 2016 01:33:37 +1000 - rev 302286
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1271483 - p1. Optionally treat media.wmf.disabled as WMF failure for Decoder Doctor - r=cpearce This can be used to test Decoder Doctor on Windows, but disabling WMF through prefs, to trigger an Decoder Doctor infobar. MozReview-Commit-ID: 1aRk111VFO7
10fd0046cf6f477a630f8afe19ee9d16578b4aaf: Bug 1280712 - Remove redundant memset() of GIF frame data. r=edwin
Seth Fowler <mark.seth.fowler@gmail.com> - Fri, 17 Jun 2016 17:59:48 -0700 - rev 302285
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1280712 - Remove redundant memset() of GIF frame data. r=edwin
63ed21f31fc7934f1eb700aa1a4330e029e53116: Bug 1249578 (Part 2) - Add a test that decoding ICOs with a size mismatch between the BIH header and the ICO directory entry fails. r=njn
Seth Fowler <mark.seth.fowler@gmail.com> - Mon, 20 Jun 2016 20:27:39 -0700 - rev 302284
Push 30356 by cbook@mozilla.com at Wed, 22 Jun 2016 11:45:58 +0000
Bug 1249578 (Part 2) - Add a test that decoding ICOs with a size mismatch between the BIH header and the ICO directory entry fails. r=njn
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip