075c4404c2c81312c55db4c3e04ab4d1ddef8aa8: Bug 1611777 - Part 15: Support FunCall/FunApply optimisations for optional chaining. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:31:20 +0000 - rev 512106
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 15: Support FunCall/FunApply optimisations for optional chaining. r=yulia This change allows the bytecode emitter to use `JSOp::FunCall` resp. `JSOp::FunApply` for calls in optional chain expressions. Differential Revision: https://phabricator.services.mozilla.com/D61162
46d27864b908bd0926d6ec0b25ee165917cd9887: Bug 1611777 - Part 14: Simplify two lines in optionalExpr(). r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:30:36 +0000 - rev 512105
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 14: Simplify two lines in optionalExpr(). r=yulia - We don't need to test for `tt == TokenKind::Eof` when we return for `tt != TokenKind::OptionalChain` anyway. - Omit local variable for the result value and instead use a tail-call. This matches the local style in the parser more closely. Differential Revision: https://phabricator.services.mozilla.com/D61161
9c5786b1bccbe2f1b481d51395d915e7e58eaaf0: Bug 1611777 - Part 13: Remove unused default arguments from parser methods. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:30:01 +0000 - rev 512104
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 13: Remove unused default arguments from parser methods. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D61160
849b4d84f74365b7202bf923423335967e07712e: Bug 1611777 - Part 12: Use optionalExpr() for update expressions to match spec grammar. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:29:22 +0000 - rev 512103
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 12: Use optionalExpr() for update expressions to match spec grammar. r=yulia Using optionalExpr matches the spec grammar more closely. This change also modifies the reported error message. `++a?.b` reported before this change "unexpected token: '?.'", but now reports "invalid increment/decrement operand". Differential Revision: https://phabricator.services.mozilla.com/D61159
468ff3d2cf8e3e6e5eac3a79285cc9e53f7e2f22: Bug 1611777 - Part 11: Support optional chaining in class heritage expression. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:29:15 +0000 - rev 512102
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 11: Support optional chaining in class heritage expression. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D61158
e82fbc9dee634c29797c5019b12c2c1ebea3eba1: Bug 1611777 - Part 10: Remove unnecessary "allowCallSyntax" parameter from Parser::optionalExpr. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:28:05 +0000 - rev 512101
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 10: Remove unnecessary "allowCallSyntax" parameter from Parser::optionalExpr. r=yulia All callers pass allowCallSyntax=true, so we can omit this parameter. Differential Revision: https://phabricator.services.mozilla.com/D61157
fa5be03a588c387639907f7e72b4d86d2bfe880a: Bug 1611777 - Part 9: Replace an if-statement with an assertion. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:27:22 +0000 - rev 512100
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 9: Replace an if-statement with an assertion. r=yulia `nextMember` is never nullptr, so we don't need to test for it. Differential Revision: https://phabricator.services.mozilla.com/D61156
958adec635321bfe453ac74672a8e2037b953259: Bug 1611777 - Part 8: Add missing emitGet in emitOptionalElemExpression. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:26:44 +0000 - rev 512099
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 8: Add missing emitGet in emitOptionalElemExpression. r=yulia Aligns emitOptionalElemExpression() with emitOptionalDotExpression(), so it's easier to compare both methods against each other. Differential Revision: https://phabricator.services.mozilla.com/D61155
5c9241e7ce20ad0f1cfe2b852e4b86f8054f1c85: Bug 1611777 - Part 7: Add missing entries to list of valid optional chain start expressions. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:26:06 +0000 - rev 512098
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 7: Add missing entries to list of valid optional chain start expressions. r=yulia The previous list contained some invalid entries (`await` and comma-expression) and was missing some possible parse node kinds. Differential Revision: https://phabricator.services.mozilla.com/D61154
4a8a350bba27258f5821dec1e37157e39375e3d1: Bug 1611777 - Part 6: Crash for unexpected super-base in optional call. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:25:23 +0000 - rev 512097
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 6: Crash for unexpected super-base in optional call. r=yulia `super?.()` isn't valid code, so we don't need to handle this case. Differential Revision: https://phabricator.services.mozilla.com/D61153
9dba40e8b408fed3e4acd5c05b568f4dc51a8991: Bug 1611777 - Part 5: Remove unnecessary super-handling in optional delete. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:24:50 +0000 - rev 512096
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 5: Remove unnecessary super-handling in optional delete. r=yulia The child node of a DeleteOptionalChainExpr node can't be a super-property accessor, so we can remove this code. Drive-by: Reindent some stack comments. Differential Revision: https://phabricator.services.mozilla.com/D61152
95890e60c691ce8977bd1fe8287215d9312bc3ee: Bug 1611777 - Part 4: `super` can't occur on the left-hand side of an optional chain. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:24:12 +0000 - rev 512095
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 4: `super` can't occur on the left-hand side of an optional chain. r=yulia Moves the `isSuper()` method from the base class to the (non-optional) derived classes, because `super?.x` isn't valid syntax, so it's confusing to be able to ask if an optional property access is applied on `super`. The next part will further simplify `BytecodeEmitter::emitDelete{Element,Property}InOptChain()`. Differential Revision: https://phabricator.services.mozilla.com/D61151
9615eaa325edb53fef683cdbbd89370fddc064b1: Bug 1611777 - Part 3: Change emitOptionalCalleeAndThis() parameter to use CallNode. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:23:29 +0000 - rev 512094
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 3: Change emitOptionalCalleeAndThis() parameter to use CallNode. r=yulia That way we don't need the explicit cast. Differential Revision: https://phabricator.services.mozilla.com/D61148
45f7fa06cc3c87cc2896668ee58a7b4a738520f0: Bug 1611777 - Part 2: Merge same blocks in emitDeleteOptionalChain(). r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:23:21 +0000 - rev 512093
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 2: Merge same blocks in emitDeleteOptionalChain(). r=yulia Differential Revision: https://phabricator.services.mozilla.com/D61147
bdb8620ff7f53ce13ec9166338685221e10c4f16: Bug 1611777 - Part 1: Report syntax error for optional property access in self-hosting code. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:22:09 +0000 - rev 512092
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1611777 - Part 1: Report syntax error for optional property access in self-hosting code. r=yulia We already assert that this case isn't allowed in the bytecode emitter. Also report a syntax error to match normal property access. Differential Revision: https://phabricator.services.mozilla.com/D61146
f567747993a768266230a07deec085c690e8fa37: Bug 1610539, don't perform focusing steps when attaching formfill to a document such as a subframe that isn't focused r=MattN
Neil Deakin <neil@mozilla.com> - Thu, 30 Jan 2020 08:03:21 +0000 - rev 512091
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1610539, don't perform focusing steps when attaching formfill to a document such as a subframe that isn't focused r=MattN Differential Revision: https://phabricator.services.mozilla.com/D60882
94d79e1b849ef7b7c33be1f9bd57e904d9433d6a: no bug - coding style C++ doc: fix the note syntax r=sg
Sylvestre Ledru <sledru@mozilla.com> - Thu, 30 Jan 2020 08:00:21 +0000 - rev 512090
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
no bug - coding style C++ doc: fix the note syntax r=sg Differential Revision: https://phabricator.services.mozilla.com/D61246
cb607bf4c55f687bfbf3e298dc4073ddcd10a945: Bug 1612135 - Allow Result<V, E> to be used with a MOZ_NON_PARAM_TYPE E. r=emilio,froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 29 Jan 2020 21:22:39 +0000 - rev 512089
Push 37072 by csabou@mozilla.com at Thu, 30 Jan 2020 15:44:43 +0000
Bug 1612135 - Allow Result<V, E> to be used with a MOZ_NON_PARAM_TYPE E. r=emilio,froydnj Differential Revision: https://phabricator.services.mozilla.com/D61214
7b794b53736c781545273accf33ed5bd23d0abea: Bug 1611200 - Update expectation on win for shared-worker-import-blob-url.any.html. r=jgraham
Andreea Pavel <apavel@mozilla.com> - Wed, 29 Jan 2020 13:00:54 +0000 - rev 512088
Push 37071 by csabou@mozilla.com at Thu, 30 Jan 2020 09:53:03 +0000
Bug 1611200 - Update expectation on win for shared-worker-import-blob-url.any.html. r=jgraham Differential Revision: https://phabricator.services.mozilla.com/D61134
4277d047f5b7b05a1a7e12a0067fc91b0b0e3183: Bug 1611990 - Firefox omits Rust log messages of less than WARN level unless compiled in debug mode r=chmanchester
Andy Grover <agrover@mozilla.com> - Thu, 30 Jan 2020 04:51:51 +0000 - rev 512087
Push 37071 by csabou@mozilla.com at Thu, 30 Jan 2020 09:53:03 +0000
Bug 1611990 - Firefox omits Rust log messages of less than WARN level unless compiled in debug mode r=chmanchester Differential Revision: https://phabricator.services.mozilla.com/D61254
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip