0503d6eb70a76db7a941202ae05e1bfc448714b2: Bug 1467352 - Fix test_ext_storage_telemetry intermittency on win64-ccov. r=mixedpuppy
Luca Greco <lgreco@mozilla.com> - Thu, 23 Aug 2018 17:50:50 +0000 - rev 433027
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1467352 - Fix test_ext_storage_telemetry intermittency on win64-ccov. r=mixedpuppy I've been unable to reproduce this intermittent locally (even by creating a "win64 ccov debug" build on Windows 10), but it has been easy enough to trigger on try. The failure is triggered when the test has been completed and it is unloading the test extension1, by the `NS_ERROR_FILE_ACCESS_DENIED` error raised from Extension's `cleanupGeneratedFile` (https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/toolkit/components/extensions/Extension.jsm#1835-1841). By comparing the test behavior when it runs successfully locally and fails on try, I've been finally able to identify what goes wrong when it fails: The reason for the `NS_ERROR_FILE_ACCESS_DENIED` is the ScriptCache entry for the test extension1's content script, which is created when we create and load the test content page which triggers it, this script cache entry should be cleared when the extension shutdown (and it is cleared when the test runs successfully) Then, right after the content script is executed, the contentPage is closed and this is where something goes (intermittently) wrong with the ipc (and the following pipe errors may be related to it: https://treeherder.mozilla.org/logviewer.html#?job_id=194750915&repo=mozilla-central&lineNumber=2692-2702) and, because of that, during the extension shutdown the "Extension:Shutdown" message broadcasted to all the process never reaches the process where the content script cache entry has been created (as well as "Extension:FlushJarCache" message sent to ensure that the jar cache is flushed in every process), and so the XPI file is still kept active by that process and so it fails to be removed on windows (where the usual `NS_ERROR_FILE_ACCESS_DENIED` is raised in this kind of scenarios). The underlying issue doesn't seem to be strictly related to the behavior that this test file is verifying (that is "checking that the expected telemetry data is being collected when the storage APIs are being used"), and so I think that it would be reasonable to prevent the intermittent by fixing the test (and closing the page after we unload the test extension 1 is enough to ensure that the script cache entry is always cleared as expected and the file can be removed successfully when the test is exiting). The following push to try seems to confirm it (the oranges are triggered by another unrelated test which fails intermittently in win64 ccov builds): - https://treeherder.mozilla.org/#/jobs?repo=try&revision=978e21c57ef084c4115703bf827306320e81bcad Differential Revision: https://phabricator.services.mozilla.com/D4067
a56e76cb2c022213a7bbaa74d32521c2a540600f: Bug 1480494 - Update tup toolchain to e948a999a38fefa0ac0d92f6357f82aca2f9cb17; r=chmanchester
Mike Shal <mshal@mozilla.com> - Thu, 23 Aug 2018 16:58:29 +0000 - rev 433026
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1480494 - Update tup toolchain to e948a999a38fefa0ac0d92f6357f82aca2f9cb17; r=chmanchester This includes a fix for the style build script hang where pthreads fork subprocesses, as well as a fix for ignoring the icecream file lock. MozReview-Commit-ID: 29eNcbNtwB1 Differential Revision: https://phabricator.services.mozilla.com/D4139
68ddeae44caaea1f9441fc19843109be5b4a332e: Bug 1477492 - Add 'CreateCDMProxy' to list of allowed leaks for encrypted-media wpt. r=jgraham
Bryce Van Dyk <bvandyk@mozilla.com> - Thu, 23 Aug 2018 14:05:57 +0000 - rev 433025
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1477492 - Add 'CreateCDMProxy' to list of allowed leaks for encrypted-media wpt. r=jgraham CreateCDMProxy in its fully qualified form is already an allowed leak, but per bug 1477492 certain kinds of builds appear to log the unqualified function name in leak sanitizer logs. Since the allowed list works on string matching, this unqualified version is then not matched and tests are marked as failures. As the source of this different behaviour is not clear, this patch makes the unqualified function name also allowed. Differential Revision: https://phabricator.services.mozilla.com/D4077
975546ce7e13698d4e9a31aef70e89c8b2ded1e1: Bug 1485430 - Simplify PlaceBelowCurrentFloats. r=dbaron,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Aug 2018 23:29:22 +0000 - rev 433024
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1485430 - Simplify PlaceBelowCurrentFloats. r=dbaron,mats No reason to pass our own member as an argument. Differential Revision: https://phabricator.services.mozilla.com/D4000
83488f147740483a4e59be8a0c4934303032d131: Bug 1485441 - Add diagnostics to GL compositor shader failures and avoid crashing release builds. r=jnicol
Nicolas Silva <nsilva@mozilla.com> - Thu, 23 Aug 2018 14:46:50 +0000 - rev 433023
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1485441 - Add diagnostics to GL compositor shader failures and avoid crashing release builds. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D4079
c847a2f8b428fa60e5d74bb0db824b88e17dff8b: Backed out changeset b168deee0bcf (bug 1392106) for failures on canvas/1304353-text-global-composite-op-1.html on a CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Thu, 23 Aug 2018 18:16:05 +0300 - rev 433022
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Backed out changeset b168deee0bcf (bug 1392106) for failures on canvas/1304353-text-global-composite-op-1.html on a CLOSED TREE
bdd6d0de763d0f190ba71a10493467a41f69dc70: Bug 1473048 - Prevent code coverage builds from running when using try option syntax. r=ahal
Greg Mierzwinski <gmierz1@live.ca> - Wed, 22 Aug 2018 20:45:51 +0000 - rev 433021
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1473048 - Prevent code coverage builds from running when using try option syntax. r=ahal This patch completely disables *ccov, and *jsdcov builds and tests when scheduling them through try option syntax as these build variations use a lot of resources and are rarely needed to be scheduled. The only way to schedule code coverage from now on will be with the |mach try fuzzy| tool. Differential Revision: https://phabricator.services.mozilla.com/D3921
9fcfb36da6fe80f1b1647700eb2e9b55d5db9a07: Bug 1484682 - Ensure the sidebar can overflow; r=Honza.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Thu, 23 Aug 2018 09:46:02 +0000 - rev 433020
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1484682 - Ensure the sidebar can overflow; r=Honza. The sidebar regressed at some point and wasn't showing a scrollbar when it was needed. This patch fixes that by making the sidebar overflow and adds a test to make sure we don't regress. Differential Revision: https://phabricator.services.mozilla.com/D3976
eee49d0f606bb7423f9688d2901d76296f505a72: Backed out 6 changesets (bug 1421501) for bustages on security/nss/lib/freebl/mpi/mp_comba.c on a CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Thu, 23 Aug 2018 17:13:42 +0300 - rev 433019
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Backed out 6 changesets (bug 1421501) for bustages on security/nss/lib/freebl/mpi/mp_comba.c on a CLOSED TREE Backed out changeset cae4910806c7 (bug 1421501) Backed out changeset 600a005d3613 (bug 1421501) Backed out changeset 7381597721d2 (bug 1421501) Backed out changeset 1ee0d35a041f (bug 1421501) Backed out changeset 772dea1abb7f (bug 1421501) Backed out changeset c119767aec7b (bug 1421501)
ce2f6b168f041c540513f4d99542ed3870fb3680: Bug 1480702: Rewrite test to avoid relying on unspecified/erroneous behavior r=asuth
Yaron Tausky <ytausky@mozilla.com> - Thu, 23 Aug 2018 14:04:35 +0000 - rev 433018
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1480702: Rewrite test to avoid relying on unspecified/erroneous behavior r=asuth After analyzing test_request.html it became clear that it relied on two false assumptions: 1. It assumed that a service worker is notified that it's being installed before any client can interact with it. 2. It assumed that a service worker will always be installed upon registration, if it was unregistered before. The first assumption is not backed by the spec; it seems that the opposite behavior is the correct one (https://github.com/w3c/ServiceWorker/issues/1347). The second assumption ignores the possibility of resurrection, where a service worker is re- registered before getting uninstalled. This commit addresses both problems by not relying on the installation phase, instead passing the script URL as a search parameter and loading it at service worker script evaluation time. It then runs the test function in response to a message from the client. Differential Revision: https://phabricator.services.mozilla.com/D3879
cae4910806c7976aed9803f22e730c88f7703390: Bug 1421501 - WebIDL and DOM for PrioEncoder r=edgar,hsivonen
Robert Helmer <rhelmer@mozilla.com> - Wed, 20 Jun 2018 17:21:17 -0700 - rev 433017
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1421501 - WebIDL and DOM for PrioEncoder r=edgar,hsivonen MozReview-Commit-ID: L8htRm3J1mZ
600a005d36137445d8bb3af5f3ff77bd53a9cb81: Bug 1421501 - build integration for vendored msgpack r=glandium
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:36 -0700 - rev 433016
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1421501 - build integration for vendored msgpack r=glandium MozReview-Commit-ID: 4AKDbOU4aWx
7381597721d21d982d58cde35194fb89ab967773: Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r=glandium
Robert Helmer <rhelmer@mozilla.com> - Mon, 06 Aug 2018 15:10:06 -0700 - rev 433015
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1421501 - vendor msgpack from https://github.com/msgpack/msgpack-c r=glandium MozReview-Commit-ID: 9vzQOuszf3p
1ee0d35a041f6e439c2dff26a1e1790745b3a667: Bug 1421501 - build system integration for libprio r=gps
Robert Helmer <rhelmer@mozilla.com> - Thu, 07 Jun 2018 19:14:53 -0700 - rev 433014
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1421501 - build system integration for libprio r=gps MozReview-Commit-ID: FYHgLmEhr03
772dea1abb7f7391bb8df72699db4d66919379e9: Bug 1421501 - export NSS [Init,Shutdown]Context symbols r=fkiefer
Robert Helmer <rhelmer@mozilla.com> - Thu, 09 Aug 2018 08:35:48 -0700 - rev 433013
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1421501 - export NSS [Init,Shutdown]Context symbols r=fkiefer MozReview-Commit-ID: Kmhn1dBSYUD
c119767aec7b7356c79ce2ea2a8baaf5682e438d: Bug 1421501 - add vendored libprio from https://github.com/mozilla/libprio r=fkiefer
Robert Helmer <rhelmer@mozilla.com> - Wed, 20 Jun 2018 17:21:01 -0700 - rev 433012
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1421501 - add vendored libprio from https://github.com/mozilla/libprio r=fkiefer MozReview-Commit-ID: LjbKuuFAMAv
488b580cad59b79fc92053fb18dd01ef2c0da15c: No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=mtabara
ffxbld <ffxbld@mozilla.com> - Thu, 23 Aug 2018 13:31:44 +0000 - rev 433011
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=mtabara Differential Revision: https://phabricator.services.mozilla.com/D4071
f5732e0812ff1cac72c698dd6c0a52a7a8bd445a: Bug 1480920 - Bump versions for Android test runner packages r=jchen
James Willcox <snorp@snorp.net> - Thu, 23 Aug 2018 13:12:20 +0000 - rev 433010
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1480920 - Bump versions for Android test runner packages r=jchen This also removes the trivial tests for geckoview_example that were causing problems. Differential Revision: https://phabricator.services.mozilla.com/D3991
b168deee0bcf1a33737941eb78acc065a1c9c053: Bug 1392106 - random-if more test cases for windows 7 letter rendering failures. r=RyanVM
Joel Maher <jmaher@mozilla.com> - Thu, 23 Aug 2018 12:35:17 +0000 - rev 433009
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Bug 1392106 - random-if more test cases for windows 7 letter rendering failures. r=RyanVM random-if statements for the last 2 days worth of annotated failures Differential Revision: https://phabricator.services.mozilla.com/D4070
f5ca36488461cb4e8a8e869b91df0bb76c9c2ab5: Merge mozilla-central to autoland. a=merge CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Thu, 23 Aug 2018 15:30:45 +0300 - rev 433008
Push 34498 by csabou@mozilla.com at Thu, 23 Aug 2018 21:39:18 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip