04e17064fb366cfecfeee3019f80b477a43b1a9d: Bug 1711837 - Disable stringop-truncation warnings in third party breakpad code. r=gsvelto,firefox-build-system-reviewers,andi,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 19 May 2021 20:37:08 +0000 - rev 580082
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1711837 - Disable stringop-truncation warnings in third party breakpad code. r=gsvelto,firefox-build-system-reviewers,andi,mhentges Differential Revision: https://phabricator.services.mozilla.com/D115463
d15639877f7e0890b248e90043b583b38caec2ea: Bug 1710651: Make distance of oneoff buttons narrow. r=desktop-theme-reviewers,harry
Daisuke Akatsuka <daisuke@birchill.co.jp> - Wed, 19 May 2021 20:31:33 +0000 - rev 580081
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1710651: Make distance of oneoff buttons narrow. r=desktop-theme-reviewers,harry Differential Revision: https://phabricator.services.mozilla.com/D115184
532f607c9ca037bdfc9d671a7447b28b19c05c77: Backed out 14 changesets (bug 1686707, bug 1707876, bug 1678044) for Spidermonkey failure. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Wed, 19 May 2021 23:59:51 +0300 - rev 580080
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Backed out 14 changesets (bug 1686707, bug 1707876, bug 1678044) for Spidermonkey failure. CLOSED TREE Backed out changeset 55869e7f350c (bug 1707876) Backed out changeset bc88cd35a55d (bug 1707876) Backed out changeset f0abe77f6bb9 (bug 1707876) Backed out changeset 85dd729149c9 (bug 1707876) Backed out changeset 79ced8bb0b5f (bug 1707876) Backed out changeset f796d42723fd (bug 1707876) Backed out changeset 9f13338b2838 (bug 1686707) Backed out changeset baffdc510ceb (bug 1686707) Backed out changeset d6c151fa0bba (bug 1686707) Backed out changeset 023e75831c48 (bug 1678044) Backed out changeset 5281b7443a89 (bug 1678044) Backed out changeset 6aeb03df54bb (bug 1678044) Backed out changeset 0eeb2f149770 (bug 1678044) Backed out changeset d5f5359358fd (bug 1678044)
341ae1d83639f6bd5ae3ccc8e36b463cc93fbd36: Bug 1658768 check permission before uninstalling an addon from about:addons r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Wed, 19 May 2021 20:10:46 +0000 - rev 580079
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1658768 check permission before uninstalling an addon from about:addons r=rpl Differential Revision: https://phabricator.services.mozilla.com/D115304
043aa993858012a2757c2f71f74beec08b445266: Backed out changeset a8c663dad696 (bug 1711817) for for Spidermonkey failures in js/src/jit-test/tests/asm.js/testAddressErrors.js. CLOSED TREE
Dorel Luca <dluca@mozilla.com> - Wed, 19 May 2021 23:06:34 +0300 - rev 580078
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Backed out changeset a8c663dad696 (bug 1711817) for for Spidermonkey failures in js/src/jit-test/tests/asm.js/testAddressErrors.js. CLOSED TREE
55869e7f350cf9d731f273ead9dcb902b998a8fc: Bug 1707876 - Remove browsers.base.inherit and remaining useage, r=whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:37 +0000 - rev 580077
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1707876 - Remove browsers.base.inherit and remaining useage, r=whimboo This was designed to allow reusing configuration across browsers, but in practice it's only used once and is adding additional complexity that isn't merited by the amount of use. Differential Revision: https://phabricator.services.mozilla.com/D113670
bc88cd35a55d02b69da7105f5b5d12e43254fa6e: Bug 1707876 - Add a FirefoxWdSpecBrowser type with test-specific browser settings, r=whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:37 +0000 - rev 580076
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1707876 - Add a FirefoxWdSpecBrowser type with test-specific browser settings, r=whimboo This is needed by the FirefoxOutputHandler to process the lsan output with the correct per-directory list of allowed failures Differential Revision: https://phabricator.services.mozilla.com/D113669
f0abe77f6bb9c6bf8b07f71403ccb1c375677ebc: Bug 1707876 - Make the specification of wdspec Browser class explicit, r=whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:36 +0000 - rev 580075
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1707876 - Make the specification of wdspec Browser class explicit, r=whimboo Previously we had a small hack in wptrunner.py to override the browser class with NullBrowser for all the cases where the wdspec test type was being run. Apart from being a bit surprising, this doesn't allow us to use different Browser classes per product, which can be useful where we're associating data with the Browser instance related to configuration rather than just with the mechanics of launching the process. To remove this hack, allow the "browser" key in a __wptrunner__ variable be a dictionary mapping test type to browser class name, with None used as a key for the default class. Differential Revision: https://phabricator.services.mozilla.com/D113668
85dd729149c9991dfe11de4de7e8985c93393548: Bug 1707876 - Allow list newly detected LSAN failures, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:36 +0000 - rev 580074
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1707876 - Allow list newly detected LSAN failures, r=webdriver-reviewers,whimboo Differential Revision: https://phabricator.services.mozilla.com/D113515
79ced8bb0b5fe03654ea7ff7af7c495cdf4b548a: Bug 1707876 - Allow testrunner processes to use a full logger, r=whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:35 +0000 - rev 580073
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1707876 - Allow testrunner processes to use a full logger, r=whimboo Previously we used a special MessageLogger class for logging in TestRunner processes. This was only set up to allow normal logging messages (debug/info/etc.). But for wdspec tests in Firefox we're reading the geckodriver output in the TestRunner thread, so require the corresponding log actions. The simplest way to do this is to create an actual StructuredLogger in the child process and use a handler on that logger to proxy the messages back to the parent, as before. Differential Revision: https://phabricator.services.mozilla.com/D113514
f796d42723fd4c0fc0540e315499f52e9a320a04: Bug 1707876 - Use Firefox output handler for wdspec tests, r=whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:35 +0000 - rev 580072
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1707876 - Use Firefox output handler for wdspec tests, r=whimboo To allow parsing the LSAN output from wdspec tests we need to run the output from geckodriver through the OutputHandler defined for Firefox. To do this we define a generic OutputHandler class which can be used in all situations where there is a requirement to read output from a subprocess. Because most browser implementations are based on the WebDriverServer classes, we associate an output handler class with the WebDriverServer which handles the common case for other browsers and the wdspec case for Firefox. Because for WebDriver tests the WebDriverServer is initalized from the executor process, we need to wire the relevant handler options through to the executor; for most cases this doesn't change anything, but for Firefox this includes all the options related to leak checking which requrie reading the process output. Some complexity comes from the fact that we have a defered initalization flow for Firefox in which we're able to preload Firefox instances before we know which tests they will run. This requires the OutputHandler startup to be multi-phase; initially we create a handler, then we pass it down to the mozprocess.ProcessHandler so it recieves output, then we associate the process pid with the handler, then finally once we know what configuration we're running, we know what processing will be applied, so we stop buffering the output and start emitting it to the logger. We also have a lifecycle method that must be called when the process is terminated; this is where any bulk processsing of the complete output (e.g. LSAN messages) occurs. Differential Revision: https://phabricator.services.mozilla.com/D113513
9f13338b2838d0f298d67473b6b39eede9860930: Bug 1686707 - Support writing prefs to a command-line provided profile, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:35 +0000 - rev 580071
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1686707 - Support writing prefs to a command-line provided profile, r=webdriver-reviewers,whimboo Previously we would just ignore the command-line provided profile, write prefs to a new profile and then use the command line provided one. That doesn't really make sense. Now instead we try to write the prefs to the provided profile and restore it after the test run. Depends on D101771 Differential Revision: https://phabricator.services.mozilla.com/D101772
baffdc510ceb19833ad40e0441ec856ce9514e4f: Bug 1686707 - Make rust mozprofile profile path public, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:34 +0000 - rev 580070
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1686707 - Make rust mozprofile profile path public, r=webdriver-reviewers,whimboo Depends on D101770 Differential Revision: https://phabricator.services.mozilla.com/D101771
d6c151fa0bba2754834b9d2e852a8d229df7d28b: Bug 1686707 - Support reading command line argument values in rust mozrunner, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:34 +0000 - rev 580069
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1686707 - Support reading command line argument values in rust mozrunner, r=webdriver-reviewers,whimboo Add support for reading the values passed to command line arguments in mozrunner. This is a little difficult to do exactly like Firefox as different arguments may be parsed differently. This patch supports the following forms: ["--arg", "foo"] ["--arg=foo"] Depends on D101769 Differential Revision: https://phabricator.services.mozilla.com/D101770
023e75831c48ad93ecfb9252db552158a4aa85e9: Bug 1678044 - Unmaximize window before starting a new session, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:33 +0000 - rev 580068
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1678044 - Unmaximize window before starting a new session, r=webdriver-reviewers,whimboo Otherwise it seems to interfere with the rest of the test. Depends on D101768 Differential Revision: https://phabricator.services.mozilla.com/D101769
5281b7443a899dcd538380b4f7c15c46300f9bdd: Bug 1678044 - Switch to explicit profile cleanup rather than using __del__, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:33 +0000 - rev 580067
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1678044 - Switch to explicit profile cleanup rather than using __del__, r=webdriver-reviewers,whimboo This requires passing the test_environment into the get_executor_kwargs function so that in the firefox wdspec case we can add a cleanup function to the environment when running wdspec tests. That seems reasonable since we were previously using a variety of data in the environment to setup the kwargs anyway Depends on D99698 Differential Revision: https://phabricator.services.mozilla.com/D101768
6aeb03df54bb7478f6b288e8d01584ab4fda283c: Bug 1678044 - Fix disabling location services and new tab for geckodriver, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:32 +0000 - rev 580066
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1678044 - Fix disabling location services and new tab for geckodriver, r=webdriver-reviewers,whimboo Depends on D99697 Differential Revision: https://phabricator.services.mozilla.com/D99698
0eeb2f14977007e8ac8e0a43c976c490db2661af: Bug 1678044 - Use correct profile for wdspec tests, r=webdriver-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:32 +0000 - rev 580065
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1678044 - Use correct profile for wdspec tests, r=webdriver-reviewers,whimboo This ensures that we always pass a profile in the capabilitites. When we're running with a single process it simply unpacks the profile to a temporary folder and passes in that path as a firefox argument. When we're running with multiple processes, that won't work. We could invent a mechanism to get one profile per process, but for simplicity we instead pass in the profile as a base64-encoded string. Depends on D97665 Differential Revision: https://phabricator.services.mozilla.com/D99697
d5f5359358fd630ea92da053211f7ca4c0527c82: Bug 1678044 - Fix setting environment variables for wdspec tests, r=maja_zf,marionette-reviewers,whimboo
James Graham <james@hoppipolla.co.uk> - Wed, 19 May 2021 19:25:32 +0000 - rev 580064
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1678044 - Fix setting environment variables for wdspec tests, r=maja_zf,marionette-reviewers,whimboo The previous patch set the variables too late, after the webdriver server was already started. Pass them down into the server startup code instead Differential Revision: https://phabricator.services.mozilla.com/D97665
b4ae1a34c88523c92952719e1a185c21342e2b4f: Bug 1711924: add the policy id in channel properties when redirecting a request r=rpl
Shane Caraveo <scaraveo@mozilla.com> - Wed, 19 May 2021 19:03:01 +0000 - rev 580063
Push 38477 by nbeleuzu@mozilla.com at Thu, 20 May 2021 04:32:45 +0000
Bug 1711924: add the policy id in channel properties when redirecting a request r=rpl Differential Revision: https://phabricator.services.mozilla.com/D115518
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip