0464faa83b959a5f00f2e6e7951d2818f419c6ac: Bug 1578919 - Add test for handling of "pending" fetch events r=asuth
Perry Jiang <perry@mozilla.com> - Fri, 11 Oct 2019 23:23:20 +0000 - rev 497334
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1578919 - Add test for handling of "pending" fetch events r=asuth This patch factors out some of the initial test case in fetch-waits-for-activate.https.html (which only tests "pending" fetch events for a navigation request) to share with a new test case that tests "pending" fetch events for a subresource request with a request body. Both tests in the file have a high-level structure of: 1) Register a Service Worker and wait until its state is "activating" but don't let its state reach "activated". 2) Fire a fetch event that will be controlled by that Service Worker, which should wait until the Service Worker's state advances to "activated". 3) Wait for the fetch to see that the worker isn't "activated". This step isn't directly observable by content, so the test's method to determine this can have false posities (but should never cause the test to unexpectedly fail). 4) Tell the Service Worker to advance to "activated". 5) Verify the fetch that was dispatched while the Service Worker was "activating" is successfully handled. Differential Revision: https://phabricator.services.mozilla.com/D49031
f62280bf339a179ad3a90348e1f6ff43eb8c6540: Bug 1578919 - Don't allow AutoIPCStream to outlive its IPCStream r=asuth
Perry Jiang <perry@mozilla.com> - Fri, 11 Oct 2019 23:22:31 +0000 - rev 497333
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1578919 - Don't allow AutoIPCStream to outlive its IPCStream r=asuth In ServiceWorkerPrivateImpl::SendFetchEvent, a heap-allocated AutoIPCStream can point to a stack-allocated IPCStream (part of an IPCInternalRequest). If this IPCStream is destroyed before the AutoIPCStream, the AutoIPCStream will have a dangling pointer (and this is the case if SendFetchEvent is called when the Service Worker's state is "activating" rather than "activated"). This patch moves around the logic to handle the AutoIPCStream's lifetime to ensure it its lifetime is within its IPCStream's lifetime. The larger issue might be that AutoIPCStream doesn't have inherent lifetime guarantees (it'll definitely outlive its IPCStream if it points to its embedded one, but it doesn't own any external IPCStreams it might point to). Differential Revision: https://phabricator.services.mozilla.com/D48935
15e4b16324a618ac62e7100995b5d4009c07392f: Bug 1578919 - Cleanup AutoIPCStream r=asuth
Perry Jiang <perry@mozilla.com> - Fri, 11 Oct 2019 23:22:24 +0000 - rev 497332
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1578919 - Cleanup AutoIPCStream r=asuth Differential Revision: https://phabricator.services.mozilla.com/D48934
6f876f24a948c758146f87733a9895722b441c6a: Bug 1583400: Follow-up: Fix cycle collector assertion.
Kris Maglione <maglione.k@gmail.com> - Fri, 11 Oct 2019 23:22:52 +0000 - rev 497331
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1583400: Follow-up: Fix cycle collector assertion. Differential Revision: https://phabricator.services.mozilla.com/D49034
c42855b477b170876a13ae32a60032d06698814c: Bug 1102175 Part 4 - Add BFC bits to a block if its used writing-mode is different from the parent's. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Thu, 10 Oct 2019 04:44:38 +0000 - rev 497330
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1102175 Part 4 - Add BFC bits to a block if its used writing-mode is different from the parent's. r=jfkthame Without this patch, the `CHECK_BLOCK_AND_LINE_DIR` soft assertion in nsFloatManager can be triggered with wm-propagation-body-dynamic-change-002.html added in Part 3. Add the test as a crashtest because web-platform reftest doesn't seem to catch our soft assertions. Add reftests to verify that BFC bits are added to the child block if the parent and child has the same block-direction, but different sideways bit; also, add reftests to ensure that "text-orientation: sideways" doesn't add BFC bits. Differential Revision: https://phabricator.services.mozilla.com/D45912
171c70db54de024df49059cb35bb6be68d5829a7: Bug 1102175 Part 3 - Add reftests for altering <body> dynamically. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Thu, 10 Oct 2019 04:44:40 +0000 - rev 497329
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1102175 Part 3 - Add reftests for altering <body> dynamically. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D45580
20bed215cb68ddabed8d12d1dc65b5ea82b902b5: Bug 1102175 Part 2 - Modify the reference file for 817406-4.html, and update test expectations. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Oct 2019 22:16:46 +0000 - rev 497328
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1102175 Part 2 - Modify the reference file for 817406-4.html, and update test expectations. r=jfkthame In 817406-4.html, `<body style="direction: rtl;">` needs to propagate up to `<html>`, so we should compare its result to 817406-1-ref.html. Differential Revision: https://phabricator.services.mozilla.com/D45482
c6daecd1e4f5b14d2a6a353aa9d21f3d14724229: Bug 1102175 Part 1 - Propagate used writing-mode from body element to its ancestors. r=jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Thu, 10 Oct 2019 04:44:44 +0000 - rev 497327
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1102175 Part 1 - Propagate used writing-mode from body element to its ancestors. r=jfkthame Differential Revision: https://phabricator.services.mozilla.com/D45481
d7e83d739e267950277d621e71b1736c390a8569: Bug 1587439 - Ignore messages about missing profile in old XULStore.jsm. r=sfoster
Jared Wein <jwein@mozilla.com> - Fri, 11 Oct 2019 20:15:41 +0000 - rev 497326
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1587439 - Ignore messages about missing profile in old XULStore.jsm. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D48750
dfbe8f0a9dec8fe20bbeeb767bfa47fa40808c50: Bug 1588224. Blob: Remove unused members and some debugging code.
Jeff Muizelaar <jrmuizel@gmail.com> - Fri, 11 Oct 2019 21:59:59 +0000 - rev 497325
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1588224. Blob: Remove unused members and some debugging code. This also reduces the size of BlobItemData which will give us some free performance on SVGs that have a lot of items by reducing our working set size. Differential Revision: https://phabricator.services.mozilla.com/D49023
686a306609ad01ed4749b40d97a2b5116055ef4e: Bug 1583400: Make IsCurrentInnerWindow Fission-compatible. r=bzbarsky
Kris Maglione <maglione.k@gmail.com> - Fri, 11 Oct 2019 21:53:22 +0000 - rev 497324
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1583400: Make IsCurrentInnerWindow Fission-compatible. r=bzbarsky IsCurrentInnerWindow() should only return true when we are the current inner of our BrowsingContext, which has a longer lifetime than individual GlobalWindowOuter instances. In particular, if our BrowsingContext has no GlobalWindowOuter hanging off it, that means that currently it's hosting an inner window from some other process and we are not the current inner. If it _does_ have a GlobalWindowOuter hanging off it, it's possible that this is not the same as our mOuterWindow, if the BrowsingContext navigated to a different site and then navigated back to our site. Therefore, we need to check that we are the current inner of whatever the BrowsingContext's current GlobalWindowOuter is, if it has one at all. Differential Revision: https://phabricator.services.mozilla.com/D48595
e2153ccf7c79774e7556bf12191215e6ae420367: Bug 1587198. Wrench: Supported saving images with strides != width*bytes_per_pixel. r=kvark
Jeff Muizelaar <jrmuizel@gmail.com> - Wed, 09 Oct 2019 18:58:08 +0000 - rev 497323
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1587198. Wrench: Supported saving images with strides != width*bytes_per_pixel. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D48602
614162937d31c10958f663393fdc53387401fbde: Bug 1570370 - Part 9: Move UnicodeExtensionsGenerated.cpp into LanguageTagGenerated.cpp. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 19:26:33 +0000 - rev 497322
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 9: Move UnicodeExtensionsGenerated.cpp into LanguageTagGenerated.cpp. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40075
51c5dbb80a13ffa44f320ee0562cc6e770733b0d: Bug 1570370 - Part 8: Add lookup for static strings to StringBuffer. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 19:26:14 +0000 - rev 497321
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 8: Add lookup for static strings to StringBuffer. r=jwalden StringBuffer directly calls `NewInlineString` for short strings, which prevents looking up static strings. Differential Revision: https://phabricator.services.mozilla.com/D40074
e7dbd9ac5b7ddbc9fbad5386f1814fbce72be383: Bug 1570370 - Part 7: Remove no longer used JS code generation parts from make_intl_data. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 19:25:49 +0000 - rev 497320
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 7: Remove no longer used JS code generation parts from make_intl_data. r=jwalden Also removes the "Native"-suffix from function names. Differential Revision: https://phabricator.services.mozilla.com/D40073
7e272f3c9fa48620151dbdd970802be7d3c0271e: Bug 1570370 - Part 6: Switch language tag parser from JS to C++. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 19:25:32 +0000 - rev 497319
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 6: Switch language tag parser from JS to C++. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40072
f22fdbd968ed04fedd47c406db2678fa5ae1205e: Bug 1570370 - Part 5: Rename NativeLocale.cpp to Locale.cpp. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 19:25:12 +0000 - rev 497318
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 5: Rename NativeLocale.cpp to Locale.cpp. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40071
22ff988b77c6218bd6556702bb926898869b7ecb: Bug 1570370 - Part 4: Rename NativeLocaleObject to LocaleObject. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 20:06:32 +0000 - rev 497317
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 4: Rename NativeLocaleObject to LocaleObject. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40070
64993f76caaf72ed630c44da86250d06dda52ccd: Bug 1570370 - Part 3: Switch Intl.Locale from JS to C++ version. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 19:24:45 +0000 - rev 497316
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 3: Switch Intl.Locale from JS to C++ version. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40069
4eca32dbe70f9c1d7803c2cb51a266842b4e77ab: Bug 1570370 - Part 2: Port Intl.Locale to C++. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 11 Oct 2019 19:24:41 +0000 - rev 497315
Push 36682 by ncsoregi@mozilla.com at Sat, 12 Oct 2019 09:52:03 +0000
Bug 1570370 - Part 2: Port Intl.Locale to C++. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D40068
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 tip