0064d8949f0c0cd397696b894a6eeb51107c5315: Bug 1102541 - Add JS::ubi::RootList::addRoot; r=shu
Nick Fitzgerald <fitzgen@gmail.com> - Thu, 11 Dec 2014 13:55:49 -0800 - rev 219578
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1102541 - Add JS::ubi::RootList::addRoot; r=shu
7837628feeca50da78296127ee3a14d8145d569c: Bug 1090636, part 15 - Optimize away the HasOwnProperty call in SetPropertyByDefining, in the common case. No change in behavior, theoretically. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 12 Nov 2014 11:46:38 -0600 - rev 219577
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 15 - Optimize away the HasOwnProperty call in SetPropertyByDefining, in the common case. No change in behavior, theoretically. r=efaust.
6a71021584ff322cac4d5371a23a72ec95ae7839: Bug 1090636, part 14 - Rewrite SetPropertyHelper. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Fri, 07 Nov 2014 13:45:23 -0600 - rev 219576
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 14 - Rewrite SetPropertyHelper. r=efaust. With this patch: * SetPropertyHelper no longer calls lookupProperty hooks, which is nice since there's no such thing in ES6. * As SetPropertyHelper walks the prototype chain, as soon as it reaches a non-native object, it calls that object's set hook, passing the original receiver, and returns. This means Proxy set traps will now be called per spec when triggered via the prototype chain from a native object. It also means that legacy scripted indirect proxies (Proxy.create) will now sometimes have their set trap called when it wouldn't have been called before. This seems to be confined to fuzztests in practice, since it only matters when the proxy is used as the prototype of an ordinary object. But it could cause trouble. The same situation affects other proxies too: BaseProxyHandler::set() and its overrides will all be called in new situations. It's inevitable though; Reflect.set was going to enable all these situations anyway.
38c02eda337d38f013432994bff0f9168f8a5f29: Bug 1090636, part 13 - Reimplement the mHasPrototype part of Proxy::set as a call to BaseProxyHandler::set. r=bholley.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 15 Oct 2014 11:07:41 -0500 - rev 219575
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 13 - Reimplement the mHasPrototype part of Proxy::set as a call to BaseProxyHandler::set. r=bholley.
1fe6d2492dc891e88452d9049916143c46c1fd12: Bug 1090636, part 12 - Move NativeSet. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 13:26:57 -0500 - rev 219574
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 12 - Move NativeSet. No change in behavior. r=efaust.
6e867a56b16774b30b93e39cc1df4341f6878ba7: Bug 1090636, part 11 - Pass pobj (the object that contains the element) to SetDenseOrTypedArrayElement rather than obj. Reflect.set could trigger the bug being fixed here, so we leave a sleeper test for it. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 13:04:48 -0500 - rev 219573
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 11 - Pass pobj (the object that contains the element) to SetDenseOrTypedArrayElement rather than obj. Reflect.set could trigger the bug being fixed here, so we leave a sleeper test for it. r=efaust.
f4e28c83356eefabff06a2a0cec166d069b3cc02: Bug 1090636, part 10 - Refactor SetExistingProperty. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 12:47:58 -0500 - rev 219572
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 10 - Refactor SetExistingProperty. No change in behavior. r=efaust. At this point, SetPropertyHelper has been factored into five parts: SetPropertyByDefining SetNonexistentProperty SetDenseOrTypedArrayElement SetExistingProperty SetPropertyHelper each with a comment on top and a reasonably clear responsibility. The longest is less than 100 lines, including comments.
86a7c8a5513cdad3075ca556827bc9ec26d8aa0d: Bug 1090636, part 9 - Move SetDenseOrTypedArrayElement above SetExistingProperty. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 12:36:10 -0500 - rev 219571
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 9 - Move SetDenseOrTypedArrayElement above SetExistingProperty. No change in behavior. r=efaust.
b4b7f3844babcf19ef8969d887f6d1105d0bad29: Bug 1090636, part 8 - Factor out SetDenseOrTypedArrayElement from SetExistingProperty. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 12:29:28 -0500 - rev 219570
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 8 - Factor out SetDenseOrTypedArrayElement from SetExistingProperty. No change in behavior. r=efaust.
f2e89dd69118c5e9b568d5670293d748c4f31a8c: Bug 1090636, part 7 - Assigning to an array element via a proxy should trigger the "shadowing" code. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 11:06:41 -0500 - rev 219569
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 7 - Assigning to an array element via a proxy should trigger the "shadowing" code. r=efaust.
16ff20b59b8f857e7bb7cb1559b8981442a42f2d: Bug 1090636, part 6 - Change DefineNativeProperty to support redefining array elements. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Mon, 10 Nov 2014 21:11:20 -0600 - rev 219568
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 6 - Change DefineNativeProperty to support redefining array elements. r=efaust. As it stands, this code is relatively obscure, so the fact that it's amazingly busted is of little consequence. But once we implement ES6 assignment, this code will be fairly easy to trigger when assigning to any Proxy whose target is an Array.
9ee531a0dbcbc5b314db8195f2eaea384fd38732: Bug 1090636, part 5 - In SetExistingProperty, correctly handle assigning to array.length. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 01:22:28 -0500 - rev 219567
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 5 - In SetExistingProperty, correctly handle assigning to array.length. r=efaust. This one is a little complicated. There is some code in SetExistingProperty that is supposed to determine whether or not we should shadow a property that wasn't found on the receiver. This code does not work correctly for array.length properties. (array.length is a data property, so of course it should be shadowed -- but it is non-shadowable() because hasSlot() is false.) Having fixed that bug, the call to SetArrayLength is only necessary in the non-shadowing case. (In fact, it would be unnecessary altogether but for Parallel JS.) This in turn makes 'attrs' unnecessary, so delete that. This is a behavior change (a bug fix) in the case of proxies, as the test illustrates.
a9c02f7db4ebbcbb681408bad24d8933e9e4fb72: Bug 1090636, part 4 - Update SetPropertyByDefining to implement ES6 draft rev 28 section 9.1.9 steps 5.c-f. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 17:16:45 -0500 - rev 219566
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 4 - Update SetPropertyByDefining to implement ES6 draft rev 28 section 9.1.9 steps 5.c-f. r=efaust.
44c3c726c7ae2d98387db81bab43d2ddba5a57f0: Bug 1090636, part 3 - Shadow an existing property even if pobj == obj. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Wed, 29 Oct 2014 00:13:12 -0500 - rev 219565
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 3 - Shadow an existing property even if pobj == obj. r=efaust.
2676562ab2b39d1900b91c9a0515213640717f1c: Bug 1090636, part 2 - Move SetExistingProperty above SetPropertyHelper. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 28 Oct 2014 23:50:39 -0500 - rev 219564
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 2 - Move SetExistingProperty above SetPropertyHelper. No change in behavior. r=efaust.
383dece1cbadd8214529804e3fec7b5ce2cfb12c: Bug 1090636, part 1 - Factor out SetExistingProperty from SetPropertyHelper. No change in behavior. r=efaust.
Jason Orendorff <jorendorff@mozilla.com> - Tue, 28 Oct 2014 23:48:47 -0500 - rev 219563
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1090636, part 1 - Factor out SetExistingProperty from SetPropertyHelper. No change in behavior. r=efaust.
6f1696df360b086ad2f123317f5bf821eaa96891: Bug 1101331: Modify directory structure of B2G.app to allow for building of gaia after OSX v2 changes to Firefox. r=rstrong
Stephen Pohl <spohl.mozilla.bugs@gmail.com> - Fri, 12 Dec 2014 14:40:06 -0500 - rev 219562
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1101331: Modify directory structure of B2G.app to allow for building of gaia after OSX v2 changes to Firefox. r=rstrong
6122b7c0dd2eb1e8826240df7be2b8d8421b756a: Bug 1105194 - Bail early if Websocket connection is being disconnected. r=smaug
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 12 Dec 2014 14:37:07 -0500 - rev 219561
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1105194 - Bail early if Websocket connection is being disconnected. r=smaug
9fa6f8d6c5f338f0b3c440008c43621acdce7910: Bug 1109405 - Fix shutdown of MediaEngineWebRTC sources with multiple attached streams. r=jesup
Andreas Pehrson <pehrsons@gmail.com> - Thu, 11 Dec 2014 23:52:00 -0500 - rev 219560
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1109405 - Fix shutdown of MediaEngineWebRTC sources with multiple attached streams. r=jesup
6b0599030a5facd4279a8499dd11d57ffda2d7be: Bug 1047124 - Clean up memory leaks. r=BenWa
Tom Tromey <tom@tromey.com> - Thu, 11 Dec 2014 09:41:00 -0500 - rev 219559
Push 27967 by ryanvm@gmail.com at Mon, 15 Dec 2014 18:52:54 +0000
Bug 1047124 - Clean up memory leaks. r=BenWa
(0) -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 +300000 tip