author Dana Keeler <>
Tue, 22 Sep 2020 23:51:09 +0000
changeset 549727 7927a17052473b338d511c15bc940f862ee9e3e0
parent 510810 81ae47660566a29c5395432886e4fd9a403eac97
permissions -rw-r--r--
Bug 1662636 - osclientcerts: rework legacy key handling to avoid slow APIs r=kjacobs Bug 1658042 attempted to identify keys that could only handle legacy crypto using CryptFindCertificateKeyProvInfo. However, it appears that this API can be incredibly slow and potentially involve network I/O. This patch reworks the legacy crypto handling by using CryptAcquireCertificatePrivateKey with the CRYPT_ACQUIRE_SILENT_FLAG flag to avoid showing UI at inopportune times. Differential Revision:

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at */

#ifndef mozilla_ConditionVariable_h
#define mozilla_ConditionVariable_h

#include <stdint.h>

#include <utility>

#include "mozilla/Attributes.h"
#include "mozilla/PlatformMutex.h"
#include "mozilla/TimeStamp.h"
#ifndef XP_WIN
#  include <pthread.h>

namespace mozilla {

enum class CVStatus { NoTimeout, Timeout };

namespace detail {

class ConditionVariableImpl {
  struct PlatformData;

  MFBT_API ConditionVariableImpl();
  MFBT_API ~ConditionVariableImpl();

  // Wake one thread that is waiting on this condition.
  MFBT_API void notify_one();

  // Wake all threads that are waiting on this condition.
  MFBT_API void notify_all();

  // Atomically release |lock| and sleep the current thread of execution on
  // this condition variable.
  // |lock| will be re-acquired before this function returns.
  // The thread may be woken from sleep from another thread via notify_one()
  // or notify_all(), but may also wake spuriously.  The caller should recheck
  // its predicate after this function returns, typically in a while loop.
  MFBT_API void wait(MutexImpl& lock);

  MFBT_API CVStatus wait_for(MutexImpl& lock,
                             const mozilla::TimeDuration& rel_time);

  ConditionVariableImpl(const ConditionVariableImpl&) = delete;
  ConditionVariableImpl& operator=(const ConditionVariableImpl&) = delete;

  PlatformData* platformData();

#ifndef XP_WIN
  void* platformData_[sizeof(pthread_cond_t) / sizeof(void*)];
  static_assert(sizeof(pthread_cond_t) / sizeof(void*) != 0 &&
                    sizeof(pthread_cond_t) % sizeof(void*) == 0,
                "pthread_cond_t must have pointer alignment");
  void* platformData_[4];

}  // namespace detail

}  // namespace mozilla

#endif  // mozilla_ConditionVariable_h