author Nika Layzell <>
Thu, 06 Aug 2020 14:04:13 +0000
changeset 544125 ee09cb88af177571304759bc05c760e3d82fd1ed
parent 448947 6f3709b3878117466168c40affa7bca0b60cf75b
permissions -rw-r--r--
Bug 1656854 - Part 2: Add a BrowsingContextGroup keepalive to BrowserParent shutdown, r=farre In bug 1652085, I added BrowsingContextGroup keepalives while waiting for replies to the discard message, however that message isn't actually sent to the current owner process. Instead, the BrowsingContext is discarded by the PBrowser being destroyed. This should help ensure we also keep the group alive during normal BrowserParent destruction. Differential Revision:

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at */

#include "ServiceWorkerImpl.h"

#include "ServiceWorkerInfo.h"

namespace mozilla {
namespace dom {

ServiceWorkerImpl::~ServiceWorkerImpl() { MOZ_DIAGNOSTIC_ASSERT(!mOuter); }

void ServiceWorkerImpl::AddServiceWorker(ServiceWorker* aWorker) {
  mOuter = aWorker;

void ServiceWorkerImpl::RemoveServiceWorker(ServiceWorker* aWorker) {
  MOZ_DIAGNOSTIC_ASSERT(mOuter == aWorker);
  mOuter = nullptr;

void ServiceWorkerImpl::GetRegistration(
    ServiceWorkerRegistrationCallback&& aSuccessCB,
    ServiceWorkerFailureCallback&& aFailureCB) {
  // While we could immediate call success with our registration descriptor
  // we instead queue a runnable to do this.  This ensures that
  // GetRegistration() is always async to match how the IPC implementation will
  // work.  It also ensure that if any events are triggered from providing the
  // registration that they are fired from a runnable on the correct global's
  // event target.

  if (!mOuter) {

  nsIGlobalObject* global = mOuter->GetParentObject();
  if (!global) {

  nsCOMPtr<nsIRunnable> r = NS_NewRunnableFunction(
      [reg = mReg, successCB = std::move(aSuccessCB)]() mutable {

  nsresult rv = global->EventTargetFor(TaskCategory::Other)
                    ->Dispatch(r.forget(), NS_DISPATCH_NORMAL);
  if (NS_FAILED(rv)) {

void ServiceWorkerImpl::PostMessage(RefPtr<ServiceWorkerCloneData>&& aData,
                                    const ClientInfo& aClientInfo,
                                    const ClientState& aClientState) {
  mInfo->PostMessage(std::move(aData), aClientInfo, aClientState);

ServiceWorkerImpl::ServiceWorkerImpl(ServiceWorkerInfo* aInfo,
                                     ServiceWorkerRegistrationInfo* aReg)
    : mInfo(aInfo), mReg(aReg), mOuter(nullptr) {

}  // namespace dom
}  // namespace mozilla