build/clang-plugin/NoAutoTypeChecker.cpp
author Nika Layzell <nika@thelayzells.com>
Thu, 06 Aug 2020 14:04:13 +0000
changeset 544125 ee09cb88af177571304759bc05c760e3d82fd1ed
parent 387474 88c9b8587db69f36601f45e6584ac2d1c5e459b5
permissions -rw-r--r--
Bug 1656854 - Part 2: Add a BrowsingContextGroup keepalive to BrowserParent shutdown, r=farre In bug 1652085, I added BrowsingContextGroup keepalives while waiting for replies to the discard message, however that message isn't actually sent to the current owner process. Instead, the BrowsingContext is discarded by the PBrowser being destroyed. This should help ensure we also keep the group alive during normal BrowserParent destruction. Differential Revision: https://phabricator.services.mozilla.com/D85897

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "NoAutoTypeChecker.h"
#include "CustomMatchers.h"

void NoAutoTypeChecker::registerMatchers(MatchFinder *AstMatcher) {
  AstMatcher->addMatcher(varDecl(hasType(autoNonAutoableType())).bind("node"),
                         this);
}

void NoAutoTypeChecker::check(const MatchFinder::MatchResult &Result) {
  const VarDecl *D = Result.Nodes.getNodeAs<VarDecl>("node");

  diag(D->getLocation(), "Cannot use auto to declare a variable of type %0",
       DiagnosticIDs::Error)
      << D->getType();
  diag(D->getLocation(), "Please write out this type explicitly",
       DiagnosticIDs::Note);
}