build/clang-plugin/JSHandleRootedTypedefChecker.cpp
author Jim Blandy <jimb@red-bean.com>
Thu, 30 Mar 2023 16:23:26 +0000
changeset 658645 9754c55103ef774188e1e813a3ef5d4f5487b35c
parent 626550 c4ff74cf2f4d0c13674ec34be2675c727d4919ba
permissions -rw-r--r--
Bug 1825449: Don't warn on mismatched WebGPU error scope push/pop. r=webgpu-reviewers,teoxoy In the graphics process, don't warn on receipt of mismatched DevicePushErrorScope/DevicePopErrorScope messages, since these can be easily caused by ordinary content and do not indicate anything wrong with Firefox. Differential Revision: https://phabricator.services.mozilla.com/D174045

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "JSHandleRootedTypedefChecker.h"
#include "CustomMatchers.h"

void JSHandleRootedTypedefChecker::registerMatchers(MatchFinder *AstMatcher) {
  AstMatcher->addMatcher(
      declaratorDecl(isUsingJSHandleRootedTypedef(), isNotSpiderMonkey())
          .bind("declaratorDecl"),
      this);
}

std::string getReplacement(std::string TypeName) {
  for (auto &pair : JSHandleRootedTypedefMap) {
    if (!TypeName.compare(pair[0])) {
      return pair[1];
    }
  }
  llvm_unreachable("Unexpected type name");
}

void JSHandleRootedTypedefChecker::check(
    const MatchFinder::MatchResult &Result) {
  const char *Error = "The fully qualified types are preferred over the "
                        "shorthand typedefs for JS::Handle/JS::Rooted types "
                        "outside SpiderMonkey.";

  const DeclaratorDecl *Declarator =
      Result.Nodes.getNodeAs<DeclaratorDecl>("declaratorDecl");

  std::string Replacement = getReplacement(Declarator->getType().getAsString());
  diag(Declarator->getBeginLoc(), Error, DiagnosticIDs::Error)
      << FixItHint::CreateReplacement(
             Declarator->getTypeSourceInfo()->getTypeLoc().getSourceRange(),
             Replacement);
}