mfbt/STYLE
author Jan de Mooij <jdemooij@mozilla.com>
Sat, 12 Jan 2019 10:50:04 +0000
changeset 453631 cfa1c48c717048f00eb4811b5719cd716eb1e5b3
parent 331778 89b895c219f2b97fc0ded8877b30c337e697bdaa
permissions -rw-r--r--
Bug 1518753 part 5 - Stop using JSProtoKey for initial shapes. r=tcampbell I added this optimization in bug 1299107 to share more shapes across compartments. Unfortunately this doesn't play well with same-compartment realms (ICs can misbehave) because it relies on compartments being isolated from each other. I think we should remove this optimization: * Fixing the IC issue is impossible without deoptimizing everything. * I added it mainly for chrome globals. The shared-JSM-global work has eliminated the need for this there. * Same-compartment realms win memory back by eliminating CCWs etc. * It's quite a lot of complicated code. Differential Revision: https://phabricator.services.mozilla.com/D16170

MFBT uses standard Mozilla style, with the following exceptions.

- Some of the files use a lower-case letter at the start of function names.
  This is because MFBT used to use a different style, and was later converted
  to standard Mozilla style. These functions have not been changed to use an
  upper-case letter because it would cause a lot of churn in other parts of the
  codebase. However, new files should follow standard Mozilla style and use an
  upper-case letter at the start of function names.

- Imported third-party code (such as decimal/*, double-conversion/source/*, and
  lz4*) remains in its original style.