build/clang-plugin/NoAddRefReleaseOnReturnChecker.cpp
author Kyle Machulis <kyle@nonpolynomial.com>
Fri, 11 Jan 2019 08:09:33 +0000
changeset 453529 85cbb065250d22e6d4e34fa5db536603cb205fbd
parent 444370 538a16d495142178a73e0bdc30f100b43d2fd62b
permissions -rw-r--r--
Bug 1518956 - Make C++ infallible/simplified versions of nsIURI::SchemeIs; r=valentin SchemeIs only throws exceptions on null arguments now. Assert arguments, as they should never be null anyways, and create an infallible C++ version. Differential Revision: https://phabricator.services.mozilla.com/D16143

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

#include "NoAddRefReleaseOnReturnChecker.h"
#include "CustomMatchers.h"

void NoAddRefReleaseOnReturnChecker::registerMatchers(MatchFinder *AstMatcher) {
  // Look for all of the calls to AddRef() or Release()
  AstMatcher->addMatcher(
      memberExpr(isAddRefOrRelease(), hasParent(callExpr())).bind("member"),
      this);
}

void NoAddRefReleaseOnReturnChecker::check(
    const MatchFinder::MatchResult &Result) {
  const MemberExpr *Member = Result.Nodes.getNodeAs<MemberExpr>("member");
  const Expr *Base = IgnoreTrivials(Member->getBase());

  // Check if the call to AddRef() or Release() was made on the result of a call
  // to a MOZ_NO_ADDREF_RELEASE_ON_RETURN function or method.
  if (auto *Call = dyn_cast<CallExpr>(Base)) {
    if (auto *Callee = Call->getDirectCallee()) {
      if (hasCustomAttribute<moz_no_addref_release_on_return>(Callee)) {
        diag(Call->getBeginLoc(),
             "%1 cannot be called on the return value of %0",
             DiagnosticIDs::Error)
            << Callee << dyn_cast<CXXMethodDecl>(Member->getMemberDecl());
      }
    }
  }
}