author Emilio Cobos Álvarez <emilio@crisal.io>
Sun, 19 Aug 2018 18:22:48 +0000
changeset 432327 39f61de4e7bb164f1ad812852b4f46bd18e3d96d
parent 431797 c97a717558569f49b0c14e362225f65267b0fa95
child 432822 b51573db388680bbbc18a7f31c0854065962f5e0
permissions -rw-r--r--
Bug 1484478 - Use a node bit for connectedness. r=smaug While trying to repro bug 1484293 I noticed that this assertion failed: https://searchfox.org/mozilla-central/rev/ef8b3886cb173d5534b954b6fb7eb2d94a9473d0/dom/base/ShadowRoot.cpp#160 (during unlink, while unbinding the kids) We rely on GetComposedDoc returning the right thing during unbind to cleanup some stuff (see bug 1473637 for example), so it should probably be correct all the time, regardless of whether something is unlinked or not. Also this makes GetComposedDoc() much faster, which is nice too, since we call it somewhat often. I removed NodeHasRelevantHoverRules, since it's unused (was used by the old style system). I moved the SetIsConnected(false) call for the shadow root to before unbinding the kids for consistency with what Element does with the uncomposed doc flag, now that the children's connectedness doesn't depend on the shadow root's. Differential Revision: https://phabricator.services.mozilla.com/D3715