author Iain Ireland <>
Fri, 11 Jan 2019 18:05:36 +0000
changeset 453523 025feea5945bffc625e9cca2e23be51ee8670315
parent 410743 6a806cbc25a763f24bf27c1beb5aeef8987282d8
permissions -rw-r--r--
Bug 1480390: Move ForOfIterClose logic inside TryNoteIter r=tcampbell This patch was intended to be a pure refactoring of existing code with no side-effects, moving the logic for handling for-of/for-of-iterclose trynotes inside TryNoteIter to avoid duplicating logic in all users of TryNoteIter. However, it turns out that there was a subtle preexisting bug in TryNoteIter that is fixed by the refactoring. Specifically, the logic to skip from a for-of-iterclose to its enclosing for-of must run before the logic to skip trynotes based on stack depth. Otherwise, the stack depth code may filter out the enclosing for-of (see the attached test case for an example) and we will skip too many try-notes. Differential Revision:

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at

include $(topsrcdir)/config/

# run the binscope tool to make sure the binary and all libraries
# are using all available Windows OS-level security mechanisms
# XXX this should use a better way of checking all our binaries
	$(PYTHON) $(srcdir)/ $(DIST)/bin/$(MOZ_APP_NAME)$(BIN_SUFFIX) $(DIST)/crashreporter-symbols/
	$(PYTHON) $(srcdir)/ $(DIST)/bin/plugin-container.exe $(DIST)/crashreporter-symbols/
	$(PYTHON) $(srcdir)/ $(DIST)/bin/mozglue.dll $(DIST)/crashreporter-symbols/
	$(PYTHON) $(srcdir)/ $(DIST)/bin/xul.dll $(DIST)/crashreporter-symbols/
	$(PYTHON) $(srcdir)/ $(DIST)/bin/nss3.dll $(DIST)/crashreporter-symbols/