build/dumbmake-dependencies
author Iain Ireland <iireland@mozilla.com>
Fri, 11 Jan 2019 18:05:36 +0000
changeset 453523 025feea5945bffc625e9cca2e23be51ee8670315
parent 406977 af5fa4cbcf26422e4bb0693920c13db600b0ae84
permissions -rw-r--r--
Bug 1480390: Move ForOfIterClose logic inside TryNoteIter r=tcampbell This patch was intended to be a pure refactoring of existing code with no side-effects, moving the logic for handling for-of/for-of-iterclose trynotes inside TryNoteIter to avoid duplicating logic in all users of TryNoteIter. However, it turns out that there was a subtle preexisting bug in TryNoteIter that is fixed by the refactoring. Specifically, the logic to skip from a for-of-iterclose to its enclosing for-of must run before the logic to skip trynotes based on stack depth. Otherwise, the stack depth code may filter out the enclosing for-of (see the attached test case for an example) and we will skip too many try-notes. Differential Revision: https://phabricator.services.mozilla.com/D14783

toolkit/library
  dom
    ipc
    security/sandbox
  ipc
  netwerk/build
    netwerk
  storage/build
    storage
  xpcom
    chrome
  extensions
  docshell/build
    docshell
    uriloader
  modules
  widget
  gfx
  toolkit/components/build
    toolkit/components
  security/manager
    security/certverifier
      security/build
  accessible
  dom
  content
  layout
  editor
  parser
  js/src
    mfbt
  js/xpconnect
    js/xpconnect/loader
  view
  caps
  xpfe/appshell
  xpfe/components
  js
  toolkit
  rdf/build
  embedding
  hal
  image/build
    image
  intl/build
    intl
  media
  profile
  services
  startupcache
  devtools/platform
  devtools/server
  devtools/shared
browser/app
  browser/base
  browser/components
  devtools/client
  browser/locales
  browser/modules
  browser/themes
  toolkit
  toolkit/components
  toolkit/components/downloads
  toolkit/content
  toolkit/crashreporter
  toolkit/forgetaboutsite
  toolkit/identity
  toolkit/modules
  toolkit/mozapps/extensions
  toolkit/profile
  toolkit/themes
  toolkit/webapps