.flake8
author Iain Ireland <iireland@mozilla.com>
Fri, 11 Jan 2019 18:05:36 +0000
changeset 453523 025feea5945bffc625e9cca2e23be51ee8670315
parent 447502 a615ca514a068ad4f4340b167358dcdeffbb26f1
child 453570 daf50f25895db073e44d50fecf2e4f6fe873865d
permissions -rw-r--r--
Bug 1480390: Move ForOfIterClose logic inside TryNoteIter r=tcampbell This patch was intended to be a pure refactoring of existing code with no side-effects, moving the logic for handling for-of/for-of-iterclose trynotes inside TryNoteIter to avoid duplicating logic in all users of TryNoteIter. However, it turns out that there was a subtle preexisting bug in TryNoteIter that is fixed by the refactoring. Specifically, the logic to skip from a for-of-iterclose to its enclosing for-of must run before the logic to skip trynotes based on stack depth. Otherwise, the stack depth code may filter out the enclosing for-of (see the attached test case for an example) and we will skip too many try-notes. Differential Revision: https://phabricator.services.mozilla.com/D14783

[flake8]
# See http://pep8.readthedocs.io/en/latest/intro.html#configuration
ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741
max-line-length = 99
exclude =
    browser/extensions/mortar/ppapi/,
    browser/moz.configure,
    build/moz.configure/*.configure,
    build/pymake/,
    dom/canvas/test/webgl-conf/checkout/closure-library/,
    editor/libeditor/tests/browserscope/,
    intl/icu/,
    ipc/chromium/src/third_party/,
    gfx/angle/,
    gfx/harfbuzz,
    glx/skia/,
    js/*.configure,
    memory/moz.configure,
    mobile/android/*.configure,
    node_modules,
    security/nss/,
    testing/mochitest/pywebsocket,
    tools/lint/test/files,
    build/build-infer/build-infer.py,
    tools/infer/test/*.configure,    tools/infer/test/*.configure,