author Iain Ireland <iireland@mozilla.com>
Fri, 11 Jan 2019 18:05:36 +0000
changeset 453523 025feea5945bffc625e9cca2e23be51ee8670315
parent 452172 ad2f233430e80a4c3764e5aacfbb164d169a9cac
child 454711 2307fb1cfa80a5d4cf05c404917344510a982194
child 454757 7d46c1872ba7920465cdf33b52672a374a66e360
permissions -rw-r--r--
Bug 1480390: Move ForOfIterClose logic inside TryNoteIter r=tcampbell This patch was intended to be a pure refactoring of existing code with no side-effects, moving the logic for handling for-of/for-of-iterclose trynotes inside TryNoteIter to avoid duplicating logic in all users of TryNoteIter. However, it turns out that there was a subtle preexisting bug in TryNoteIter that is fixed by the refactoring. Specifically, the logic to skip from a for-of-iterclose to its enclosing for-of must run before the logic to skip trynotes based on stack depth. Otherwise, the stack depth code may filter out the enclosing for-of (see the attached test case for an example) and we will skip too many try-notes. Differential Revision: https://phabricator.services.mozilla.com/D14783

# Bug 1204606 - Reformat of dom/media r=jya
# https://hg.mozilla.org/mozilla-central/rev/0ceae9db9ec0be18daa1a279511ad305723185d4
abd6d77c618998827e5ffc3dab12f1a34d6ed03d # cinnabar
804b8b8883ba2a6795b0fcf65ebcb18306b6416b # gecko-dev

# Bug 1511181 - Reformat everything to the Google coding style r=ehsan
# https://hg.mozilla.org/mozilla-central/rev/6f3709b3878117466168c40affa7bca0b60cf75b
0e0308d10a5fd4a8dcf0601978776342a2abf2df # cinnabar
265e6721798a455604328ed5262f430cfcc37c2f # gecko-dev

# Bug 1516555 - Reformat everything to the Google coding style r=Ehsan
# https://hg.mozilla.org/mozilla-central/rev/d57dde190f67
cf6442a0664caf8eb39eb75b77963f648597cbd8 # cinnabar
cccdda3c2aec019cc138d410fc0e4aa3e307b6ab # gecko-dev

# Bug 1512961 - Reformat recent changes to the Google coding style r=Ehsan
# https://hg.mozilla.org/integration/autoland/rev/8869368a3f30
20061c7bfce850ba0158c7b8a439ac3ecc62a262 # cinnabar
ad75e912fbc1d64ed63c1d0a51d7157566de1887 # gecko-dev

# Bug 1513205 - Also update the tests to match the Google coding style
# https://hg.mozilla.org/integration/autoland/rev/09c71a7cf75a
13452f36fb36ad09d81f6b53eaf7928ee63f05e3 # cinnabar
6f45c666bc7f98c3e3250a7c2cf8dc3fb95d12d7 # gecko-dev

# Bug 1513205 - Ride along, update some code to match the Google coding style
# https://hg.mozilla.org/integration/autoland/rev/039a7c0c18fb
1ce955dcb2e09fd9ce19c1ec6c470f75db486bd2 # cinnabar
7cf43b9bc01d650f87deceb65f336cdac7c0e78f # gecko-dev