91c45b413b00ce79b47c60c781adb48876500e3c: Bumped version to 1.0b10 Beta 10 - I think Feedback is ready to go for Firefox beta 4 and can be code frozen at this point
jonathandicarlo@host-2-71.mv.mozilla.com - Thu, 24 Jun 2010 09:49:29 -0700 - rev 431
Push 360 by jdicarlo@mozilla.com at Thu, 24 Jun 2010 16:50:10 +0000
Bumped version to 1.0b10
ac31c2e20b7542cc0474c10826cea9ad4f761498: Changed name of happy/sad feedback url prefs from extensions.testpilot to extensions.input.
jonathandicarlo@host-2-71.mv.mozilla.com - Thu, 24 Jun 2010 09:44:37 -0700 - rev 430
Push 359 by jdicarlo@mozilla.com at Thu, 24 Jun 2010 16:44:39 +0000
Changed name of happy/sad feedback url prefs from extensions.testpilot to extensions.input.
c5aa8d5cb7c98f5abc2efe867787ec5471fad95a: Moved all imports and other loading code in setup.js to lazy getters so that they won't take time on startup when browser.js imports setup.js; this should help with the startup time regression (bug 561476). All studies window now uses TestPilotSetup.startupComplete to know when to refresh the window, and displays a 'now loading' message if opened before startupComplete. Also now keeping a reference to the startup timer; together these fix bug 574203.
jonathandicarlo@jonathan-dicarlos-macbook-pro.local - Thu, 24 Jun 2010 08:50:52 -0700 - rev 429
Push 358 by jdicarlo@mozilla.com at Thu, 24 Jun 2010 15:51:02 +0000
Moved all imports and other loading code in setup.js to lazy getters so that they won't take time on startup when browser.js imports setup.js; this should help with the startup time regression (bug 561476). All studies window now uses TestPilotSetup.startupComplete to know when to refresh the window, and displays a 'now loading' message if opened before startupComplete. Also now keeping a reference to the startup timer; together these fix bug 574203.
1ec6356329d5258d173e1fe659cedefa12939ea3: Bug 574079 fixed - study status now advances when the notification is shown, rather than when the page is viewed, so you won't see a 'new study' notification for the same study more than once.
jonathandicarlo@jonathan-dicarlos-macbook-pro.local - Wed, 23 Jun 2010 20:58:47 -0700 - rev 428
Push 357 by jdicarlo@mozilla.com at Thu, 24 Jun 2010 03:58:58 +0000
Bug 574079 fixed - study status now advances when the notification is shown, rather than when the page is viewed, so you won't see a 'new study' notification for the same study more than once.
3ac3998451953a5d9576f78e6e452e59efa12521: Bug 574251 - this should fix it so legacy studies are never other than canceled, archived, or missed.
jonathandicarlo@jonathan-dicarlos-macbook-pro.local - Wed, 23 Jun 2010 20:31:27 -0700 - rev 427
Push 356 by jdicarlo@mozilla.com at Thu, 24 Jun 2010 03:31:29 +0000
Bug 574251 - this should fix it so legacy studies are never other than canceled, archived, or missed.
a648e8ec071abdceaea6b407accdb2f8f3c9a50e: Updated feedback urls from input.stage.mozilla.com to input.mozilla.com.
jonathandicarlo@host-2-71.mv.mozilla.com - Wed, 23 Jun 2010 15:24:19 -0700 - rev 426
Push 355 by jdicarlo@mozilla.com at Wed, 23 Jun 2010 22:24:24 +0000
Updated feedback urls from input.stage.mozilla.com to input.mozilla.com.
a38cdad8411740c61163ed3c9a4e0b390609a6af: Per code review suggestion (bug 561476), moved TestPilotSetup.globalStartup() call to a timer after startup so that the main thread can finish starting up first before Test Pilot tries to do its thing. Also moved FUEL to lazy initializer. Should help fix startup time regression.
jonathandicarlo@host-2-71.mv.mozilla.com - Wed, 23 Jun 2010 13:47:28 -0700 - rev 425
Push 354 by jdicarlo@mozilla.com at Wed, 23 Jun 2010 20:47:31 +0000
Per code review suggestion (bug 561476), moved TestPilotSetup.globalStartup() call to a timer after startup so that the main thread can finish starting up first before Test Pilot tries to do its thing. Also moved FUEL to lazy initializer. Should help fix startup time regression.
e3cda3db9856d11e0c11426e204669902beddd6e: Imported Stephen Horlander's patch: Replaced generic notification skin with appropriate skins for each operating system that better match the firefox style on that OS.
jonathandicarlo@host-2-71.mv.mozilla.com - Wed, 23 Jun 2010 10:42:55 -0700 - rev 424
Push 353 by jdicarlo@mozilla.com at Wed, 23 Jun 2010 17:43:02 +0000
Imported Stephen Horlander's patch: Replaced generic notification skin with appropriate skins for each operating system that better match the firefox style on that OS.
3e1d724c64942d05a18a28fc9e4ec914c8fe5ded: Merged Stephen Horlander's 2nd patch to Feedback button from bug 562784
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 18:14:26 -0700 - rev 423
Push 352 by jdicarlo@mozilla.com at Wed, 23 Jun 2010 01:14:27 +0000
Merged Stephen Horlander's 2nd patch to Feedback button from bug 562784
c1221fa44460ae8d626998d8b65e6da652e723dc: Changed extension name to 'Feedback' and changed icon to dinosaur.
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 17:42:42 -0700 - rev 422
Push 351 by jdicarlo@mozilla.com at Wed, 23 Jun 2010 00:42:45 +0000
Changed extension name to 'Feedback' and changed icon to dinosaur.
ff1a6f9b934ce3660fde248f0dd712f81ff4440d: Removed obsolete comment
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 17:17:48 -0700 - rev 421
Push 350 by jdicarlo@mozilla.com at Wed, 23 Jun 2010 00:17:52 +0000
Removed obsolete comment
613ddc2b16b8988f3a53ab9efcd96eed58e27868: Turned feedback button from type=menu-button to type=menu, which fixes the vertical text alignment problem
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 17:17:26 -0700 - rev 420
Push 350 by jdicarlo@mozilla.com at Wed, 23 Jun 2010 00:17:52 +0000
Turned feedback button from type=menu-button to type=menu, which fixes the vertical text alignment problem
c352664c4ffced406e14a4077e1d2a3d8c954005: Added tag Code Review Me for changeset 073e89d27f72
jonathandicarlo@host-2-71.mv.mozilla.com - Thu, 01 Jan 1970 00:00:00 +0000 - rev 419
Push 349 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 22:04:55 +0000
Added tag Code Review Me for changeset 073e89d27f72
073e89d27f72fb6de3a869edda2040e619c43f50: Bumped version to 1.0b9 Code Review Me
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 15:04:41 -0700 - rev 418
Push 349 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 22:04:55 +0000
Bumped version to 1.0b9
6049e684bd11a017b2a696add3aac1daebfa8fbe: Applied Stephen Horlander's patch from bug 562784 to correct styling of feedback button
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 15:04:07 -0700 - rev 417
Push 348 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 22:04:11 +0000
Applied Stephen Horlander's patch from bug 562784 to correct styling of feedback button
9b39634893ddc140c2c1a28aad5750e57ab569c0: Undid last changes
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 14:46:34 -0700 - rev 416
Push 348 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 22:04:11 +0000
Undid last changes
527f326aa18fac4a64fa97b0e76d3ebb871eacb1: Trying to get the style right on the feedback button
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 14:45:34 -0700 - rev 415
Push 348 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 22:04:11 +0000
Trying to get the style right on the feedback button
221063a114a005a5f32c4b3c09a0a37f4a509ff7: Changed 'all your studies' to 'all your user studies'
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 14:45:16 -0700 - rev 414
Push 348 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 22:04:11 +0000
Changed 'all your studies' to 'all your user studies'
c685f3ce055a6adcfed187ec5b7111523f38712a: As per code review suggestion (bug 561476), wrapped TestPilotWindowUtils and TestPilotMenuUtils in immediately-executed anonymous functions to protect the global namespace.
jonathandicarlo@host-2-71.mv.mozilla.com - Tue, 22 Jun 2010 10:55:11 -0700 - rev 413
Push 347 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 17:55:14 +0000
As per code review suggestion (bug 561476), wrapped TestPilotWindowUtils and TestPilotMenuUtils in immediately-executed anonymous functions to protect the global namespace.
50234a3586c746ca1efaeea28c0f427078db9c8e: As per code review suggestion (bug 561476), instead of being hard-coded into a position in the toolbar, the Feedback button is now added to the toolbar customization palette and is dynamically added to the right spot if not present on first run or update.
jonathandicarlo@jonathan-dicarlos-macbook-pro.local - Mon, 21 Jun 2010 23:26:19 -0700 - rev 412
Push 346 by jdicarlo@mozilla.com at Tue, 22 Jun 2010 06:26:21 +0000
As per code review suggestion (bug 561476), instead of being hard-coded into a position in the toolbar, the Feedback button is now added to the toolbar customization palette and is dynamically added to the right spot if not present on first run or update.
(0) -300 -100 -50 -20 +20 +50 +100 tip