Bug 505861 - Clicking a thumbnail should not set user's persona
authorRyan Doherty <rdoherty@mozilla.com>
Thu, 23 Jul 2009 15:30:30 -0700
changeset 1089 fa35e464d44f3b5bc9d070d2905e5327d4d7285c
parent 1088 ffd802cff6cc5a6a8bb9272e17922bb5d4a85346
child 1090 0ebd2c0193aa1ee476d16b6212e7901815ca5e63
push id705
push userrdoherty@mozilla.com
push dateThu, 23 Jul 2009 22:30:33 +0000
bugs505861, 505882
Bug 505861 - Clicking a thumbnail should not set user's persona Bug 505882 - on design detail page, offer preview when mouse over preview_large image
server/personadetail.php
static/js/script.js
--- a/server/personadetail.php
+++ b/server/personadetail.php
@@ -122,13 +122,13 @@
                             } else {
                                 $(".favorite a").addClass("favorited");
                             }
     					}
     				);
 
     			return false;
             });                   
-            
+            $(".detailed-view").previewPersona();
         });
     </script>
 </body>
 </html>
--- a/static/js/script.js
+++ b/static/js/script.js
@@ -152,19 +152,16 @@ function dispatchPersonaEvent(aType, aNo
 
 /**
     Binds click and hover events to the element.
     Click - bubbles up SelectPersona event
     Mouseenter - bubbles up PreviewPersona
     Mouseleave - bubbles up ResetPersona
 **/
 $.fn.previewPersona = function() {
-    jQuery(this).click(function(event) {
-        dispatchPersonaEvent('SelectPersona', event.originalTarget);
-    });
     
     jQuery(this).hover(
         function(event) {
             dispatchPersonaEvent('PreviewPersona', event.originalTarget);
         },
         function(event) {
             dispatchPersonaEvent('ResetPersona', event.originalTarget);
         }