Bug 1488662 Change go to line shortcut to Ctrl+G r=davidwalsh
authorchujun <chujunlu@hotmail.com>
Tue, 04 Jun 2019 01:25:36 +0000
changeset 11600 e76245e16f65d18150a4ce953045b8d421e9edbb
parent 11599 eb117c52159d1e03637c23c4586ff6435a678651
child 11601 d02832bc4c37487cc805bce4cbe3085e3b66eca3
push id145
push userflodolo@mozilla.com
push dateFri, 07 Jun 2019 15:44:13 +0000
reviewersdavidwalsh
bugs1488662
Bug 1488662 Change go to line shortcut to Ctrl+G r=davidwalsh The current “go to line” keyboard shortcut `CmdOrCtrl+;` conflicts with the “step in” shortcut. The "go to line" shortcut is replaced with the shortcut for Chrome debugger and Sublime Text: `Ctrl+G`. Upper or lower cases don’t matter. 1. Current behavior: 1a) With no file open in editor; or with a file open in editor, but not pausing at a breakpoint: `Cmd+;` or `Cmd+Shift+;` opens the “go to line” box. 1b) Pause at a breakpoint: `Cmd+;` runs `step in`, and also opens the “go to line” box; `Cmd+Shift+;` runs `step over`, and also opens the “go to line” box. 2) Code changes: 2a) Create gotoLineModal.key3. 2b) Update localization note. 2b) Update snapshot test. 3) After the code changes, on macOS: 3a) With no file open in editor: `Ctrl+G` opens the “go to line” box. 3b) With a file open, but not pausing at breakpoints: `Ctrl+G`opens the “go to line” box; hitting `Ctrl+G` again or `escape` closes the box. 3c) Pause at a breakpoint: `Cmd+;` or `Cmd+Shift+;` doesn’t open the “go to line” box. `Ctrl+G` opens the “go to line” box. Differential Revision: https://phabricator.services.mozilla.com/D26256 X-Channel-Repo: mozilla-central X-Channel-Converted-Revision: 812f70d7ccae4fcde784ac2183f23bfddd8943ea X-Channel-Repo: releases/mozilla-beta X-Channel-Revision: 794943628c3b0f522df456695520b9083038062d X-Channel-Repo: releases/mozilla-release X-Channel-Revision: df853c362664989e025d1206b59c37c435186a91
devtools/client/debugger.properties
--- a/devtools/client/debugger.properties
+++ b/devtools/client/debugger.properties
@@ -312,16 +312,28 @@ sourceSearch.search.placeholder2=Find in file…
 sourceSearch.search.again.key2=CmdOrCtrl+G
 
 # LOCALIZATION NOTE (sourceSearch.search.againPrev.key2): Key shortcut to highlight
 # the previous occurrence of the last search triggered from a source search
 # Do not localize "CmdOrCtrl+Shift+G", or change the format of the string. These are
 # key identifiers, not messages displayed to the user.
 sourceSearch.search.againPrev.key2=CmdOrCtrl+Shift+G
 
+# LOCALIZATION NOTE (sourceSearch.search.again.key3): Key shortcut to highlight
+# the next occurrence of the last search triggered from a source search
+# Do not localize "Cmd+G", or change the format of the string. These are
+# key identifiers, not messages displayed to the user.
+sourceSearch.search.again.key3=Cmd+G
+
+# LOCALIZATION NOTE (sourceSearch.search.againPrev.key3): Key shortcut to highlight
+# the previous occurrence of the last search triggered from a source search
+# Do not localize "Cmd+Shift+G", or change the format of the string. These are
+# key identifiers, not messages displayed to the user.
+sourceSearch.search.againPrev.key3=Cmd+Shift+G
+
 # LOCALIZATION NOTE (sourceSearch.resultsSummary1): Shows a summary of
 # the number of matches for autocomplete
 sourceSearch.resultsSummary1=%d results
 
 # LOCALIZATION NOTE (noMatchingStringsText): The text to display in the
 # global search results when there are no matching strings after filtering.
 noMatchingStringsText=No matches found
 
@@ -928,16 +940,22 @@ gotoLineModal.placeholder=Go to line…
 gotoLineModal.title=Go to a line number in a file
 
 # LOCALIZATION NOTE(gotoLineModal.key2): The shortcut for opening the
 # go to line modal
 # Do not localize "CmdOrCtrl+;", or change the format of the string. These are
 # key identifiers, not messages displayed to the user.
 gotoLineModal.key2=CmdOrCtrl+;
 
+# LOCALIZATION NOTE(gotoLineModal.key3): The shortcut for opening the
+# go to line modal
+# Do not localize "Ctrl+G", or change the format of the string. These are
+# key identifiers, not messages displayed to the user.
+gotoLineModal.key3=Ctrl+G
+
 # LOCALIZATION NOTE(symbolSearch.search.functionsPlaceholder): The placeholder
 # text displayed when the user searches for functions in a file
 symbolSearch.search.functionsPlaceholder=Search functions…
 symbolSearch.search.functionsPlaceholder.title=Search for a function in a file
 
 # LOCALIZATION NOTE(symbolSearch.search.variablesPlaceholder): The placeholder
 # text displayed when the user searches for variables in a file
 symbolSearch.search.variablesPlaceholder=Search variables…