Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Tue, 11 Jun 2019 13:47:37 +0000
changeset 11633 d101dc4a685d66a6c8e7e138b7fb1f2f54525c46
parent 11632 6de5cca8e048b8badbf0a5c44b6d4f6923cfdbb1
child 11634 ea47ace974960e642951f4ba58f56d97a4a7faa3
push id147
push userflodolo@mozilla.com
push dateWed, 19 Jun 2019 11:26:52 +0000
reviewersHonza
bugs1545888
Bug 1545888 - Use template-styled message with placeholders as warning group labels. r=Honza. This allows to have more meaningful warning group messages, i.e. "Content Blocking" is turned into something like "The resource at '<URL>' was blocked because content blocking is enabled". This is done by parsing the message of the first warning to put in the group, and replacing the URL with a generic placeholder. We take this as an opportunity to decouple content blocked messages and storage access blocked ones, as they have slightly different meanings and consequences. Tests are updated to match the new labels, and a new test is added to make sure that we can have multiple warning group in a single "page navigation" session. Differential Revision: https://phabricator.services.mozilla.com/D34339 X-Channel-Repo: mozilla-central X-Channel-Converted-Revision: d218c415396f9188c5d19ac09c50b6db82730016 X-Channel-Repo: releases/mozilla-beta X-Channel-Revision: 78928eb0791ef5074dab80bfeac2d96490d7267d X-Channel-Repo: releases/mozilla-release X-Channel-Revision: df853c362664989e025d1206b59c37c435186a91