Bug 1566536 - Support password generation in private windows. r=sfoster
authorMatthew Noorenberghe <mozilla@noorenberghe.ca>
Sat, 23 Nov 2019 03:26:03 +0000
changeset 12458 b4d4badcb6c06777d3ee802e098a4ca2c616ae9e
parent 12457 369fab602092b52a05da188d9d478bd776a5a7f2
child 12459 02841700b55194c5bdbaeba3b331ed842ba57bf4
push id200
push userflodolo@mozilla.com
push dateSat, 23 Nov 2019 13:48:56 +0000
reviewerssfoster
bugs1566536
Bug 1566536 - Support password generation in private windows. r=sfoster * Inform users in autocomplete that using a generated password will cause it to be automatically saved. * Don't fill generated passwords from the context menu directly, that menu item (renamed) should simply force the generation UI to appear in autocomplete. Differential Revision: https://phabricator.services.mozilla.com/D54338 X-Channel-Repo: mozilla-central X-Channel-Converted-Revision: 57ff77aaedc0ec0b7161c25258d51554035ff704 X-Channel-Repo: releases/mozilla-beta X-Channel-Revision: a25e8472d4ff130f59792b0ac11a133b0514aca0 X-Channel-Repo: releases/mozilla-release X-Channel-Revision: 0eae18af659f087056bce0f62a325e5e595fff72 X-Channel-Repo: releases/mozilla-esr68 X-Channel-Revision: 78764fc644ded50f7e681596608aa754ed90b0cc
toolkit/chrome/global/textcontext.dtd
toolkit/chrome/passwordmgr/passwordmgr.properties
--- a/toolkit/chrome/global/textcontext.dtd
+++ b/toolkit/chrome/global/textcontext.dtd
@@ -26,14 +26,16 @@
 <!ENTITY spellDictionaries.accesskey "l">
 
 <!ENTITY searchTextBox.clear.label "Clear">
 
 <!ENTITY fillLoginMenu.label          "Fill Login">
 <!ENTITY fillLoginMenu.accesskey      "F">
 <!ENTITY fillGeneratedPassword.label  "Use a Securely Generated Password">
 <!ENTITY fillGeneratedPassword.accesskey "S">
+<!ENTITY useGeneratedPassword.label   "Use a Securely Generated Password…">
+<!ENTITY useGeneratedPassword.accesskey "S">
 <!ENTITY fillPasswordMenu.label       "Fill Password">
 <!ENTITY fillPasswordMenu.accesskey   "F">
 <!ENTITY fillUsernameMenu.label       "Fill Username">
 <!ENTITY fillUsernameMenu.accesskey   "F">
 <!ENTITY noLoginSuggestions.label     "(No Login Suggestions)">
 <!ENTITY viewSavedLogins.label        "View Saved Logins">
--- a/toolkit/chrome/passwordmgr/passwordmgr.properties
+++ b/toolkit/chrome/passwordmgr/passwordmgr.properties
@@ -46,16 +46,19 @@ updatePasswordMsgNoUser = Would you like
 userSelectText2 = Select which login to update:
 removeLoginPrompt=Are you sure you wish to remove this login?
 removeLoginTitle=Remove login
 loginsDescriptionAll2=Logins for the following sites are stored on your computer
 
 # LOCALIZATION NOTE (useASecurelyGeneratedPassword):
 # Shown in the autocomplete popup to allow filling a generated password into a password field.
 useASecurelyGeneratedPassword=Use a Securely Generated Password
+# LOCALIZATION NOTE (generatedPasswordWillBeSaved):
+# %S will contain the brandShorterName. This informs the user that the generated password will be automatically saved.
+generatedPasswordWillBeSaved=%S will save this password for this website.
 # LOCALIZATION NOTE (loginHostAge):
 # This is used to show the context menu login items with their age.
 # 1st string is the username for the login, 2nd is the login's age.
 loginHostAge=%1$S (%2$S)
 # LOCALIZATION NOTE (noUsername):
 # String is used on the context menu when a login doesn't have a username.
 noUsername=No username