Bug 1388377: Rm WelcomePanelRow. r=liuche
authorMichael Comella <michael.l.comella@gmail.com>
Thu, 31 Aug 2017 14:39:40 -0700
changeset 8887 445f4f411225eb41cee153351da771feda5d96d6
parent 8886 0e4bf9ed9097c0ac7e631adc4d06ceeb9f6b93fa
child 8888 b90abb4a0c3878afc01e0b0a84bb1c28ab8c88ef
push id1
push useraxel@mozilla.com
push dateTue, 10 Oct 2017 22:14:06 +0000
reviewersliuche
bugs1388377
Bug 1388377: Rm WelcomePanelRow. r=liuche We show a message: 1) On first run 2) When there are no highlights However, these are actually the same case (there are no highlights) so I wanted to defer to that situation. I felt it was easier to rm the WelcomePanel and rewrite it than it was to try to morph it into an empty state for the highlights. MozReview-Commit-ID: CrRbzA0NoRx X-Channel-Repo: mozilla-central X-Channel-Converted-Revision: c3b570626261a5bd5a8b9aca805935b72e320c55
mobile/android/base/android_strings.dtd
--- a/mobile/android/base/android_strings.dtd
+++ b/mobile/android/base/android_strings.dtd
@@ -851,18 +851,14 @@ Stream list for highlights sourced from 
 <!ENTITY activity_stream_highlight_label_trending "Trending">
 
 <!-- LOCALIZATION NOTE (activity_stream_remove): This label is shown in the Activity Stream context menu,
 and allows hiding a URL/page from highlights or topsites. The page remains in history/bookmarks, but
 is simply hidden from the Activity Stream panel. -->
 <!ENTITY activity_stream_remove "Remove">
 <!ENTITY activity_stream_delete_history "Delete from History">
 
-<!ENTITY activity_stream_welcome_title "Welcome to your Highlights">
-<!ENTITY activity_stream_welcome_content1 "&brandShortName; now creates highlights of things you\'ve discovered on the web so you can find your way back to great articles, videos, bookmarks, and other pages.">
-<!ENTITY activity_stream_welcome_dismiss "Dismiss">
-
 <!ENTITY private_tab_panel_title "Private Browsing + Tracking Protection">
 <!ENTITY private_tab_panel_description "&brandShortName; blocks parts of the pages that may track your browsing activity.">
 <!ENTITY private_tab_panel_description2 "We won\'t remember any history, but downloaded files and new bookmarks will still be saved to your device.">
 <!ENTITY private_tab_learn_more "Want to learn more?">
 
 <!ENTITY fullscreen_warning "Entered full screen">