Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu
authorPetru Lingurar <petru.lingurar@softvision.ro>
Fri, 14 Jun 2019 17:05:33 +0000
changeset 11648 3e18e26e2ee90ffb0f4ae4ce598a2beff2805945
parent 11647 a623217c8b04be1a0f03c23b302100306c624e68
child 11649 16ef221ea0a39e8cc3f10eaf58ea934265dbaff2
push id147
push userflodolo@mozilla.com
push dateWed, 19 Jun 2019 11:26:52 +0000
reviewersVladBaicu
bugs1557635
Bug 1557635 - Update the Sync Onboarding screen; r=VladBaicu With this changes we must now support 3 Onboarding versions. With this changes we must now support 3 Onboarding versions. Latest Onboarding UX will use a new title for the "Sync screen", new subtext, new image and new text for the signin button. This will be presented only if all this new Strings are localized. Refactored the existing OnboardingStringUtil to serve as a central point of getting the right resources to be used and querying the Onboarding UX version the app should offer. Added to SyncPanel the missing logic to hide the space otherwise occupied by the Onboarding screen message, when there is no message. (now behaving the same as the other Onboarding screens.) Applied a lossless compression for the new sync image which resulted in a 26.5% size reduction. Removed the lint suppression initially necessary for when first added the updated Sync Strings which were not used at the moment. Differential Revision: https://phabricator.services.mozilla.com/D35012 X-Channel-Repo: mozilla-central X-Channel-Converted-Revision: 0fc4b64bb62b83af780606f14b50299ff5434626 X-Channel-Repo: releases/mozilla-beta X-Channel-Revision: 22cfa63e856377c0b7f502d194d4b17dc0c3acc9 X-Channel-Repo: releases/mozilla-release X-Channel-Revision: df853c362664989e025d1206b59c37c435186a91
mobile/android/base/android_strings.dtd
--- a/mobile/android/base/android_strings.dtd
+++ b/mobile/android/base/android_strings.dtd
@@ -16,16 +16,17 @@
 <!ENTITY firstrun_customize_subtext "Customize &brandShortName; with add-ons. Block ads, add features, or choose a new theme to reflect your personality.">
 <!ENTITY firstrun_bookmarks_title "History">
 <!ENTITY firstrun_bookmarks_message "Your faves, front and center">
 <!ENTITY firstrun_bookmarks_subtext "Get results from your bookmarks and history when you search.">
 <!ENTITY firstrun_data_title "Data">
 <!ENTITY firstrun_data_message "Less data, more savings">
 <!ENTITY firstrun_data_subtext2 "Turn off images to spend less data on every site you visit.">
 <!ENTITY firstrun_sync_title "Sync">
+<!ENTITY updatednewfirstrun_sync_title "Account">
 <!ENTITY firstrun_sync_message2 "Pick up where you left off.">
 <!ENTITY firstrun_sync_subtext2 "Use Sync to find the bookmarks, passwords, and other things you save to &brandShortName; on all your devices.">
 <!ENTITY newfirstrun_sync_subtext "Sync the things you save on mobile to Firefox for desktop, privately and securely.">
 <!ENTITY updatednewfirstrun_sync_subtext "Sign in to your account to get the most out of &brandShortName;">
 <!ENTITY firstrun_signin_message "Get connected, get started">
 <!ENTITY firstrun_signin_button "Sign in to Sync">
 <!ENTITY newfirstrun_signin_button "Turn on Sync">
 <!ENTITY updatednewfirstrun_signin_button "Sign in to &brandShortName;">