Bug 1596049. Calling CheckForProcessCrashExpectation needs to pass contentRootElement otherwise it does nothing. r=mattwoodrow
authorTimothy Nikkel <tnikkel@gmail.com>
Wed, 13 Nov 2019 23:15:39 +0000
changeset 501856 fd2d5ef280f4501b8fe79c66f9011d6a73a10115
parent 501855 c1e1c746483aa371d4be24951562ba1184fec370
child 501857 7a990e278ddca87a74a3caf4cc3b633bfcd74deb
push id114172
push userdluca@mozilla.com
push dateTue, 19 Nov 2019 11:31:10 +0000
treeherdermozilla-inbound@b5c5ba07d3db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1596049
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1596049. Calling CheckForProcessCrashExpectation needs to pass contentRootElement otherwise it does nothing. r=mattwoodrow Depends on D52827 Differential Revision: https://phabricator.services.mozilla.com/D52828
layout/tools/reftest/reftest-content.js
--- a/layout/tools/reftest/reftest-content.js
+++ b/layout/tools/reftest/reftest-content.js
@@ -783,17 +783,17 @@ function WaitForTestEnd(contentRootEleme
               gFailureReason = "timed out while waiting for sync compositor flush"
               windowUtils().syncFlushCompositor();
             }
 
             LogInfo("MakeProgress: Completed");
             state = STATE_COMPLETED;
             gFailureReason = "timed out while taking snapshot (bug in harness?)";
             RemoveListeners();
-            CheckForProcessCrashExpectation();
+            CheckForProcessCrashExpectation(contentRootElement);
             setTimeout(RecordResult, 0, forURL);
             return;
         }
     }
 
     LogInfo("WaitForTestEnd: Adding listeners");
     addEventListener("MozAfterPaint", AfterPaintListener, false);
     // If contentRootElement is null then shouldWaitForReftestWaitRemoval will