Bug 1532993 - Accept extra renders of WaterfallView in old perf panel test;r=julienw
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 12 Apr 2019 07:35:02 +0000
changeset 469247 fc8e9758009c4e4cf9fbcd8750b1e1c0cadc14a4
parent 469246 5e86cf625b5407912d483908286f464c6037ec63
child 469248 4c4e45853808229f832e32f6bcdbd4c92a72b13b
push id112776
push usershindli@mozilla.com
push dateFri, 12 Apr 2019 16:20:17 +0000
treeherdermozilla-inbound@b4501ced5619 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjulienw
bugs1532993
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1532993 - Accept extra renders of WaterfallView in old perf panel test;r=julienw Depends on D26920 See Bug 1532993#c12 for the analysis. The extra rendering is due to a window resize that seems to always happen on ASAN but not on other platforms. Differential Revision: https://phabricator.services.mozilla.com/D27143
devtools/client/performance/test/browser_perf-range-changed-render.js
--- a/devtools/client/performance/test/browser_perf-range-changed-render.js
+++ b/devtools/client/performance/test/browser_perf-range-changed-render.js
@@ -64,17 +64,21 @@ add_task(async function() {
   await rendered;
   ok(true, "Call tree rerenders after its corresponding pane is shown.");
 
   rendered = once(WaterfallView, EVENTS.UI_WATERFALL_RENDERED);
   await DetailsView.selectView("waterfall");
   await rendered;
   ok(true, "Waterfall rerenders after its corresponding pane is shown.");
 
-  is(updatedWaterfall, 3, "WaterfallView rerendered 3 times.");
+  // The WaterfallView is rerendered on window resize. Loading the other graphs can
+  // trigger a window resize and increase the total number of rerenders.
+  // See Bug 1532993#c12.
+  ok((updatedWaterfall === 3) || (updatedWaterfall === 4),
+    "WaterfallView rerendered 3 or 4 times.");
   is(updatedCallTree, 2, "JsCallTreeView rerendered 2 times.");
   is(updatedFlameGraph, 2, "JsFlameGraphView rerendered 2 times.");
 
   WaterfallView.off(EVENTS.UI_WATERFALL_RENDERED, updateWaterfall);
   JsCallTreeView.off(EVENTS.UI_JS_CALL_TREE_RENDERED, updateCallTree);
   JsFlameGraphView.off(EVENTS.UI_JS_FLAMEGRAPH_RENDERED, updateFlameGraph);
 
   await teardownToolboxAndRemoveTab(panel);