author | Kershaw Chang <kechang@mozilla.com> |
Wed, 30 Nov 2016 23:12:00 -0500 | |
changeset 324950 | fc772f9c5fb4ba7d71e171e4d1154557feffc29a |
parent 324949 | c5006c51caf6db6222296f8722f0b30438293f7b |
child 324951 | fb18b507a9124611562fb652ebfc993eb7a30e39 |
push id | 84554 |
push user | ryanvm@gmail.com |
push date | Thu, 01 Dec 2016 14:52:20 +0000 |
treeherder | mozilla-inbound@0c212b76bca6 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | francois |
bugs | 1141814 |
milestone | 53.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/modules/libpref/init/all.js +++ b/modules/libpref/init/all.js @@ -1215,16 +1215,18 @@ pref("content.sink.pending_event_mode", pref("privacy.popups.disable_from_plugins", 2); // send "do not track" HTTP header, disabled by default pref("privacy.donottrackheader.enabled", false); // Enforce tracking protection in all modes pref("privacy.trackingprotection.enabled", false); // Enforce tracking protection in Private Browsing mode pref("privacy.trackingprotection.pbmode.enabled", true); +// Annotate channels based on the tracking protection list in all modes +pref("privacy.trackingprotection.annotate_channels", false); pref("dom.event.contextmenu.enabled", true); pref("dom.event.clipboardevents.enabled", true); #if defined(XP_WIN) && !defined(RELEASE_OR_BETA) || defined(MOZ_WIDGET_GTK) && !defined(RELEASE_OR_BETA) pref("dom.event.highrestimestamp.enabled", true); #else pref("dom.event.highrestimestamp.enabled", false); #endif
--- a/toolkit/components/url-classifier/SafeBrowsing.jsm +++ b/toolkit/components/url-classifier/SafeBrowsing.jsm @@ -110,21 +110,22 @@ this.SafeBrowsing = { this.registerTableWithURLs(this.trackingProtectionWhitelists[i]); } for (let i = 0; i < this.blockedLists.length; ++i) { this.registerTableWithURLs(this.blockedLists[i]); } }, - initialized: false, - phishingEnabled: false, - malwareEnabled: false, - trackingEnabled: false, - blockedEnabled: false, + initialized: false, + phishingEnabled: false, + malwareEnabled: false, + trackingEnabled: false, + blockedEnabled: false, + trackingAnnotations: false, phishingLists: [], malwareLists: [], downloadBlockLists: [], downloadAllowLists: [], trackingProtectionLists: [], trackingProtectionWhitelists: [], blockedLists: [], @@ -176,16 +177,17 @@ this.SafeBrowsing = { readPrefs: function() { log("reading prefs"); this.debug = Services.prefs.getBoolPref("browser.safebrowsing.debug"); this.phishingEnabled = Services.prefs.getBoolPref("browser.safebrowsing.phishing.enabled"); this.malwareEnabled = Services.prefs.getBoolPref("browser.safebrowsing.malware.enabled"); this.trackingEnabled = Services.prefs.getBoolPref("privacy.trackingprotection.enabled") || Services.prefs.getBoolPref("privacy.trackingprotection.pbmode.enabled"); this.blockedEnabled = Services.prefs.getBoolPref("browser.safebrowsing.blockedURIs.enabled"); + this.trackingAnnotations = Services.prefs.getBoolPref("privacy.trackingprotection.annotate_channels"); [this.phishingLists, this.malwareLists, this.downloadBlockLists, this.downloadAllowLists, this.trackingProtectionLists, this.trackingProtectionWhitelists, this.blockedLists] = tablePreferences.map(getLists); @@ -261,17 +263,18 @@ this.SafeBrowsing = { log("Update URL given but no lists managed for provider: " + provider); } }, this); }, controlUpdateChecking: function() { log("phishingEnabled:", this.phishingEnabled, "malwareEnabled:", this.malwareEnabled, "trackingEnabled:", this.trackingEnabled, - "blockedEnabled:", this.blockedEnabled); + "blockedEnabled:", this.blockedEnabled, "trackingAnnotations", + this.trackingAnnotations); let listManager = Cc["@mozilla.org/url-classifier/listmanager;1"]. getService(Ci.nsIUrlListManager); for (let i = 0; i < this.phishingLists.length; ++i) { if (this.phishingEnabled) { listManager.enableUpdate(this.phishingLists[i]); } else { @@ -295,24 +298,24 @@ this.SafeBrowsing = { for (let i = 0; i < this.downloadAllowLists.length; ++i) { if (this.malwareEnabled) { listManager.enableUpdate(this.downloadAllowLists[i]); } else { listManager.disableUpdate(this.downloadAllowLists[i]); } } for (let i = 0; i < this.trackingProtectionLists.length; ++i) { - if (this.trackingEnabled) { + if (this.trackingEnabled || this.trackingAnnotations) { listManager.enableUpdate(this.trackingProtectionLists[i]); } else { listManager.disableUpdate(this.trackingProtectionLists[i]); } } for (let i = 0; i < this.trackingProtectionWhitelists.length; ++i) { - if (this.trackingEnabled) { + if (this.trackingEnabled || this.trackingAnnotations) { listManager.enableUpdate(this.trackingProtectionWhitelists[i]); } else { listManager.disableUpdate(this.trackingProtectionWhitelists[i]); } } for (let i = 0; i < this.blockedLists.length; ++i) { if (this.blockedEnabled) { listManager.enableUpdate(this.blockedLists[i]);
--- a/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp +++ b/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp @@ -98,22 +98,16 @@ LazyLogModule gUrlClassifierDbServiceLog // Prefs for implementing nsIURIClassifier to block page loads #define CHECK_MALWARE_PREF "browser.safebrowsing.malware.enabled" #define CHECK_MALWARE_DEFAULT false #define CHECK_PHISHING_PREF "browser.safebrowsing.phishing.enabled" #define CHECK_PHISHING_DEFAULT false -#define CHECK_TRACKING_PREF "privacy.trackingprotection.enabled" -#define CHECK_TRACKING_DEFAULT false - -#define CHECK_TRACKING_PB_PREF "privacy.trackingprotection.pbmode.enabled" -#define CHECK_TRACKING_PB_DEFAULT false - #define CHECK_BLOCKED_PREF "browser.safebrowsing.blockedURIs.enabled" #define CHECK_BLOCKED_DEFAULT false #define GETHASH_NOISE_PREF "urlclassifier.gethashnoise" #define GETHASH_NOISE_DEFAULT 4 // Comma-separated lists #define MALWARE_TABLE_PREF "urlclassifier.malwareTable" @@ -1203,17 +1197,16 @@ nsUrlClassifierDBService::GetInstance(ns } return sUrlClassifierDBService; } nsUrlClassifierDBService::nsUrlClassifierDBService() : mCheckMalware(CHECK_MALWARE_DEFAULT) , mCheckPhishing(CHECK_PHISHING_DEFAULT) - , mCheckTracking(CHECK_TRACKING_DEFAULT) , mCheckBlockedURIs(CHECK_BLOCKED_DEFAULT) , mInUpdate(false) { } nsUrlClassifierDBService::~nsUrlClassifierDBService() { sUrlClassifierDBService = nullptr; @@ -1298,19 +1291,16 @@ nsUrlClassifierDBService::Init() return NS_ERROR_NOT_AVAILABLE; } // Retrieve all the preferences. mCheckMalware = Preferences::GetBool(CHECK_MALWARE_PREF, CHECK_MALWARE_DEFAULT); mCheckPhishing = Preferences::GetBool(CHECK_PHISHING_PREF, CHECK_PHISHING_DEFAULT); - mCheckTracking = - Preferences::GetBool(CHECK_TRACKING_PREF, CHECK_TRACKING_DEFAULT) || - Preferences::GetBool(CHECK_TRACKING_PB_PREF, CHECK_TRACKING_PB_DEFAULT); mCheckBlockedURIs = Preferences::GetBool(CHECK_BLOCKED_PREF, CHECK_BLOCKED_DEFAULT); uint32_t gethashNoise = Preferences::GetUint(GETHASH_NOISE_PREF, GETHASH_NOISE_DEFAULT); gFreshnessGuarantee = Preferences::GetInt(CONFIRM_AGE_PREF, CONFIRM_AGE_DEFAULT_SEC); ReadTablesFromPrefs(); @@ -1374,18 +1364,16 @@ nsUrlClassifierDBService::Init() observerService->AddObserver(this, "profile-before-change", false); // XXX: Do we *really* need to be able to change all of these at runtime? // Note: These observers should only be added when everything else above has // succeeded. Failing to do so can cause long shutdown times in certain // situations. See Bug 1247798 and Bug 1244803. Preferences::AddStrongObserver(this, CHECK_MALWARE_PREF); Preferences::AddStrongObserver(this, CHECK_PHISHING_PREF); - Preferences::AddStrongObserver(this, CHECK_TRACKING_PREF); - Preferences::AddStrongObserver(this, CHECK_TRACKING_PB_PREF); Preferences::AddStrongObserver(this, CHECK_BLOCKED_PREF); Preferences::AddStrongObserver(this, GETHASH_NOISE_PREF); Preferences::AddStrongObserver(this, CONFIRM_AGE_PREF); Preferences::AddStrongObserver(this, PHISH_TABLE_PREF); Preferences::AddStrongObserver(this, MALWARE_TABLE_PREF); Preferences::AddStrongObserver(this, TRACKING_TABLE_PREF); Preferences::AddStrongObserver(this, TRACKING_WHITELIST_TABLE_PREF); Preferences::AddStrongObserver(this, BLOCKED_TABLE_PREF); @@ -1819,21 +1807,16 @@ nsUrlClassifierDBService::Observe(nsISup Unused << prefs; if (NS_LITERAL_STRING(CHECK_MALWARE_PREF).Equals(aData)) { mCheckMalware = Preferences::GetBool(CHECK_MALWARE_PREF, CHECK_MALWARE_DEFAULT); } else if (NS_LITERAL_STRING(CHECK_PHISHING_PREF).Equals(aData)) { mCheckPhishing = Preferences::GetBool(CHECK_PHISHING_PREF, CHECK_PHISHING_DEFAULT); - } else if (NS_LITERAL_STRING(CHECK_TRACKING_PREF).Equals(aData) || - NS_LITERAL_STRING(CHECK_TRACKING_PB_PREF).Equals(aData)) { - mCheckTracking = - Preferences::GetBool(CHECK_TRACKING_PREF, CHECK_TRACKING_DEFAULT) || - Preferences::GetBool(CHECK_TRACKING_PB_PREF, CHECK_TRACKING_PB_DEFAULT); } else if (NS_LITERAL_STRING(CHECK_BLOCKED_PREF).Equals(aData)) { mCheckBlockedURIs = Preferences::GetBool(CHECK_BLOCKED_PREF, CHECK_BLOCKED_DEFAULT); } else if ( NS_LITERAL_STRING(PHISH_TABLE_PREF).Equals(aData) || NS_LITERAL_STRING(MALWARE_TABLE_PREF).Equals(aData) || NS_LITERAL_STRING(TRACKING_TABLE_PREF).Equals(aData) || NS_LITERAL_STRING(TRACKING_WHITELIST_TABLE_PREF).Equals(aData) || @@ -1881,18 +1864,16 @@ nsUrlClassifierDBService::Shutdown() Telemetry::AutoTimer<Telemetry::URLCLASSIFIER_SHUTDOWN_TIME> timer; mCompleters.Clear(); nsCOMPtr<nsIPrefBranch> prefs = do_GetService(NS_PREFSERVICE_CONTRACTID); if (prefs) { prefs->RemoveObserver(CHECK_MALWARE_PREF, this); prefs->RemoveObserver(CHECK_PHISHING_PREF, this); - prefs->RemoveObserver(CHECK_TRACKING_PREF, this); - prefs->RemoveObserver(CHECK_TRACKING_PB_PREF, this); prefs->RemoveObserver(CHECK_BLOCKED_PREF, this); prefs->RemoveObserver(PHISH_TABLE_PREF, this); prefs->RemoveObserver(MALWARE_TABLE_PREF, this); prefs->RemoveObserver(TRACKING_TABLE_PREF, this); prefs->RemoveObserver(TRACKING_WHITELIST_TABLE_PREF, this); prefs->RemoveObserver(BLOCKED_TABLE_PREF, this); prefs->RemoveObserver(DOWNLOAD_BLOCK_TABLE_PREF, this); prefs->RemoveObserver(DOWNLOAD_ALLOW_TABLE_PREF, this);
--- a/toolkit/components/url-classifier/nsUrlClassifierDBService.h +++ b/toolkit/components/url-classifier/nsUrlClassifierDBService.h @@ -115,20 +115,16 @@ private: // TRUE if the nsURIClassifier implementation should check for malware // uris on document loads. bool mCheckMalware; // TRUE if the nsURIClassifier implementation should check for phishing // uris on document loads. bool mCheckPhishing; - // TRUE if the nsURIClassifier implementation should check for tracking - // uris on document loads. - bool mCheckTracking; - // TRUE if the nsURIClassifier implementation should check for blocked // uris on document loads. bool mCheckBlockedURIs; // TRUE if a BeginUpdate() has been called without an accompanying // CancelUpdate()/FinishUpdate(). This is used to prevent competing // updates, not to determine whether an update is still being // processed.