Bug 1336084 - Remove unneeded isForegrounded() call r=sebastian
authorAndrzej Hunt <ahunt@mozilla.com>
Thu, 02 Feb 2017 10:37:58 -0800
changeset 341283 fbfba62842ac259315098d3eb4913b30c79774d6
parent 341282 0ea5c21eb4c5baa1d06a4e12ba92a5e818ee7721
child 341284 051a2419f86ed42ae5966b78b9a6559cef8f43ea
push id86684
push usercbook@mozilla.com
push dateWed, 08 Feb 2017 10:31:03 +0000
treeherdermozilla-inbound@c5b88e4e70f4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssebastian
bugs1336084, 1120441
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1336084 - Remove unneeded isForegrounded() call r=sebastian I accidentally added this while working on a fix for Bug 1120441, and forgot to remove it before landing. This call isn't harmful, but it's unnecessary. MozReview-Commit-ID: FrnhoYWFvKR
mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
--- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
+++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ -662,17 +662,16 @@ public class BrowserApp extends GeckoApp
                             // shut down (in which case trying to perform UI changes, such as showing
                             // fragments below, will crash).
                             return;
                         }
 
                         final TabHistoryFragment fragment = TabHistoryFragment.newInstance(historyPageList, toIndex);
                         final FragmentManager fragmentManager = getSupportFragmentManager();
                         GeckoAppShell.vibrateOnHapticFeedbackEnabled(getResources().getIntArray(R.array.long_press_vibrate_msec));
-                        if (BrowserApp.this.isForegrounded())
                         fragment.show(R.id.tab_history_panel, fragmentManager.beginTransaction(), TAB_HISTORY_FRAGMENT_TAG);
                     }
                 });
             }
         });
         mBrowserToolbar.setTabHistoryController(tabHistoryController);
 
         final String action = intent.getAction();