Bug 1573931 - Disallow INCREMENTAL_ALLOC_TRIGGER GCs when recording/replaying, r=jonco.
authorBrian Hackett <bhackett1024@gmail.com>
Thu, 15 Aug 2019 08:25:35 +0000
changeset 488257 f9bebc85ddb988f5a526269c011ba9d9fb5351b0
parent 488256 a8e1c8f886fb76d41d6c0aa06e3ab8c52ba6962a
child 488258 9a0528095590ff18f2e7fc87d1e1f2d81dd098d3
push id113906
push userncsoregi@mozilla.com
push dateFri, 16 Aug 2019 04:07:24 +0000
treeherdermozilla-inbound@d887276421d3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjonco
bugs1573931
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573931 - Disallow INCREMENTAL_ALLOC_TRIGGER GCs when recording/replaying, r=jonco. Differential Revision: https://phabricator.services.mozilla.com/D42003
js/src/gc/GC.cpp
--- a/js/src/gc/GC.cpp
+++ b/js/src/gc/GC.cpp
@@ -3359,16 +3359,17 @@ static bool RecordReplayCheckCanGC(JS::G
   switch (reason) {
     case JS::GCReason::EAGER_ALLOC_TRIGGER:
     case JS::GCReason::LAST_DITCH:
     case JS::GCReason::TOO_MUCH_MALLOC:
     case JS::GCReason::ALLOC_TRIGGER:
     case JS::GCReason::DELAYED_ATOMS_GC:
     case JS::GCReason::TOO_MUCH_WASM_MEMORY:
     case JS::GCReason::TOO_MUCH_JIT_CODE:
+    case JS::GCReason::INCREMENTAL_ALLOC_TRIGGER:
       return false;
 
     default:
       break;
   }
 
   // If the above filter misses a non-deterministically triggered GC, this
   // assertion will fail.