Bug 837011 - CallCompiler should return 'true' because it doesn't throw an exception (r=dvander)
authorLuke Wagner <luke@mozilla.com>
Thu, 14 Mar 2013 21:28:10 -0700
changeset 124855 f67071c9458486cb32b8101beb08584eb453d05e
parent 124854 16ac88f4d5b65f5c986cdd6d5299cd1691f20024
child 124856 5308a47dd766cf4c1774cf51189de5b915cc0bb4
push id24642
push userlwagner@mozilla.com
push dateFri, 15 Mar 2013 04:29:52 +0000
treeherdermozilla-inbound@f67071c94584 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdvander
bugs837011
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 837011 - CallCompiler should return 'true' because it doesn't throw an exception (r=dvander)
js/src/methodjit/MonoIC.cpp
--- a/js/src/methodjit/MonoIC.cpp
+++ b/js/src/methodjit/MonoIC.cpp
@@ -806,17 +806,17 @@ class CallCompiler : public BaseCompiler
         masm.throwInJIT();
 
         NativeStubLinker linker(masm, f.chunk(), f.regs.pc, done);
         if (!linker.init(f.cx))
             return false;
 
         if (!linker.verifyRange(f.chunk())) {
             disable();
-            return false;
+            return true;
         }
 
         linker.link(noIonCode, ic.icCall());
         linker.patchJump(ic.ionJoinPoint());
         JSC::CodeLocationLabel cs = linker.finalize(f);
 
         ic.updateLastOolJump(linker.locationOf(noIonCode),
                              JITCode(cs.executableAddress(), linker.size()));