Bug 1581912 - Follow up tuning for the extended triplets rollout r=k88hudson
authorNan Jiang <njiang028@gmail.com>
Mon, 30 Sep 2019 18:28:33 +0000
changeset 495718 f45cc699e7a13d15e049feb1cfb36f9d8131df9f
parent 495717 28a5e5744f1f8e3d14237fa3738afd73fd88f630
child 495719 89eacd68ee62952b3db7bca4617c63c489a9c09b
push id114140
push userdvarga@mozilla.com
push dateWed, 02 Oct 2019 18:04:51 +0000
treeherdermozilla-inbound@32eb0ea893f3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersk88hudson
bugs1581912
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1581912 - Follow up tuning for the extended triplets rollout r=k88hudson * Updates the frequency cap for the extended triplets feature * Updates the experiment ID Differential Revision: https://phabricator.services.mozilla.com/D47653
browser/components/newtab/lib/ASRouter.jsm
browser/components/newtab/lib/OnboardingMessageProvider.jsm
browser/components/newtab/test/unit/asrouter/ASRouter.test.js
--- a/browser/components/newtab/lib/ASRouter.jsm
+++ b/browser/components/newtab/lib/ASRouter.jsm
@@ -1072,17 +1072,17 @@ class _ASRouter {
       );
       Services.prefs.setStringPref(
         TRAILHEAD_CONFIG.EXTENDED_TRIPLETS_EXPERIMENT_PREF,
         branch
       );
     }
 
     // In order for ping centre to pick this up, it MUST contain a substring activity-stream
-    const experimentName = `activity-stream-extended-triplets`;
+    const experimentName = `activity-stream-extended-triplets-v2-1581912`;
     TelemetryEnvironment.setExperimentActive(experimentName, branch);
 
     const state = { extendedTripletsInitialized: true };
     // Disable the extended triplets for the "holdback" group.
     if (branch === "holdback") {
       state.showExtendedTriplets = false;
     }
     await this.setState(state);
--- a/browser/components/newtab/lib/OnboardingMessageProvider.jsm
+++ b/browser/components/newtab/lib/OnboardingMessageProvider.jsm
@@ -110,17 +110,17 @@ const ONBOARDING_MESSAGES = () => [
     campaign: "firstrun_triplets",
     targeting:
       "trailheadTriplet && ((currentDate|date - profileAgeCreated) / 86400000) < 7",
     includeBundle: {
       length: 3,
       template: "onboarding",
       trigger: { id: "showOnboarding" },
     },
-    frequency: { lifetime: 20 },
+    frequency: { lifetime: 5 },
     utm_term: "trailhead-cards",
   },
   {
     id: "TRAILHEAD_CARD_1",
     template: "onboarding",
     bundled: 3,
     order: 2,
     content: {
--- a/browser/components/newtab/test/unit/asrouter/ASRouter.test.js
+++ b/browser/components/newtab/test/unit/asrouter/ASRouter.test.js
@@ -3111,17 +3111,17 @@ describe("ASRouter", () => {
         assert.propertyVal(Router.state, "showExtendedTriplets", true);
         assert.calledWith(
           setStringPrefStub,
           TRAILHEAD_CONFIG.EXTENDED_TRIPLETS_EXPERIMENT_PREF,
           "control"
         );
         assert.calledWith(
           setExperimentActiveStub,
-          "activity-stream-extended-triplets",
+          "activity-stream-extended-triplets-v2-1581912",
           "control"
         );
       });
       it("should generates a test branch configuration and update Router.state", async () => {
         sandbox.stub(global.Sampling, "ratioSample").resolves(1); // 1 = holdback branch
 
         await Router.setupExtendedTriplets();
 
@@ -3129,17 +3129,17 @@ describe("ASRouter", () => {
         assert.propertyVal(Router.state, "showExtendedTriplets", false);
         assert.calledWith(
           setStringPrefStub,
           TRAILHEAD_CONFIG.EXTENDED_TRIPLETS_EXPERIMENT_PREF,
           "holdback"
         );
         assert.calledWith(
           setExperimentActiveStub,
-          "activity-stream-extended-triplets",
+          "activity-stream-extended-triplets-v2-1581912",
           "holdback"
         );
       });
       it("should reuse the existing branch if it's already defined", async () => {
         getStringPrefStub.returns("control");
 
         await Router.setupExtendedTriplets();