mozilla-inbound: changeset 241840:f450fec85dd575a60d012afc2e5be65ba8753f19

author	Nathan Froyd <froydnj@mozilla.com>
	Tue, 28 Apr 2015 12:12:36 -0400
changeset 241840	f450fec85dd575a60d012afc2e5be65ba8753f19
parent 241839	84acf9f2f583ed3e7cb6036058137d6c1b96bee8
child 241841	05398ebd8197e62566f54a9164442c2bced7e8e1
push id	59241
push user	nfroyd@mozilla.com
push date	Thu, 30 Apr 2015 19:52:29 +0000
treeherder	mozilla-inbound@f450fec85dd5 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	erahm
bugs	1159306
milestone	40.0a1
first release with	nightly linux32 1e8d30cb367e / 40.0a1 / 20150502030208 / files nightly linux64 1e8d30cb367e / 40.0a1 / 20150502030208 / files nightly mac 1e8d30cb367e / 40.0a1 / 20150502030208 / files nightly win32 1e8d30cb367e / 40.0a1 / 20150502030208 / files nightly win64 1e8d30cb367e / 40.0a1 / 20150502030208 / files
last release without	nightly linux32 7723b15ea695 / 40.0a1 / 20150501030205 / files nightly linux64 7723b15ea695 / 40.0a1 / 20150501030205 / files nightly mac 7723b15ea695 / 40.0a1 / 20150501030205 / files nightly win32 7723b15ea695 / 40.0a1 / 20150501030205 / files nightly win64 7723b15ea695 / 40.0a1 / 20150501030205 / files

Bug 1159306 - explicitly initialize nsBaseHashtableET::mData; r=erahm mData will get automatically constructed when DataType is a class or struct with a default constructor, but a number of uses of nsBaseHashtable use integer or pointer types as DataType. Explicitly initialize mData so that it looks as though we're fully initializing the class in such cases.

xpcom/glue/nsBaseHashtable.h

file | annotate | diff | comparison | revisions

--- a/xpcom/glue/nsBaseHashtable.h
+++ b/xpcom/glue/nsBaseHashtable.h
@@ -354,16 +354,17 @@ ImplCycleCollectionTraverse_EnumFunc(K a
 
 //
 // nsBaseHashtableET definitions
 //
 
 template<class KeyClass, class DataType>
 nsBaseHashtableET<KeyClass, DataType>::nsBaseHashtableET(KeyTypePointer aKey)
   : KeyClass(aKey)
+  , mData()
 {
 }
 
 template<class KeyClass, class DataType>
 nsBaseHashtableET<KeyClass, DataType>::nsBaseHashtableET(
       nsBaseHashtableET<KeyClass, DataType>&& aToMove)
   : KeyClass(mozilla::Move(aToMove))
   , mData(mozilla::Move(aToMove.mData))