Bug 1320761 - assert failure on beta-to-nightly mozconfig comparison; r=gps
authorMike Shal <mshal@mozilla.com>
Mon, 28 Nov 2016 14:54:55 -0500
changeset 324868 f4508c74eafe57b28539780665bb09b3b7ca1d8d
parent 324867 766c351e817226d1f8bbd00565ad4d54955d25b8
child 324869 3a7865514be5be079dca60c4e9c2ce1e05e0fd8c
push id84525
push userphilringnalda@gmail.com
push dateThu, 01 Dec 2016 03:22:09 +0000
treeherdermozilla-inbound@b1d875f4c673 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1320761
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1320761 - assert failure on beta-to-nightly mozconfig comparison; r=gps MozReview-Commit-ID: DPt4namtWAr
build/compare-mozconfig/compare-mozconfigs-wrapper.py
--- a/build/compare-mozconfig/compare-mozconfigs-wrapper.py
+++ b/build/compare-mozconfig/compare-mozconfigs-wrapper.py
@@ -47,22 +47,20 @@ class TestCompareMozconfigs(unittest.Tes
             release_mozconfig_path = path.join(browser_dir, 'config/mozconfigs', platform, 'release')
             nightly_mozconfig_path = path.join(browser_dir, 'config/mozconfigs', platform, 'nightly')
 
             log.info("Comparing beta against nightly mozconfigs")
             ret_code = subprocess.call([python_exe, script_path, '--whitelist',
                                         whitelist_path, '--no-download',
                                         platform + ',' + beta_mozconfig_path +
                                         ',' + nightly_mozconfig_path])
+            self.assertEqual(0, ret_code)
 
-            if ret_code > 0:
-                return ret_code
 
             log.info("Comparing release against nightly mozconfigs")
             ret_code = subprocess.call([python_exe, script_path, '--whitelist',
                                         whitelist_path, '--no-download',
                                         platform + ',' + release_mozconfig_path +
                                         ',' + nightly_mozconfig_path])
-
             self.assertEqual(0, ret_code)
 
 if __name__ == '__main__':
     mozunit.main()