Bug 1224642 - Don't allow arguments to the XPCOMBinaryComponent template. r=gps
authorMike Hommey <mh+mozilla@glandium.org>
Tue, 17 Nov 2015 09:17:01 +0900
changeset 273167 f20f90d8cbbb01061d3f12efbd613170456b7d69
parent 273166 cad6d8407311200d02cdde65f2b05cf4b26b26ba
child 273168 082fd246bfd39fafdc66dcc4e68cf7f97b1aaf6c
push id68191
push usermh@glandium.org
push dateWed, 18 Nov 2015 23:07:16 +0000
treeherdermozilla-inbound@7b54175c1241 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1224642
milestone45.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1224642 - Don't allow arguments to the XPCOMBinaryComponent template. r=gps XPCOM binary components imply dependent linkage, don't work with msvcrt static linkage and have to be built against mozglue, so let's remove all the footguns changing those add.
build/gecko_templates.mozbuild
--- a/build/gecko_templates.mozbuild
+++ b/build/gecko_templates.mozbuild
@@ -155,16 +155,16 @@ def GeckoFramework(name, **kwargs):
     Framework(name)
 
     kwargs.setdefault('mozglue', 'library')
 
     GeckoBinary(**kwargs)
 
 
 @template
-def XPCOMBinaryComponent(name, **kwargs):
+def XPCOMBinaryComponent(name):
     '''Template defining an XPCOM binary component for Gecko.
 
     `name` is the name of the component.
     '''
-    GeckoSharedLibrary(name, **kwargs)
+    GeckoSharedLibrary(name)
 
     IS_COMPONENT = True