Bug 1257346 - Disable C4312 to unblock compilation on VS2015; r=aklotz
☠☠ backed out by 272ec90eff71 ☠ ☠
authorGregory Szorc <gps@mozilla.com>
Wed, 16 Mar 2016 15:27:32 -0700
changeset 289650 f17a9b5483168647a9c50cd2ab0ef1534d9d0715
parent 289649 0c90d5d3f78dfd7d98a4a4c75c70f3d1ae4908c0
child 289651 b8360b8b360f937dcf8147f943c485508e1fb4ee
push id73935
push useraklotz@mozilla.com
push dateMon, 21 Mar 2016 19:21:54 +0000
treeherdermozilla-inbound@f17a9b548316 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaklotz
bugs1257346
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1257346 - Disable C4312 to unblock compilation on VS2015; r=aklotz As part of unblocking building with VS2015u1 in automation, I'm mass disabling compiler warnings that are turned into errors. This is not the preferred mechanism to fix compilation warnings. So hopefully this patch never lands because someone insists on fixing the underlying problem instead. But if it does land, hopefully the workaround is only temporary. MozReview-Commit-ID: BgLmpUa09c6
dom/plugins/ipc/moz.build
--- a/dom/plugins/ipc/moz.build
+++ b/dom/plugins/ipc/moz.build
@@ -147,8 +147,13 @@ else:
     CXXFLAGS += CONFIG['MOZ_GTK2_CFLAGS']
 
 CXXFLAGS += CONFIG['MOZ_CAIRO_CFLAGS']
 
 if CONFIG['_MSC_VER']:
     # This is intended as a temporary hack to support building with VS2015.
     # conversion from 'X' to 'Y' requires a narrowing conversion
     CXXFLAGS += ['-wd4838']
+
+    # 'type cast': conversion from 'unsigned int' to 'HIMC' of greater size
+    SOURCES['PluginInstanceChild.cpp'].flags += ['-wd4312']
+    SOURCES['PluginScriptableObjectChild.cpp'].flags += ['-wd4312']
+