Bug 1419935 - Removed the unused menulist-description binding r=bgrins
authorEthan Grace-Platow <ethan.gp@gmail.com>
Tue, 23 Jan 2018 22:28:53 -0800
changeset 400489 efb319fac7c3
parent 400488 810037ffe4a8
child 400490 640595d09e90
push id99173
push usermozilla@noorenberghe.ca
push dateWed, 24 Jan 2018 07:04:13 +0000
treeherdermozilla-inbound@efb319fac7c3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbgrins
bugs1419935
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1419935 - Removed the unused menulist-description binding r=bgrins
toolkit/content/widgets/menulist.xml
toolkit/content/xul.css
toolkit/themes/linux/global/menulist.css
toolkit/themes/osx/global/menulist.css
toolkit/themes/windows/global/menulist.css
--- a/toolkit/content/widgets/menulist.xml
+++ b/toolkit/content/widgets/menulist.xml
@@ -589,28 +589,15 @@
               this.open = true;
             }
           }
         ]]>
       </handler>
     </handlers>
   </binding>
 
-  <binding id="menulist-description" display="xul:menu"
-           extends="chrome://global/content/bindings/menulist.xml#menulist">
-    <content sizetopopup="pref">
-      <xul:hbox class="menulist-label-box" flex="1">
-        <xul:image class="menulist-icon" xbl:inherits="src=image,src"/>
-        <xul:label class="menulist-label" xbl:inherits="value=label,crop,accesskey" crop="right" flex="1"/>
-        <xul:label class="menulist-label menulist-description" xbl:inherits="value=description" crop="right" flex="10000"/>
-      </xul:hbox>
-      <xul:dropmarker class="menulist-dropmarker" type="menu" xbl:inherits="disabled,open"/>
-      <children includes="menupopup"/>
-    </content>
-  </binding>
-
   <binding id="menulist-popuponly" display="xul:menu"
            extends="chrome://global/content/bindings/menulist.xml#menulist">
     <content sizetopopup="pref">
       <children includes="menupopup"/>
     </content>
   </binding>
 </bindings>
--- a/toolkit/content/xul.css
+++ b/toolkit/content/xul.css
@@ -885,20 +885,16 @@ menulist[popuponly="true"] {
   min-height: 0 !important;
   border: 0 !important;
 }
 
 menulist[editable="true"] {
   -moz-binding: url("chrome://global/content/bindings/menulist.xml#menulist-editable");
 }
 
-menulist[type="description"] {
-  -moz-binding: url("chrome://global/content/bindings/menulist.xml#menulist-description");
-}
-
 menulist > menupopup > menuitem {
   -moz-binding: url("chrome://global/content/bindings/menu.xml#menuitem-iconic-noaccel");
 }
 
 dropmarker {
   -moz-binding: url("chrome://global/content/bindings/general.xml#dropmarker");
 }
 
--- a/toolkit/themes/linux/global/menulist.css
+++ b/toolkit/themes/linux/global/menulist.css
@@ -44,22 +44,16 @@ menulist[open="true"] {
 }
 
 menulist[disabled="true"],
 menulist[disabled="true"]:hover,
 menulist[disabled="true"]:hover:active {
   color: GrayText;
 }
 
-.menulist-description {
-  font-style: italic;
-  color: GrayText;
-  margin-inline-start: 1ex !important;
-}
-
 /* ::::: editable menulists ::::: */
 
 menulist[editable="true"] {
   -moz-appearance: none;
   color: -moz-FieldText;
 }
 
 .menulist-editable-box {
--- a/toolkit/themes/osx/global/menulist.css
+++ b/toolkit/themes/osx/global/menulist.css
@@ -22,22 +22,16 @@ menulist:not([popuponly="true"]) {
   -moz-box-pack: center;
   margin-bottom: 1px;
 }
 
 .menulist-label {
   margin: 1px 3px !important;
 }
 
-.menulist-description {
-  font-style: italic;
-  color: GrayText;
-  margin-inline-start: 1ex !important;
-}
-
 /* ..... dropmarker ..... */
 
 .menulist-dropmarker {
   display: none;
 }
 
 /* ..... disabled state ..... */
 
--- a/toolkit/themes/windows/global/menulist.css
+++ b/toolkit/themes/windows/global/menulist.css
@@ -33,22 +33,16 @@ menulist {
 
 .menulist-label {
   margin-top: 0 !important;
   margin-inline-end: 0 !important;
   margin-bottom: 0 !important;
   margin-inline-start: 1px !important;
 }
 
-.menulist-description {
-  font-style: italic;
-  color: GrayText;
-  margin-inline-start: 1ex !important;
-}
-
 /* ..... focused state ..... */
 
 menulist:focus:not([open="true"]) > .menulist-label-box {
   background-color: Highlight;
   color: HighlightText;
 }
 
 menulist:-moz-focusring:not([open="true"]) > .menulist-label-box {
@@ -86,20 +80,16 @@ html|*.menulist-editable-input {
   }
 
   .menulist-label {
     margin-top: -1px !important;
     margin-bottom: -1px !important;
     margin-inline-start: 0 !important;
   }
 
-  .menulist-description {
-    margin-inline-start: 1ex !important;
-  }
-
   menulist:not([editable="true"]) > .menulist-dropmarker {
     margin-top: -2px;
     margin-inline-start: 3px;
     margin-inline-end: -3px;
   }
 
   .menulist-icon {
     margin-top: -1px;