Bug 1168881 - Enabling AccessibleCarets crashes Firefox when trying to input text, r=tylin
authorMark Capella <markcapella@twcny.rr.com>
Thu, 28 May 2015 02:20:15 -0400
changeset 246024 ef991e9a6395d08bd9064b7bf3b9de2db9b66e67
parent 246023 cab24498e09595dcf086c93b6fd2ad21d189c30f
child 246025 e67ddc64b010aadfcfcd54e63f841bbc7e0b6882
push id60333
push userryanvm@gmail.com
push dateThu, 28 May 2015 14:20:47 +0000
treeherdermozilla-inbound@8225a3b75df6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstylin
bugs1168881
milestone41.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1168881 - Enabling AccessibleCarets crashes Firefox when trying to input text, r=tylin
layout/base/nsPresShell.cpp
--- a/layout/base/nsPresShell.cpp
+++ b/layout/base/nsPresShell.cpp
@@ -2554,17 +2554,18 @@ PresShell::CheckVisibilityContent(nsICon
   *aRetval = false;
   DoCheckVisibility(mPresContext, aNode, aStartOffset, aEndOffset, aRetval);
   return NS_OK;
 }
 
 NS_IMETHODIMP
 PresShell::GetSelectionCaretsVisibility(bool* aOutVisibility)
 {
-  *aOutVisibility = (SelectionCaretPrefEnabled() && mSelectionCarets->GetVisibility());
+  *aOutVisibility = (SelectionCaretPrefEnabled() &&
+    mSelectionCarets && mSelectionCarets->GetVisibility());
   return NS_OK;
 }
 
 NS_IMETHODIMP
 PresShell::SetSelectionCaretsVisibility(bool aVisibility)
 {
   if (SelectionCaretPrefEnabled() && mSelectionCarets) {
     if (aVisibility) {