author | Blake Kaplan <mrbkap@gmail.com> |
Fri, 31 Jan 2014 15:03:09 -0800 | |
changeset 166322 | ee15873640b62066f86de3c3252b64ad7bf9c0b3 |
parent 166321 | 0cbd147b1854a3fa5b0ca743548cec38d00ad6b3 |
child 166323 | 1aa0a5f405fa2d2f2f6f73faadb7f8c9a0ea43ce |
push id | 39178 |
push user | mrbkap@mozilla.com |
push date | Fri, 31 Jan 2014 23:03:55 +0000 |
treeherder | mozilla-inbound@ee15873640b6 [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | bzbarsky |
bugs | 966498 |
milestone | 29.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/dom/base/nsGlobalWindow.cpp +++ b/dom/base/nsGlobalWindow.cpp @@ -6041,29 +6041,27 @@ nsGlobalWindow::AlertOrConfirm(bool aAle do_GetService("@mozilla.org/prompter;1", &rv); if (NS_FAILED(rv)) { aError.Throw(rv); return false; } nsCOMPtr<nsIPrompt> prompt; aError = promptFac->GetPrompt(this, NS_GET_IID(nsIPrompt), - reinterpret_cast<void**>(&prompt)); + getter_AddRefs(prompt)); if (aError.Failed()) { return false; } nsCOMPtr<nsIWritablePropertyBag2> promptBag = do_QueryInterface(prompt); if (promptBag) promptBag->SetPropertyAsBool(NS_LITERAL_STRING("allowTabModal"), allowTabModal); bool result = false; - nsAutoSyncOperation sync(GetCurrentInnerWindowInternal() ? - GetCurrentInnerWindowInternal()->mDoc : - nullptr); + nsAutoSyncOperation sync(mDoc); if (ShouldPromptToBlockDialogs()) { bool disallowDialog = false; nsXPIDLString label; nsContentUtils::GetLocalizedString(nsContentUtils::eCOMMON_DIALOG_PROPERTIES, "ScriptDialogLabel", label); aError = aAlert ? prompt->AlertCheck(title.get(), final.get(), label.get(), @@ -6158,17 +6156,17 @@ nsGlobalWindow::Prompt(const nsAString& do_GetService("@mozilla.org/prompter;1", &rv); if (NS_FAILED(rv)) { aError.Throw(rv); return; } nsCOMPtr<nsIPrompt> prompt; aError = promptFac->GetPrompt(this, NS_GET_IID(nsIPrompt), - reinterpret_cast<void**>(&prompt)); + getter_AddRefs(prompt)); if (aError.Failed()) { return; } nsCOMPtr<nsIWritablePropertyBag2> promptBag = do_QueryInterface(prompt); if (promptBag) promptBag->SetPropertyAsBool(NS_LITERAL_STRING("allowTabModal"), allowTabModal); @@ -6177,19 +6175,17 @@ nsGlobalWindow::Prompt(const nsAString& bool disallowDialog = false; nsXPIDLString label; if (ShouldPromptToBlockDialogs()) { nsContentUtils::GetLocalizedString(nsContentUtils::eCOMMON_DIALOG_PROPERTIES, "ScriptDialogLabel", label); } - nsAutoSyncOperation sync(GetCurrentInnerWindowInternal() ? - GetCurrentInnerWindowInternal()->mDoc : - nullptr); + nsAutoSyncOperation sync(mDoc); bool ok; aError = prompt->Prompt(title.get(), fixedMessage.get(), &inoutValue, label.get(), &disallowDialog, &ok); if (disallowDialog) { DisableDialogs(); }