Bug 1280101 - Do not coerce window dimensions to integer; r=automatedtester
authorAndreas Tolfsen <ato@mozilla.com>
Tue, 14 Jun 2016 18:57:02 +0100
changeset 302151 eca2ce2b6dd2d80969bf0d8e55593db4a37cddc8
parent 302150 fa1be718504b05150a3489bae2ee0035d4f26ecf
child 302152 333518a265a209bec3a25ef6caeb993292439878
push id78621
push useratolfsen@mozilla.com
push dateTue, 21 Jun 2016 08:21:34 +0000
treeherdermozilla-inbound@333518a265a2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersautomatedtester
bugs1280101
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1280101 - Do not coerce window dimensions to integer; r=automatedtester The specification says nothing about coercing to integer. MozReview-Commit-ID: Cq5Wbo2vIAD
testing/marionette/driver.js
--- a/testing/marionette/driver.js
+++ b/testing/marionette/driver.js
@@ -2494,18 +2494,18 @@ GeckoDriver.prototype.getWindowSize = fu
  * An error will be returned if the requested window size would result
  * in the window being in the maximized state.
  */
 GeckoDriver.prototype.setWindowSize = function(cmd, resp) {
   if (this.appName != "Firefox") {
     throw new UnsupportedOperationError();
   }
 
-  let width = parseInt(cmd.parameters.width);
-  let height = parseInt(cmd.parameters.height);
+  let width = cmd.parameters.width;
+  let height = cmd.parameters.height;
 
   let win = this.getCurrentWindow();
   if (width >= win.screen.availWidth || height >= win.screen.availHeight) {
     throw new UnsupportedOperationError("Requested size exceeds screen size")
   }
 
   win.resizeTo(width, height);
 };