Bug 1384145 - Guard the removal of the 'animate' attribute so it only happens in builds with MOZ_PHOTON_ANIMATIONS since the attribute only makes sense when MOZ_PHOTON_ANIMATIONS=True. r=mconley
authorJared Wein <jwein@mozilla.com>
Wed, 26 Jul 2017 08:53:04 -0400
changeset 371180 ec2adb85387e33602d4e7cdf6227c301b91f84e4
parent 371179 fbef58ef000f86a911c9aaf5a0bda4ddfe0b1116
child 371181 35b75b53f9d362a04950c3914cca4d344e7c4e07
push id93039
push userkwierso@gmail.com
push dateThu, 27 Jul 2017 01:33:28 +0000
treeherdermozilla-inbound@35b0bdaacb0d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1384145
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1384145 - Guard the removal of the 'animate' attribute so it only happens in builds with MOZ_PHOTON_ANIMATIONS since the attribute only makes sense when MOZ_PHOTON_ANIMATIONS=True. r=mconley MozReview-Commit-ID: DuUCYGt5uV2
browser/base/content/browser-places.js
--- a/browser/base/content/browser-places.js
+++ b/browser/base/content/browser-places.js
@@ -1801,17 +1801,19 @@ var BookmarkingUI = {
     if (this._itemGuids.size > 0) {
       this.broadcaster.setAttribute("starred", "true");
       this.broadcaster.setAttribute("buttontooltiptext", this._starredTooltip);
       this.broadcaster.setAttribute("tooltiptext", this._starredTooltip);
       if (!AppConstants.MOZ_PHOTON_THEME && this.button.getAttribute("overflowedItem") == "true") {
         this.button.setAttribute("label", this._starButtonOverflowedStarredLabel);
       }
     } else {
-      this.star.removeAttribute("animate");
+      if (AppConstants.MOZ_PHOTON_ANIMATIONS) {
+        this.star.removeAttribute("animate");
+      }
       this.broadcaster.removeAttribute("starred");
       this.broadcaster.setAttribute("buttontooltiptext", this._unstarredTooltip);
       this.broadcaster.setAttribute("tooltiptext", this._unstarredTooltip);
       if (!AppConstants.MOZ_PHOTON_THEME && this.button.getAttribute("overflowedItem") == "true") {
         this.button.setAttribute("label", this._starButtonOverflowedLabel);
       }
     }
   },