Bug 1231445 - Part 1: Support more key types in TableWidget r=mratcliffe
authorJarda Snajdr <jsnajdr@gmail.com>
Mon, 04 Jul 2016 04:09:00 +0200
changeset 303581 ea99abdb125d8a98f63a6ecc77153128fd7f0a54
parent 303580 54799c43ba4311c4ec597b0ed06ef56ba00259ac
child 303582 8f8bfc4fab08c56e355c470a26b704f648782db7
push id79124
push userphilringnalda@gmail.com
push dateMon, 04 Jul 2016 22:08:33 +0000
treeherdermozilla-inbound@4b7053b141ad [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmratcliffe
bugs1231445
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1231445 - Part 1: Support more key types in TableWidget r=mratcliffe
devtools/client/shared/widgets/TableWidget.js
--- a/devtools/client/shared/widgets/TableWidget.js
+++ b/devtools/client/shared/widgets/TableWidget.js
@@ -795,17 +795,17 @@ TableWidget.prototype = {
 
     this.emit(EVENTS.ROW_EDIT, item[this.uniqueId]);
   },
 
   /**
    * Removes the row associated with the `item` object.
    */
   remove: function (item) {
-    if (typeof item == "string") {
+    if (typeof item != "object") {
       item = this.items.get(item);
     }
     if (!item) {
       return;
     }
     let removed = this.items.delete(item[this.uniqueId]);
 
     if (!removed) {