Bug 733636, part 2 - nsXPConnect::WrapNative should pass aAllowWrapping=true. r=bholley
authorAndrew McCreight <continuation@gmail.com>
Wed, 12 Feb 2014 15:19:32 -0800
changeset 168425 e9378c4abc75ac83e11152ceea5ee487ffccaf9f
parent 168424 387b5a9167b0f2d1f43ea6b42722aa79679cb2dd
child 168426 c1fa3a5fa3438cf87dc1ef5b9a1e6426f8034451
push id39708
push useramccreight@mozilla.com
push dateWed, 12 Feb 2014 23:19:49 +0000
treeherdermozilla-inbound@e9378c4abc75 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbholley
bugs733636
milestone30.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 733636, part 2 - nsXPConnect::WrapNative should pass aAllowWrapping=true. r=bholley
js/xpconnect/src/nsXPConnect.cpp
--- a/js/xpconnect/src/nsXPConnect.cpp
+++ b/js/xpconnect/src/nsXPConnect.cpp
@@ -543,17 +543,17 @@ nsXPConnect::WrapNative(JSContext * aJSC
     MOZ_ASSERT(aHolder, "bad param");
     MOZ_ASSERT(aJSContext, "bad param");
     MOZ_ASSERT(aScopeArg, "bad param");
     MOZ_ASSERT(aCOMObj, "bad param");
 
     RootedObject aScope(aJSContext, aScopeArg);
     RootedValue v(aJSContext);
     return NativeInterface2JSObject(aScope, aCOMObj, nullptr, &aIID,
-                                    false, &v, aHolder);
+                                    true, &v, aHolder);
 }
 
 /* void wrapNativeToJSVal (in JSContextPtr aJSContext, in JSObjectPtr aScope, in nsISupports aCOMObj, in nsIIDPtr aIID, out jsval aVal, out nsIXPConnectJSObjectHolder aHolder); */
 NS_IMETHODIMP
 nsXPConnect::WrapNativeToJSVal(JSContext *aJSContext,
                                JSObject *aScopeArg,
                                nsISupports *aCOMObj,
                                nsWrapperCache *aCache,