Bug 1278985 - Remove unused URL arg from CreateChromeWindow2. r=mrbkap
☠☠ backed out by 302da31353a0 ☠ ☠
authorMike Conley <mconley@mozilla.com>
Wed, 27 Apr 2016 16:19:25 -0400
changeset 301134 e8b366f388f6e41f9f4663ab89eab383eea8609e
parent 301133 b598ce1977bc54968e485184a16d410b231f2843
child 301135 1bfdc24b25401e27abd6ae071be69d0ffcb95f2f
push id78230
push usermconley@mozilla.com
push dateWed, 08 Jun 2016 21:31:27 +0000
treeherdermozilla-inbound@e8b366f388f6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1278985 - Remove unused URL arg from CreateChromeWindow2. r=mrbkap This isn't used at all internally, and was probably used by people embedding Gecko back when Gecko was more embeddable. For now, it's just noise - I figure we can remove it. MozReview-Commit-ID: I1H2WZeoHTJ
--- a/embedding/nsIWindowCreator2.idl
+++ b/embedding/nsIWindowCreator2.idl
@@ -35,33 +35,27 @@ interface nsIWindowCreator2 : nsIWindowC
   /** Create a new window. Gecko will/may call this method, if made
       available to it, to create new windows.
       @param parent Parent window, if any. Null if not. The newly created
                     window should be made a child/dependent window of
                     the parent, if any (and if the concept applies
                     to the underlying OS).
       @param chromeFlags Chrome features from nsIWebBrowserChrome
       @param contextFlags Flags about the context of the window being created.
-      @param uri The URL for which this window is intended. It can be null
-                 or zero-length. The implementation of this interface
-                 may use the URL to help determine what sort of window
-                 to open or whether to cancel window creation. It will not
-                 load the URL.
       @param aOpeningTab The TabParent that is trying to open this new chrome
                          window. Can be nullptr.
       @param cancel Return |true| to reject window creation. If true the
                     implementation has determined the window should not
                     be created at all. The caller should not default
                     to any possible backup scheme for creating the window.
       @return the new window. Will be null if canceled or an error occurred.
   nsIWebBrowserChrome createChromeWindow2(in nsIWebBrowserChrome parent,
                                           in uint32_t chromeFlags,
                                           in uint32_t contextFlags,
-                                          in nsIURI uri,
                                           in nsITabParent aOpeningTab,
                                           out boolean cancel);
    * B2G multi-screen support. When open another top-level window on b2g,
    * a screen ID is needed for identifying which screen this window is
    * opened to.
    * @param aScreenId Differentiate screens of windows. It is platform-
--- a/toolkit/components/startup/nsAppStartup.cpp
+++ b/toolkit/components/startup/nsAppStartup.cpp
@@ -609,17 +609,17 @@ nsAppStartup::GetInterrupted(bool *aInte
 nsAppStartup::CreateChromeWindow(nsIWebBrowserChrome *aParent,
                                  uint32_t aChromeFlags,
                                  nsIWebBrowserChrome **_retval)
   bool cancel;
-  return CreateChromeWindow2(aParent, aChromeFlags, 0, 0, nullptr, &cancel, _retval);
+  return CreateChromeWindow2(aParent, aChromeFlags, 0, nullptr, &cancel, _retval);
 // nsAppStartup->nsIWindowCreator2
@@ -632,17 +632,16 @@ nsAppStartup::SetScreenId(uint32_t aScre
   return appShell->SetScreenId(aScreenId);
 nsAppStartup::CreateChromeWindow2(nsIWebBrowserChrome *aParent,
                                   uint32_t aChromeFlags,
                                   uint32_t aContextFlags,
-                                  nsIURI *aURI,
                                   nsITabParent *aOpeningTab,
                                   bool *aCancel,
                                   nsIWebBrowserChrome **_retval)
   *aCancel = false;
   *_retval = 0;