Bug 1541298 - Cycle collect what we can in SpeechRecognition. r=jib
authorAndreas Pehrson <apehrson@mozilla.com>
Fri, 12 Apr 2019 11:35:06 +0000
changeset 469261 e8717a523b34291683440914deda399199dc6247
parent 469260 a34e5dcf0fe8277176fb505348fdf85a1f22e1fb
child 469262 3119da540c3170ee981b575fef593c3bcf8b6eaa
push id112776
push usershindli@mozilla.com
push dateFri, 12 Apr 2019 16:20:17 +0000
treeherdermozilla-inbound@b4501ced5619 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1541298
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1541298 - Cycle collect what we can in SpeechRecognition. r=jib Differential Revision: https://phabricator.services.mozilla.com/D26723
dom/media/webspeech/recognition/SpeechRecognition.cpp
--- a/dom/media/webspeech/recognition/SpeechRecognition.cpp
+++ b/dom/media/webspeech/recognition/SpeechRecognition.cpp
@@ -99,17 +99,18 @@ already_AddRefed<nsISpeechRecognitionSer
 
   nsresult rv;
   nsCOMPtr<nsISpeechRecognitionService> recognitionService;
   recognitionService = do_GetService(speechRecognitionServiceCID.get(), &rv);
   return recognitionService.forget();
 }
 
 NS_IMPL_CYCLE_COLLECTION_INHERITED(SpeechRecognition, DOMEventTargetHelper,
-                                   mTrack, mSpeechGrammarList)
+                                   mStream, mTrack, mRecognitionService,
+                                   mSpeechGrammarList)
 
 NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(SpeechRecognition)
   NS_INTERFACE_MAP_ENTRY(nsIObserver)
 NS_INTERFACE_MAP_END_INHERITING(DOMEventTargetHelper)
 
 NS_IMPL_ADDREF_INHERITED(SpeechRecognition, DOMEventTargetHelper)
 NS_IMPL_RELEASE_INHERITED(SpeechRecognition, DOMEventTargetHelper)