bug 967218 - interpret result of NativeApp:IsDebuggable as string; r=mfinkle
authorMyk Melez <myk@mozilla.org>
Thu, 06 Feb 2014 10:48:27 -0800
changeset 167267 e7b7825f65dd537f0843d165660e95459020ea21
parent 167266 197880d71d9dbc4ad4e7d02bac7c452bc42e7672
child 167268 9bb6f487c55faf5e24f8823e9d88e753531233f7
push id39423
push usermyk@mozilla.com
push dateThu, 06 Feb 2014 18:49:17 +0000
treeherdermozilla-inbound@e7b7825f65dd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmfinkle
bugs967218
milestone30.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 967218 - interpret result of NativeApp:IsDebuggable as string; r=mfinkle
mobile/android/chrome/content/WebAppRT.js
--- a/mobile/android/chrome/content/WebAppRT.js
+++ b/mobile/android/chrome/content/WebAppRT.js
@@ -62,17 +62,19 @@ let WebAppRT = {
         if (aManifest) {
           PermissionsInstaller.installPermissions(aApp, true);
         }
       });
     }
 
 #ifdef MOZ_ANDROID_SYNTHAPKS
     // If the app is in debug mode, configure and enable the remote debugger.
-    if (sendMessageToJava({ type: "NativeApp:IsDebuggable" })) {
+    // sendMessageToJava can only return string values, so it returns the string
+    // "true" rather than boolean true if the app is in debug mode.
+    if (sendMessageToJava({ type: "NativeApp:IsDebuggable" }) === "true") {
       this._enableRemoteDebugger(aUrl);
     }
 #endif
 
     this.findManifestUrlFor(aUrl, aCallback);
   },
 
   getManifestFor: function (aUrl, aCallback) {