bug 1336901 - remove incorrect assert r=yzen
authorTrevor Saunders <tbsaunde@tbsaunde.org>
Mon, 06 Feb 2017 01:27:49 -0500
changeset 340941 e6f37c68fb8f61fc4332c6d61ee3d7342cd4c1ed
parent 340940 cf21f7fd62825bc4ddc98bdd65a06b8ad553418c
child 340942 c373084a5a579a5e01cb417fd895761472a7ddae
push id86599
push usertsaunders@mozilla.com
push dateMon, 06 Feb 2017 18:10:11 +0000
treeherdermozilla-inbound@e6f37c68fb8f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyzen
bugs1336901
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1336901 - remove incorrect assert r=yzen There are cases where there is no good reason to shutdown the child document actors before the parent. For example when TabParent::DestroyInternal() is about to send the Destroy message we might as well just shut down the top level document and let that tear down the rest.
accessible/ipc/DocAccessibleParent.cpp
--- a/accessible/ipc/DocAccessibleParent.cpp
+++ b/accessible/ipc/DocAccessibleParent.cpp
@@ -456,18 +456,16 @@ void
 DocAccessibleParent::Destroy()
 {
   // If we are already shutdown that is because our containing tab parent is
   // shutting down in which case we don't need to do anything.
   if (mShutdown) {
     return;
   }
 
-  NS_ASSERTION(mChildDocs.IsEmpty(),
-               "why weren't the child docs destroyed already?");
   mShutdown = true;
 
   uint32_t childDocCount = mChildDocs.Length();
   for (uint32_t i = 0; i < childDocCount; i++) {
     for (uint32_t j = i + 1; j < childDocCount; j++) {
       MOZ_DIAGNOSTIC_ASSERT(mChildDocs[i] != mChildDocs[j]);
     }
   }