Bug 1168979 part 8 - Fix breakage in decision task for non-try branches; r=mrrrgn
authorAnthony Miyaguchi <amiyaguchi@mozilla.com>
Thu, 16 Jul 2015 14:56:45 -0700
changeset 253703 e58aba8b984b5338620c75d5af34182a5c2193af
parent 253702 f8f36f94b285ce38d77a50b3b7c87855dc82753d
child 253704 8866687fc60408f0348d01c8ef954714df955476
push id62530
push usermphillips@mozilla.com
push dateMon, 20 Jul 2015 16:46:59 +0000
treeherdermozilla-inbound@e58aba8b984b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmrrrgn
bugs1168979
milestone42.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1168979 part 8 - Fix breakage in decision task for non-try branches; r=mrrrgn
testing/taskcluster/taskcluster_graph/commit_parser.py
testing/taskcluster/tasks/branches/base_job_flags.yml
testing/taskcluster/tasks/branches/try/job_flags.yml
--- a/testing/taskcluster/taskcluster_graph/commit_parser.py
+++ b/testing/taskcluster/taskcluster_graph/commit_parser.py
@@ -256,19 +256,20 @@ def parse_commit(message, jobs):
 
             if 'additional-parameters' in platform_build:
                 additional_parameters = platform_build['additional-parameters']
             else:
                 additional_parameters = {}
 
             # Generate list of post build tasks that run on this build
             post_build_jobs = []
-            for job_flag in jobs['flags']['post-build']:
+            for job_flag in jobs['flags'].get('post-build', []):
                 job = jobs['post-build'][job_flag]
-                if 'allowed_build_tasks' in job and build_task not in job['allowed_build_tasks']:
+                if ('allowed_build_tasks' in job and
+                        build_task not in job['allowed_build_tasks']):
                     continue
                 post_build_jobs.append(copy.deepcopy(job))
 
             # Node for this particular build type
             result.append({
                 'task': build_task,
                 'post-build': post_build_jobs,
                 'dependents': extract_tests_from_platform(
--- a/testing/taskcluster/tasks/branches/base_job_flags.yml
+++ b/testing/taskcluster/tasks/branches/base_job_flags.yml
@@ -30,19 +30,16 @@ flags:
     - aries-blobfree
     - aries-ota
     - aries-eng
     - aries-eng-blobfree
     - aries-dogfood
     - android-api-11
     - linux64
 
-  post-build:
-    - upload-symbols
-    
   tests:
     - cppunit
     - crashtest
     - crashtest-ipc
     - gaia-build
     - gaia-build-unit
     - gaia-js-integration
     - gaia-linter
--- a/testing/taskcluster/tasks/branches/try/job_flags.yml
+++ b/testing/taskcluster/tasks/branches/try/job_flags.yml
@@ -1,15 +1,20 @@
 ---
 # For complete sample of all build and test jobs,
 # see <gecko>/testing/taskcluster/tasks/job_flags.yml
 
 $inherits:
   from: tasks/branches/base_job_flags.yml
 
+# Flags specific to this branch
+flags:
+  post-build:
+    - upload-symbols
+
 builds:
   linux64_gecko:
     platforms:
       - b2g
     types:
       opt:
         task: tasks/builds/b2g_desktop_opt.yml
       debug: