Bug 1201393. Remove usage of FLAG_BLOCK_INPUT from MediaRecorder. r=jwwang
authorRobert O'Callahan <robert@ocallahan.org>
Mon, 31 Aug 2015 16:54:39 +1200
changeset 261211 e3c818c2987275aef9065fe8e7703818aebc76e6
parent 261210 75832092cd8d4ae16ef263b1e62c947db77bc241
child 261212 0f56b9b904a2ec1356e58ad4b0a1c25b362770cc
push id64690
push userrocallahan@mozilla.com
push dateTue, 08 Sep 2015 04:29:49 +0000
treeherdermozilla-inbound@321303b7d428 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjwwang
bugs1201393
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1201393. Remove usage of FLAG_BLOCK_INPUT from MediaRecorder. r=jwwang FLAG_BLOCK_INPUT is not needed on mPipeStream because nothing should cause mPipeStream to block.
dom/media/MediaRecorder.cpp
--- a/dom/media/MediaRecorder.cpp
+++ b/dom/media/MediaRecorder.cpp
@@ -787,17 +787,17 @@ MediaRecorder::MediaRecorder(AudioNode& 
     AudioNodeEngine* engine = new AudioNodeEngine(nullptr);
     AudioNodeStream::Flags flags =
       AudioNodeStream::EXTERNAL_OUTPUT |
       AudioNodeStream::NEED_MAIN_THREAD_FINISHED;
     mPipeStream = AudioNodeStream::Create(ctx->Graph(), engine, flags);
     AudioNodeStream* ns = aSrcAudioNode.GetStream();
     if (ns) {
       mInputPort = mPipeStream->AllocateInputPort(aSrcAudioNode.GetStream(),
-                                                  MediaInputPort::FLAG_BLOCK_INPUT,
+                                                  0,
                                                   0,
                                                   aSrcOutput);
     }
   }
   mAudioNode = &aSrcAudioNode;
   if (!gMediaRecorderLog) {
     gMediaRecorderLog = PR_NewLogModule("MediaRecorder");
   }